[{"id":34787,"web_url":"https://patchwork.libcamera.org/comment/34787/","msgid":"","date":"2025-07-07T08:23:56","subject":"Re: [PATCH v2] libpisp: update to 1.2.1 to silence\n\t\"unused-parameter\" warning","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Christian,\n\nThanks for the patch.\n\nOn Fri, 4 Jul 2025 at 19:07, Christian Rauch wrote:\n>\n> Signed-off-by: Christian Rauch \n\nI think you might want to add a line or two in the commit message\nabout the existing warning generated. Otherwise, happy to go ahead\nwith this.\n\nReviewed-by: Naushir Patuck \n\n> ---\n> subprojects/libpisp.wrap | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/subprojects/libpisp.wrap b/subprojects/libpisp.wrap\n> index 8b62c036f..0e0c7baaf 100644\n> --- a/subprojects/libpisp.wrap\n> +++ b/subprojects/libpisp.wrap\n> @@ -2,5 +2,5 @@\n>\n> [wrap-git]\n> url = https://github.com/raspberrypi/libpisp.git\n> -revision = v1.2.0\n> +revision = v1.2.1\n> depth = 1\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20A86C3237\n\tfor ;\n\tMon, 7 Jul 2025 08:24:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 936AB68E7F;\n\tMon, 7 Jul 2025 10:24:31 +0200 (CEST)","from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com\n\t[IPv6:2607:f8b0:4864:20::92b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0216B68E66\n\tfor ;\n\tMon, 7 Jul 2025 10:24:28 +0200 (CEST)","by mail-ua1-x92b.google.com with SMTP id\n\ta1e0cc1a2514c-87ee7aeed68so115017241.1\n\tfor ;\n\tMon, 07 Jul 2025 01:24:28 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ATUVL4W7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1751876668; x=1752481468;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=pLd5Qi8wDy50/pQ7LayH0BRGYaFitsBVA6G4TGYc1zA=;\n\tb=ATUVL4W7uKqEFIRmbhFRufZiFd+EbC803UCrcdspe08gfoPDwYBTz/2xwfT6BLLg+f\n\tE1qxBMZE3VRmd11IASrE20nVY1iXWWKcxxSwvNAb/z54fl3GftzL1G+TKPV+2V4J2NR5\n\tdjxKwBc4tNzVVfniaMdpkOauDhBi1FnRKWIPYwtgdbgFYb6l/DqRLEMPd0PU4Eiu760U\n\tyIVX6p4Z9++EdkLzTXHaYjyeqoa2fTv3Ri3BMokqTD6t/1cq7shSzHmwl7G7Dh+Ex7jz\n\tthYJj2K6gAEkFcuwcqA3mHZlPV2jDkPreXsrvC2CmaEfrCVrZSiVHE1A23cI6B23ea3Q\n\tg1gA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1751876668; x=1752481468;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=pLd5Qi8wDy50/pQ7LayH0BRGYaFitsBVA6G4TGYc1zA=;\n\tb=qQ8p4hh2oifMGh2lHYTWxzvYMTaOdvK4zYKHsJIapAmtD6A3rPbDLDTgSoNRmIs001\n\tn+4mvJvD7xz4gy7zXepXmrosMDzBTAVQNB6Onk3azqhWf7hzXTbLIEmGOoj0qMc9xLB2\n\tUHvWl5gSWUx5xCuBciMmryN/It6BrW8/vXEeV2lSTxgeqaNjNSUGP3v3F6DD79OtFVur\n\tLT21WsVlEc1/v6toM9NFvX3HBIynvycl4/3OmUoHJe52qyUNfv2g1qhohMIrJH185HJj\n\tMldCaAPcpdqZ7TlwDpP3FVOdYW+6p9iXQvpgwFkvLWyjsRpvLP9YPooWycVOd5eOdeUl\n\tFzkA==","X-Gm-Message-State":"AOJu0YyCRN1ZXdxopdI9emmkz+G+whUczJl1q1K3Aa5gFaVd8g07V6IG\n\tyriPc43FyozxTNpYRWUkskhgsosAzY5nI0Nc8UxfwWydMFQ69PP1VWUQa8WlyV70VSsy2ncG3j7\n\tWn7eglxOidpTviODdxZx1+j4XwstROeSFtv9dn3h0IeWNfvRFwEyp","X-Gm-Gg":"ASbGnct7+VDxSNYlJSxRwgG6CjN3+BDWHU0tz7PnEAFd2KNtxfDGs2A2bx2ohm+Zx5S\n\tV90t7dOI4PiRkMz588wus12uGAnwrYFV+LMepcEMh9B4Qbin4lyJ9oGoRs3bqae5AWPU2K1rbAJ\n\t/wtMu5LMwc33PsmzcMczKxAAAkFCjEvjmdQBEalYnHvp/qJSYAHrhDSxEMGoDFtc/jpFoz/jwHn\n\tQqJ14XlDWfnnw==","X-Google-Smtp-Source":"AGHT+IFnqlhfAsrLoULkmmLvK9xbFnuGKGyRtjLx2/B617oxQeuNc5LmZ+szcHUMrUO4+jKPzP1MNssF/kzqbzRWiLg=","X-Received":"by 2002:a05:6102:5a94:b0:4e5:94b3:7245 with SMTP id\n\tada2fe7eead31-4f2f1985d33mr1912003137.8.1751876667777;\n\tMon, 07 Jul 2025 01:24:27 -0700 (PDT)","MIME-Version":"1.0","References":"<20250704180641.1882328-1-Rauch.Christian@gmx.de>","In-Reply-To":"<20250704180641.1882328-1-Rauch.Christian@gmx.de>","From":"Naushir Patuck ","Date":"Mon, 7 Jul 2025 09:23:56 +0100","X-Gm-Features":"Ac12FXw-sM4xNPMlkf_KqwbRKVHLCGTdCb4MvI7worozJNosKj6qodKk8Pag8dE","Message-ID":"","Subject":"Re: [PATCH v2] libpisp: update to 1.2.1 to silence\n\t\"unused-parameter\" warning","To":"Christian Rauch ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34795,"web_url":"https://patchwork.libcamera.org/comment/34795/","msgid":"<175188452587.1668806.3094599181258421174@ping.linuxembedded.co.uk>","date":"2025-07-07T10:35:25","subject":"Re: [PATCH v2] libpisp: update to 1.2.1 to silence\n\t\"unused-parameter\" warning","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2025-07-07 09:23:56)\n> Hi Christian,\n> \n> Thanks for the patch.\n> \n> On Fri, 4 Jul 2025 at 19:07, Christian Rauch wrote:\n> >\n> > Signed-off-by: Christian Rauch \n> \n> I think you might want to add a line or two in the commit message\n> about the existing warning generated. Otherwise, happy to go ahead\n> with this.\n\nIs there any helpful reference to an issue tracker too?\n\nI would recommend keeping the commit title simple and the rationale in\nthe commit message as :\n\n\"\"\"\nsubprojects: libpisp: Update to 1.2.1\n\nUpdate the libpisp wrap to use the latest 1.2.1 release which silences\nan 'unused-parameter' warning.\n\nBug: \nReviewed-by: Naushir Patuck \nSigned-off-by: Christian Rauch \n\"\"\"\n\nCan be updated while applying easily though.\n\n\nAcked-by: Kieran Bingham \n\n> \n> Reviewed-by: Naushir Patuck \n> \n> > ---\n> > subprojects/libpisp.wrap | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/subprojects/libpisp.wrap b/subprojects/libpisp.wrap\n> > index 8b62c036f..0e0c7baaf 100644\n> > --- a/subprojects/libpisp.wrap\n> > +++ b/subprojects/libpisp.wrap\n> > @@ -2,5 +2,5 @@\n> >\n> > [wrap-git]\n> > url = https://github.com/raspberrypi/libpisp.git\n> > -revision = v1.2.0\n> > +revision = v1.2.1\n> > depth = 1\n> > --\n> > 2.43.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2B08DC3237\n\tfor ;\n\tMon, 7 Jul 2025 10:35:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D600668E92;\n\tMon, 7 Jul 2025 12:35:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 17EA668E74\n\tfor ;\n\tMon, 7 Jul 2025 12:35:29 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 26934667;\n\tMon, 7 Jul 2025 12:35:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"G+q1E26I\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751884502;\n\tbh=/hQGKOpw3DjP6/hZXwoHYDpS8HFMH/Ii1HzbCrwyVG0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=G+q1E26Ibp+9vJsiGXAtOhd4QPPC2oWet98WAljKcRoJB3W9Sjvs2sWMzo5FxCzCZ\n\tve8kNKg26u2kw5jLPZZVNrYeyzJMuOoiwZ2bzRUvIH/DhzkfQMVvHTnbXWNhwA9sqH\n\texFPnlzZQp/1sTKXTVbMGPWDcoR9x7EiwY8cURB4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20250704180641.1882328-1-Rauch.Christian@gmx.de>\n\t","Subject":"Re: [PATCH v2] libpisp: update to 1.2.1 to silence\n\t\"unused-parameter\" warning","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Christian Rauch ,\n\tNaushir Patuck ","Date":"Mon, 07 Jul 2025 11:35:25 +0100","Message-ID":"<175188452587.1668806.3094599181258421174@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]