[{"id":34825,"web_url":"https://patchwork.libcamera.org/comment/34825/","msgid":"<175197916004.2538045.10082923741580132970@ping.linuxembedded.co.uk>","date":"2025-07-08T12:52:40","subject":"Re: [PATCH] apps: cam: Print enum string for camera properties","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain (2025-07-03 15:06:31)\n> Some camera properties might be set as a enumeration for e.g.\n> properties::Location. Instead of printing the int32_t values\n> for the enumeration, print the enum string as well. This will\n> enhance the readability for the user.\n> \n> Signed-off-by: Umang Jain \n> ---\n> src/apps/cam/camera_session.cpp | 12 +++++++++++-\n> 1 file changed, 11 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\n> index f63fcb22..feef1585 100644\n> --- a/src/apps/cam/camera_session.cpp\n> +++ b/src/apps/cam/camera_session.cpp\n> @@ -236,7 +236,17 @@ void CameraSession::listProperties() const\n> const ControlId *id = properties::properties.at(key);\n> \n> std::cout << \"Property: \" << id->name() << \" = \"\n> - << value.toString() << std::endl;\n> + << value.toString();\n> +\n> + if (value.type() == ControlTypeInteger32) {\n> + int32_t val = value.get();\n> + const auto &iter = id->enumerators().find(val);\n> +\n> + if (iter != id->enumerators().end())\n> + std::cout << \" [ \" << iter->second << \" ]\";\n> + }\n\nkbingham@Monstersaurus:~/iob/libcamera/libcamera$ ./build/gcc/src/apps/cam/cam -c1 -p\n[229:51:49.724482741] [993813] INFO IPAManager ipa_manager.cpp:137 libcamera is not installed. Adding '/home/kbingham/iob/libcamera/libcamera/build/gcc/src/ipa' to the IPA search path\n[229:51:49.728307982] [993813] INFO Camera camera_manager.cpp:326 libcamera v0.5.1+52-c25425a4\n[229:51:49.793623769] [993816] INFO Pipeline pipeline_handler.cpp:618 libcamera is not installed. Loading platform configuration file from '/home/kbingham/iob/libcamera/libcamera/src/libcamera/pipeline/virtual/data/virtual.yaml'\nUsing camera \\_SB_.PCI0.GP13.XHC0.RHUB.PRT3-3.4:1.0-046d:085e as cam0\nProperty: SystemDevices = [ 20736 ]\nProperty: PixelArrayActiveAreas = [ (0, 0)/1920x1080 ]\nProperty: PixelArraySize = 1920x1080\nProperty: Location = 2 [ CameraLocationExternal ]\nProperty: Model = Logitech BRIO\n\n\nYeah, I like that...\n\nReviewed-by: Kieran Bingham \nTested-by: Kieran Bingham \n\n> +\n> + std::cout << std::endl;\n> }\n> }\n> \n> -- \n> 2.50.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 223ABC3237\n\tfor ;\n\tTue, 8 Jul 2025 12:52:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D13F868EA8;\n\tTue, 8 Jul 2025 14:52:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8205261519\n\tfor ;\n\tTue, 8 Jul 2025 14:52:43 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CFE43667;\n\tTue, 8 Jul 2025 14:52:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gSsRLyIB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751979135;\n\tbh=VXrUUOms3LbU5Ov0qk0cpVXKcOZtwfLeUs52j26mjv4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=gSsRLyIBfL/ozSWvPdlo1ZJaH42r/EK1MJ1aKGhBbfASbCLQiNBFOnUaNnNguI6Wy\n\trol3UAr0s2m2tdSK5vlJIxrpyVjgsZTAtRF4+t154EmRzVw9Pn91Em2Of5t0LVxFhX\n\t6I0/r3mrmIMUk/FsBKy0yptfxgFmQ4JeBLExhBTw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250703140631.29979-1-uajain@igalia.com>","References":"<20250703140631.29979-1-uajain@igalia.com>","Subject":"Re: [PATCH] apps: cam: Print enum string for camera properties","From":"Kieran Bingham ","Cc":"Umang Jain ","To":"Umang Jain , libcamera-devel@lists.libcamera.org","Date":"Tue, 08 Jul 2025 13:52:40 +0100","Message-ID":"<175197916004.2538045.10082923741580132970@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34828,"web_url":"https://patchwork.libcamera.org/comment/34828/","msgid":"<75a56081-58c2-45e6-ae57-68f50226cbc9@ideasonboard.com>","date":"2025-07-09T07:16:09","subject":"Re: [PATCH] apps: cam: Print enum string for camera properties","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n\n2025. 07. 08. 14:52 keltezéssel, Kieran Bingham írta:\n> Quoting Umang Jain (2025-07-03 15:06:31)\n>> Some camera properties might be set as a enumeration for e.g.\n>> properties::Location. Instead of printing the int32_t values\n>> for the enumeration, print the enum string as well. This will\n>> enhance the readability for the user.\n>>\n>> Signed-off-by: Umang Jain \n>> ---\n>> src/apps/cam/camera_session.cpp | 12 +++++++++++-\n>> 1 file changed, 11 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\n>> index f63fcb22..feef1585 100644\n>> --- a/src/apps/cam/camera_session.cpp\n>> +++ b/src/apps/cam/camera_session.cpp\n>> @@ -236,7 +236,17 @@ void CameraSession::listProperties() const\n>> const ControlId *id = properties::properties.at(key);\n>> \n>> std::cout << \"Property: \" << id->name() << \" = \"\n>> - << value.toString() << std::endl;\n>> + << value.toString();\n>> +\n>> + if (value.type() == ControlTypeInteger32) {\n\nMaybe `!id->enumerators().empty()`?\n\n\n>> + int32_t val = value.get();\n>> + const auto &iter = id->enumerators().find(val);\n>> +\n>> + if (iter != id->enumerators().end())\n>> + std::cout << \" [ \" << iter->second << \" ]\";\n>> + }\n> \n> kbingham@Monstersaurus:~/iob/libcamera/libcamera$ ./build/gcc/src/apps/cam/cam -c1 -p\n> [229:51:49.724482741] [993813] INFO IPAManager ipa_manager.cpp:137 libcamera is not installed. Adding '/home/kbingham/iob/libcamera/libcamera/build/gcc/src/ipa' to the IPA search path\n> [229:51:49.728307982] [993813] INFO Camera camera_manager.cpp:326 libcamera v0.5.1+52-c25425a4\n> [229:51:49.793623769] [993816] INFO Pipeline pipeline_handler.cpp:618 libcamera is not installed. Loading platform configuration file from '/home/kbingham/iob/libcamera/libcamera/src/libcamera/pipeline/virtual/data/virtual.yaml'\n> Using camera \\_SB_.PCI0.GP13.XHC0.RHUB.PRT3-3.4:1.0-046d:085e as cam0\n> Property: SystemDevices = [ 20736 ]\n> Property: PixelArrayActiveAreas = [ (0, 0)/1920x1080 ]\n> Property: PixelArraySize = 1920x1080\n> Property: Location = 2 [ CameraLocationExternal ]\n\nTo me, using \"( ... )\" instead of \"[ ... ]\" (which is already used for arrays)\nwould be a bit clearer.\n\nReviewed-by: Barnabás Pőcze \n\n\nRegards,\nBarnabás Pőcze\n\n\n> Property: Model = Logitech BRIO\n> \n> \n> Yeah, I like that...\n> \n> Reviewed-by: Kieran Bingham \n> Tested-by: Kieran Bingham \n> \n>> +\n>> + std::cout << std::endl;\n>> }\n>> }\n>> \n>> -- \n>> 2.50.0\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4CA5AC3237\n\tfor ;\n\tWed, 9 Jul 2025 07:16:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1CA3B68EE6;\n\tWed, 9 Jul 2025 09:16:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 80F1E68E30\n\tfor ;\n\tWed, 9 Jul 2025 09:16:13 +0200 (CEST)","from [192.168.33.21] (185.221.141.183.nat.pool.zt.hu\n\t[185.221.141.183])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2CDA6669;\n\tWed, 9 Jul 2025 09:15:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tjnfT7SJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1752045345;\n\tbh=KmnEjhu3EXWfF0iM9DWODRvw1E2lACjivqSoeZsJCtU=;\n\th=Date:Subject:To:References:From:Cc:In-Reply-To:From;\n\tb=tjnfT7SJTeWVXsnvpiw0V7Juqp4CirBzWUndR7X3kybht8YPKbN5cr4R+CvAeYCBD\n\tRhOKa2289kEEgp+2/ZHtgMcerPtoYhpUrAHykzteFb+eW1n2iiLbmXoHkY4COursLC\n\tnCJ7mLltQkfgiXbfIs8gXB9Q8GX/BqcWq+Cy1MQc=","Message-ID":"<75a56081-58c2-45e6-ae57-68f50226cbc9@ideasonboard.com>","Date":"Wed, 9 Jul 2025 09:16:09 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] apps: cam: Print enum string for camera properties","To":"Umang Jain , libcamera-devel@lists.libcamera.org","References":"<20250703140631.29979-1-uajain@igalia.com>\n\t<175197916004.2538045.10082923741580132970@ping.linuxembedded.co.uk>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","Cc":"Kieran Bingham ","In-Reply-To":"<175197916004.2538045.10082923741580132970@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34969,"web_url":"https://patchwork.libcamera.org/comment/34969/","msgid":"<175309869130.3943007.17290887017980517133@ping.linuxembedded.co.uk>","date":"2025-07-21T11:51:31","subject":"Re: [PATCH] apps: cam: Print enum string for camera properties","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Umang,\n\nAny feedback on the below? Will you post a v2 or do you want this\nversion merged?\n\n--\nKieran\n\nQuoting Barnabás Pőcze (2025-07-09 08:16:09)\n> Hi\n> \n> \n> 2025. 07. 08. 14:52 keltezéssel, Kieran Bingham írta:\n> > Quoting Umang Jain (2025-07-03 15:06:31)\n> >> Some camera properties might be set as a enumeration for e.g.\n> >> properties::Location. Instead of printing the int32_t values\n> >> for the enumeration, print the enum string as well. This will\n> >> enhance the readability for the user.\n> >>\n> >> Signed-off-by: Umang Jain \n> >> ---\n> >> src/apps/cam/camera_session.cpp | 12 +++++++++++-\n> >> 1 file changed, 11 insertions(+), 1 deletion(-)\n> >>\n> >> diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\n> >> index f63fcb22..feef1585 100644\n> >> --- a/src/apps/cam/camera_session.cpp\n> >> +++ b/src/apps/cam/camera_session.cpp\n> >> @@ -236,7 +236,17 @@ void CameraSession::listProperties() const\n> >> const ControlId *id = properties::properties.at(key);\n> >> \n> >> std::cout << \"Property: \" << id->name() << \" = \"\n> >> - << value.toString() << std::endl;\n> >> + << value.toString();\n> >> +\n> >> + if (value.type() == ControlTypeInteger32) {\n> \n> Maybe `!id->enumerators().empty()`?\n> \n> \n> >> + int32_t val = value.get();\n> >> + const auto &iter = id->enumerators().find(val);\n> >> +\n> >> + if (iter != id->enumerators().end())\n> >> + std::cout << \" [ \" << iter->second << \" ]\";\n> >> + }\n> > \n> > kbingham@Monstersaurus:~/iob/libcamera/libcamera$ ./build/gcc/src/apps/cam/cam -c1 -p\n> > [229:51:49.724482741] [993813] INFO IPAManager ipa_manager.cpp:137 libcamera is not installed. Adding '/home/kbingham/iob/libcamera/libcamera/build/gcc/src/ipa' to the IPA search path\n> > [229:51:49.728307982] [993813] INFO Camera camera_manager.cpp:326 libcamera v0.5.1+52-c25425a4\n> > [229:51:49.793623769] [993816] INFO Pipeline pipeline_handler.cpp:618 libcamera is not installed. Loading platform configuration file from '/home/kbingham/iob/libcamera/libcamera/src/libcamera/pipeline/virtual/data/virtual.yaml'\n> > Using camera \\_SB_.PCI0.GP13.XHC0.RHUB.PRT3-3.4:1.0-046d:085e as cam0\n> > Property: SystemDevices = [ 20736 ]\n> > Property: PixelArrayActiveAreas = [ (0, 0)/1920x1080 ]\n> > Property: PixelArraySize = 1920x1080\n> > Property: Location = 2 [ CameraLocationExternal ]\n> \n> To me, using \"( ... )\" instead of \"[ ... ]\" (which is already used for arrays)\n> would be a bit clearer.\n> \n> Reviewed-by: Barnabás Pőcze \n> \n> \n> Regards,\n> Barnabás Pőcze\n> \n> \n> > Property: Model = Logitech BRIO\n> > \n> > \n> > Yeah, I like that...\n> > \n> > Reviewed-by: Kieran Bingham \n> > Tested-by: Kieran Bingham \n> > \n> >> +\n> >> + std::cout << std::endl;\n> >> }\n> >> }\n> >> \n> >> -- \n> >> 2.50.0\n> >>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7477BDCC1\n\tfor ;\n\tMon, 21 Jul 2025 11:51:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A895B68FEB;\n\tMon, 21 Jul 2025 13:51:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE49468FD0\n\tfor ;\n\tMon, 21 Jul 2025 13:51:34 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 401C8EAE;\n\tMon, 21 Jul 2025 13:50:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tp1EZWyY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753098657;\n\tbh=qLFxAfy9m1UPvQSxqaIhuzIK/vrXwOpsn+ui8TxSsYE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=tp1EZWyY0Na0iIi56ZRJKY3kJ4nnEdbnjtTghAQPDjT/tev1/TITNaouRoZkijmBl\n\t1m+aeQcmVupNLFwa1CiOF2fdOYnCKry2vnzZkwqvmwdIFoH+ZuLEiSH+qValVO0w1t\n\tCppUaq7xlo9DgysbMa2HhMp8ybQv0r+MuTRE6h2A=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<75a56081-58c2-45e6-ae57-68f50226cbc9@ideasonboard.com>","References":"<20250703140631.29979-1-uajain@igalia.com>\n\t<175197916004.2538045.10082923741580132970@ping.linuxembedded.co.uk>\n\t<75a56081-58c2-45e6-ae57-68f50226cbc9@ideasonboard.com>","Subject":"Re: [PATCH] apps: cam: Print enum string for camera properties","From":"Kieran Bingham ","Cc":"","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tUmang Jain , libcamera-devel@lists.libcamera.org","Date":"Mon, 21 Jul 2025 12:51:31 +0100","Message-ID":"<175309869130.3943007.17290887017980517133@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]