{"id":23740,"url":"https://patchwork.libcamera.org/api/patches/23740/?format=json","web_url":"https://patchwork.libcamera.org/patch/23740/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250703140631.29979-1-uajain@igalia.com>","date":"2025-07-03T14:06:31","name":"apps: cam: Print enum string for camera properties","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"41ab9e2b75fe56b5d74919e2cd19a2dfce2cfd55","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/?format=json","name":"Umang Jain","email":"uajain@igalia.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23740/mbox/","series":[{"id":5269,"url":"https://patchwork.libcamera.org/api/series/5269/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5269","date":"2025-07-03T14:06:31","name":"apps: cam: Print enum string for camera properties","version":1,"mbox":"https://patchwork.libcamera.org/series/5269/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23740/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23740/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B1A8DBDCBF\n\tfor ;\n\tThu, 3 Jul 2025 14:06:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 579F868E4B;\n\tThu, 3 Jul 2025 16:06:33 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4F4461528\n\tfor ;\n\tThu, 3 Jul 2025 16:06:30 +0200 (CEST)","from [49.36.71.127] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1uXKa5-00Bvsn-N8; Thu, 03 Jul 2025 16:06:30 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"RTffKCaQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:\n\tCc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tIn-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=O/6D2LvDFXEMdEhUPOMsiiWBM9UiVGsJzWk31GdoUQQ=;\n\tb=RTffKCaQvwCMVtXdsO/y8Gzudi\n\tLYzcF70EcDohN+HUpv3uNE4BTierjgr+xbYK87b0jFtl1v7Dm9vo1U3BGRKI1lQlMJtKjBIPHZKL7\n\ty+/2ZpjYAGfBr+ZcVTKZOrMzw0LG3PkU9i4zR94IpKXIogvZAJVvdnGHyxUGW8Cz1FxXGUmT9wVTG\n\t4ai/DsPe1axsy/0bKbckM0jI84zUngFpzl/yFlTQmNFWAJav9P/dSCT/KlaBmYwO93ZmKzAWM6Zkl\n\tyrvkzKaw1XYWxLcIdzztxqYyX4soU7bdSQLbvtesNqNCza9UjwOgWbVazB0rK0akUcyKKs8ILHl8W\n\t1iyuljUw==;","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Umang Jain ","Subject":"[PATCH] apps: cam: Print enum string for camera properties","Date":"Thu, 3 Jul 2025 19:36:31 +0530","Message-ID":"<20250703140631.29979-1-uajain@igalia.com>","X-Mailer":"git-send-email 2.50.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Some camera properties might be set as a enumeration for e.g.\nproperties::Location. Instead of printing the int32_t values\nfor the enumeration, print the enum string as well. This will\nenhance the readability for the user.\n\nSigned-off-by: Umang Jain \n---\n src/apps/cam/camera_session.cpp | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)","diff":"diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex f63fcb22..feef1585 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -236,7 +236,17 @@ void CameraSession::listProperties() const\n \t\tconst ControlId *id = properties::properties.at(key);\n \n \t\tstd::cout << \"Property: \" << id->name() << \" = \"\n-\t\t\t << value.toString() << std::endl;\n+\t\t\t << value.toString();\n+\n+\t\tif (value.type() == ControlTypeInteger32) {\n+\t\t\tint32_t val = value.get();\n+\t\t\tconst auto &iter = id->enumerators().find(val);\n+\n+\t\t\tif (iter != id->enumerators().end())\n+\t\t\t\tstd::cout << \" [ \" << iter->second << \" ]\";\n+\t\t}\n+\n+\t\tstd::cout << std::endl;\n \t}\n }\n \n","prefixes":[]}