[{"id":34794,"web_url":"https://patchwork.libcamera.org/comment/34794/","msgid":"<175188350676.40598.9616502733535623414@localhost>","date":"2025-07-07T10:18:26","subject":"Re: [PATCH v2 3/8] libcamera: camera: Add indirection to Camera\n\tsignal emissions","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nQuoting Paul Elder (2025-07-03 13:42:18)\n> Add an extra level of indirection when emitting signals from the Camera.\n> This is to facilitate the implementation of the layer system in the near\n> future, which will need to hook into Camera signal emissions.\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> No change in v2\n> ---\n> include/libcamera/internal/camera.h | 4 ++++\n> src/libcamera/camera.cpp | 23 +++++++++++++++++++++--\n> src/libcamera/pipeline_handler.cpp | 2 +-\n> src/libcamera/request.cpp | 2 +-\n> 4 files changed, 27 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\n> index 18f5c32a18e4..967d4e1693ec 100644\n> --- a/include/libcamera/internal/camera.h\n> +++ b/include/libcamera/internal/camera.h\n> @@ -35,6 +35,10 @@ public:\n> PipelineHandler *pipe() { return pipe_.get(); }\n> const PipelineHandler *pipe() const { return pipe_.get(); }\n> \n> + void emitBufferCompleted(Request *request, FrameBuffer *buffer);\n> + void emitRequestCompleted(Request *request);\n> + void emitDisconnected();\n> +\n> std::list queuedRequests_;\n> ControlInfoMap controlInfo_;\n> ControlList properties_;\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index c180a5fdde93..c3e656cab671 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -737,6 +737,25 @@ void Camera::Private::setState(State state)\n> {\n> state_.store(state, std::memory_order_release);\n> }\n> +\n\nI'm often unsure about the order of the functions in the .cpp/.h. As you\nplaced it before setState in the header and the functions are before\nsetState alphabetically also, I would probably move them before\nsetState().\n\nI thought doxygen would nag the missing documentation as these functions\nare public. Anyways these are pretty self-explanatory.\n\nReviewed-by: Stefan Klug \n\n> +void Camera::Private::emitBufferCompleted(Request *request, FrameBuffer *buffer)\n> +{\n> + Camera *camera = _o();\n> + camera->bufferCompleted.emit(request, buffer);\n> +}\n> +\n> +void Camera::Private::emitRequestCompleted(Request *request)\n> +{\n> + Camera *camera = _o();\n> + camera->requestCompleted.emit(request);\n> +}\n> +\n> +void Camera::Private::emitDisconnected()\n> +{\n> + Camera *camera = _o();\n> + camera->disconnected.emit();\n> +}\n> +\n> #endif /* __DOXYGEN_PUBLIC__ */\n> \n> /**\n> @@ -947,7 +966,7 @@ void Camera::disconnect()\n> LOG(Camera, Debug) << \"Disconnecting camera \" << id();\n> \n> _d()->disconnect();\n> - disconnected.emit();\n> + _d()->emitDisconnected();\n> }\n> \n> int Camera::exportFrameBuffers(Stream *stream,\n> @@ -1451,7 +1470,7 @@ void Camera::requestComplete(Request *request)\n> true))\n> LOG(Camera, Fatal) << \"Trying to complete a request when stopped\";\n> \n> - requestCompleted.emit(request);\n> + _d()->emitRequestCompleted(request);\n> }\n> \n> } /* namespace libcamera */\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index d84dff3c9f19..b5faaae08d4c 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -527,7 +527,7 @@ void PipelineHandler::doQueueRequests()\n> bool PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer)\n> {\n> Camera *camera = request->_d()->camera();\n> - camera->bufferCompleted.emit(request, buffer);\n> + camera->_d()->emitBufferCompleted(request, buffer);\n> return request->_d()->completeBuffer(buffer);\n> }\n> \n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index 7f1e11e8f913..b4ae0f41a34c 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -137,7 +137,7 @@ void Request::Private::doCancelRequest()\n> \n> for (FrameBuffer *buffer : pending_) {\n> buffer->_d()->cancel();\n> - camera_->bufferCompleted.emit(request, buffer);\n> + camera_->_d()->emitBufferCompleted(request, buffer);\n> }\n> \n> cancelled_ = true;\n> -- \n> 2.47.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D3E2C0DA4\n\tfor ;\n\tMon, 7 Jul 2025 10:18:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D862768E92;\n\tMon, 7 Jul 2025 12:18:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50AF268E74\n\tfor ;\n\tMon, 7 Jul 2025 12:18:30 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:c79f:85df:e7f5:4c31])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 75358C6A;\n\tMon, 7 Jul 2025 12:18:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nvbEg9wQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751883483;\n\tbh=qTQZM46H7XzL7Kf5jj/ycunVVEEdWB4NJ7qLef2sFvA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=nvbEg9wQA6nYEJ6rFxnJCfFVZga8q4+fZh/lM52ZiyBRdKdEvm545IVps6EyaPJ25\n\tvzkk1vxaCze6s7gC8kuUpGY8X9YstPMnftJ005N4Vu/mIc9yyZt4E6/j0cXZbRRc7P\n\tRsU+9iZqYwVkWwqZa6qD0tFCyQCjFUN9j8B8/C7U=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250703114225.2074071-4-paul.elder@ideasonboard.com>","References":"<20250703114225.2074071-1-paul.elder@ideasonboard.com>\n\t<20250703114225.2074071-4-paul.elder@ideasonboard.com>","Subject":"Re: [PATCH v2 3/8] libcamera: camera: Add indirection to Camera\n\tsignal emissions","From":"Stefan Klug ","Cc":"Paul Elder , kieran.bingham@ideasonboard.com,\n\tbarnabas.pocze@ideasonboard.com","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 07 Jul 2025 12:18:26 +0200","Message-ID":"<175188350676.40598.9616502733535623414@localhost>","User-Agent":"alot/0.12.dev8+g2c003385c862.d20250602","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35036,"web_url":"https://patchwork.libcamera.org/comment/35036/","msgid":"<175325756907.774561.3826061962239012521@neptunite.rasen.tech>","date":"2025-07-23T07:59:29","subject":"Re: [PATCH v2 3/8] libcamera: camera: Add indirection to Camera\n\tsignal emissions","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-07-07 19:18:26)\n> Hi Paul,\n> \n> Thank you for the patch.\n> \n> Quoting Paul Elder (2025-07-03 13:42:18)\n> > Add an extra level of indirection when emitting signals from the Camera.\n> > This is to facilitate the implementation of the layer system in the near\n> > future, which will need to hook into Camera signal emissions.\n> > \n> > Signed-off-by: Paul Elder \n> > \n> > ---\n> > No change in v2\n> > ---\n> > include/libcamera/internal/camera.h | 4 ++++\n> > src/libcamera/camera.cpp | 23 +++++++++++++++++++++--\n> > src/libcamera/pipeline_handler.cpp | 2 +-\n> > src/libcamera/request.cpp | 2 +-\n> > 4 files changed, 27 insertions(+), 4 deletions(-)\n> > \n> > diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\n> > index 18f5c32a18e4..967d4e1693ec 100644\n> > --- a/include/libcamera/internal/camera.h\n> > +++ b/include/libcamera/internal/camera.h\n> > @@ -35,6 +35,10 @@ public:\n> > PipelineHandler *pipe() { return pipe_.get(); }\n> > const PipelineHandler *pipe() const { return pipe_.get(); }\n> > \n> > + void emitBufferCompleted(Request *request, FrameBuffer *buffer);\n> > + void emitRequestCompleted(Request *request);\n> > + void emitDisconnected();\n> > +\n> > std::list queuedRequests_;\n> > ControlInfoMap controlInfo_;\n> > ControlList properties_;\n> > diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> > index c180a5fdde93..c3e656cab671 100644\n> > --- a/src/libcamera/camera.cpp\n> > +++ b/src/libcamera/camera.cpp\n> > @@ -737,6 +737,25 @@ void Camera::Private::setState(State state)\n> > {\n> > state_.store(state, std::memory_order_release);\n> > }\n> > +\n> \n> I'm often unsure about the order of the functions in the .cpp/.h. As you\n> placed it before setState in the header and the functions are before\n> setState alphabetically also, I would probably move them before\n> setState().\n\nI remember being told that they only have to be in the same order within the\npublic/private group. So these three functions are in the same order as the\nheader with respect to the other public functions, but they don't have to be\nrelative to the private functions.\n\n> \n> I thought doxygen would nag the missing documentation as these functions\n> are public. Anyways these are pretty self-explanatory.\n\nIt eventually did :)\nI'll add them.\n\n> \n> Reviewed-by: Stefan Klug \n\n\nThanks,\n\nPaul\n\n> \n> > +void Camera::Private::emitBufferCompleted(Request *request, FrameBuffer *buffer)\n> > +{\n> > + Camera *camera = _o();\n> > + camera->bufferCompleted.emit(request, buffer);\n> > +}\n> > +\n> > +void Camera::Private::emitRequestCompleted(Request *request)\n> > +{\n> > + Camera *camera = _o();\n> > + camera->requestCompleted.emit(request);\n> > +}\n> > +\n> > +void Camera::Private::emitDisconnected()\n> > +{\n> > + Camera *camera = _o();\n> > + camera->disconnected.emit();\n> > +}\n> > +\n> > #endif /* __DOXYGEN_PUBLIC__ */\n> > \n> > /**\n> > @@ -947,7 +966,7 @@ void Camera::disconnect()\n> > LOG(Camera, Debug) << \"Disconnecting camera \" << id();\n> > \n> > _d()->disconnect();\n> > - disconnected.emit();\n> > + _d()->emitDisconnected();\n> > }\n> > \n> > int Camera::exportFrameBuffers(Stream *stream,\n> > @@ -1451,7 +1470,7 @@ void Camera::requestComplete(Request *request)\n> > true))\n> > LOG(Camera, Fatal) << \"Trying to complete a request when stopped\";\n> > \n> > - requestCompleted.emit(request);\n> > + _d()->emitRequestCompleted(request);\n> > }\n> > \n> > } /* namespace libcamera */\n> > diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> > index d84dff3c9f19..b5faaae08d4c 100644\n> > --- a/src/libcamera/pipeline_handler.cpp\n> > +++ b/src/libcamera/pipeline_handler.cpp\n> > @@ -527,7 +527,7 @@ void PipelineHandler::doQueueRequests()\n> > bool PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer)\n> > {\n> > Camera *camera = request->_d()->camera();\n> > - camera->bufferCompleted.emit(request, buffer);\n> > + camera->_d()->emitBufferCompleted(request, buffer);\n> > return request->_d()->completeBuffer(buffer);\n> > }\n> > \n> > diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> > index 7f1e11e8f913..b4ae0f41a34c 100644\n> > --- a/src/libcamera/request.cpp\n> > +++ b/src/libcamera/request.cpp\n> > @@ -137,7 +137,7 @@ void Request::Private::doCancelRequest()\n> > \n> > for (FrameBuffer *buffer : pending_) {\n> > buffer->_d()->cancel();\n> > - camera_->bufferCompleted.emit(request, buffer);\n> > + camera_->_d()->emitBufferCompleted(request, buffer);\n> > }\n> > \n> > cancelled_ = true;\n> > -- \n> > 2.47.2\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E858BBDCC1\n\tfor ;\n\tWed, 23 Jul 2025 07:59:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 794396904C;\n\tWed, 23 Jul 2025 09:59:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0DE0B68FB6\n\tfor ;\n\tWed, 23 Jul 2025 09:59:35 +0200 (CEST)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:1d36:d4e9:a0a5:d2df])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 5C1DDC0B;\n\tWed, 23 Jul 2025 09:58:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uEbEwXiI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753257536;\n\tbh=ZJRKqSjpGv82kekCJyMDSpkQYR2Enfho9QHgoiuxxhA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=uEbEwXiI/qflsiLUdXLmAhvucrFq/6qkFYkd0FYwUQRKReP+6I80qEzIWi5IePYTQ\n\tjpq7qDK9kkTqb25ip69LPzPWl9sfhm2EZIUzczoKv2gbjfEy7fvf9IA7JekpzjUKl6\n\t4Lld2xp+51b9ZFSS9Tueyn0koV3TPrBoiVWu4A/I=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<175188350676.40598.9616502733535623414@localhost>","References":"<20250703114225.2074071-1-paul.elder@ideasonboard.com>\n\t<20250703114225.2074071-4-paul.elder@ideasonboard.com>\n\t<175188350676.40598.9616502733535623414@localhost>","Subject":"Re: [PATCH v2 3/8] libcamera: camera: Add indirection to Camera\n\tsignal emissions","From":"Paul Elder ","Cc":"kieran.bingham@ideasonboard.com, barnabas.pocze@ideasonboard.com","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 23 Jul 2025 16:59:29 +0900","Message-ID":"<175325756907.774561.3826061962239012521@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35050,"web_url":"https://patchwork.libcamera.org/comment/35050/","msgid":"<175328840548.50296.3199118352137487786@ping.linuxembedded.co.uk>","date":"2025-07-23T16:33:25","subject":"Re: [PATCH v2 3/8] libcamera: camera: Add indirection to Camera\n\tsignal emissions","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder (2025-07-03 12:42:18)\n> Add an extra level of indirection when emitting signals from the Camera.\n> This is to facilitate the implementation of the layer system in the near\n> future, which will need to hook into Camera signal emissions.\n> \n\nIt almost makes me want to make the signal itself private to force the\nusage through the helpers - but that can't work because applications use\nthe signal directly!\n\nSo I think this is reasonable - and we just have to keep an eye on it to\nmake sure the helpers are always used...\n\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Paul Elder \n> \n> ---\n> No change in v2\n> ---\n> include/libcamera/internal/camera.h | 4 ++++\n> src/libcamera/camera.cpp | 23 +++++++++++++++++++++--\n> src/libcamera/pipeline_handler.cpp | 2 +-\n> src/libcamera/request.cpp | 2 +-\n> 4 files changed, 27 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\n> index 18f5c32a18e4..967d4e1693ec 100644\n> --- a/include/libcamera/internal/camera.h\n> +++ b/include/libcamera/internal/camera.h\n> @@ -35,6 +35,10 @@ public:\n> PipelineHandler *pipe() { return pipe_.get(); }\n> const PipelineHandler *pipe() const { return pipe_.get(); }\n> \n> + void emitBufferCompleted(Request *request, FrameBuffer *buffer);\n> + void emitRequestCompleted(Request *request);\n> + void emitDisconnected();\n> +\n> std::list queuedRequests_;\n> ControlInfoMap controlInfo_;\n> ControlList properties_;\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index c180a5fdde93..c3e656cab671 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -737,6 +737,25 @@ void Camera::Private::setState(State state)\n> {\n> state_.store(state, std::memory_order_release);\n> }\n> +\n> +void Camera::Private::emitBufferCompleted(Request *request, FrameBuffer *buffer)\n> +{\n> + Camera *camera = _o();\n> + camera->bufferCompleted.emit(request, buffer);\n> +}\n> +\n> +void Camera::Private::emitRequestCompleted(Request *request)\n> +{\n> + Camera *camera = _o();\n> + camera->requestCompleted.emit(request);\n> +}\n> +\n> +void Camera::Private::emitDisconnected()\n> +{\n> + Camera *camera = _o();\n> + camera->disconnected.emit();\n> +}\n> +\n> #endif /* __DOXYGEN_PUBLIC__ */\n> \n> /**\n> @@ -947,7 +966,7 @@ void Camera::disconnect()\n> LOG(Camera, Debug) << \"Disconnecting camera \" << id();\n> \n> _d()->disconnect();\n> - disconnected.emit();\n> + _d()->emitDisconnected();\n> }\n> \n> int Camera::exportFrameBuffers(Stream *stream,\n> @@ -1451,7 +1470,7 @@ void Camera::requestComplete(Request *request)\n> true))\n> LOG(Camera, Fatal) << \"Trying to complete a request when stopped\";\n> \n> - requestCompleted.emit(request);\n> + _d()->emitRequestCompleted(request);\n> }\n> \n> } /* namespace libcamera */\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index d84dff3c9f19..b5faaae08d4c 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -527,7 +527,7 @@ void PipelineHandler::doQueueRequests()\n> bool PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer)\n> {\n> Camera *camera = request->_d()->camera();\n> - camera->bufferCompleted.emit(request, buffer);\n> + camera->_d()->emitBufferCompleted(request, buffer);\n> return request->_d()->completeBuffer(buffer);\n> }\n> \n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index 7f1e11e8f913..b4ae0f41a34c 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -137,7 +137,7 @@ void Request::Private::doCancelRequest()\n> \n> for (FrameBuffer *buffer : pending_) {\n> buffer->_d()->cancel();\n> - camera_->bufferCompleted.emit(request, buffer);\n> + camera_->_d()->emitBufferCompleted(request, buffer);\n> }\n> \n> cancelled_ = true;\n> -- \n> 2.47.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 093E2BDCC1\n\tfor ;\n\tWed, 23 Jul 2025 16:33:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C4D9C69065;\n\tWed, 23 Jul 2025 18:33:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC50A6905C\n\tfor ;\n\tWed, 23 Jul 2025 18:33:27 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 55F21C0B;\n\tWed, 23 Jul 2025 18:32:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"j3mTTg0o\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753288369;\n\tbh=2+NByd4l4zK1dhc/WtMi7q+umbIJ7mNQxkksWlkOfpA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=j3mTTg0o096PBR6JJKdo/xusFtecpX6e3JKUgGpslyo7BZyBmV7Oym7eynbr1DOKx\n\t4tLCteicwMo+57cm3ZhIfO922n/sPBwKi+2a8DocNpUizgr4lTKlX1Mdadb+PX5tMj\n\tbGX37hvVUjn2fy9OpIEVb/E4NwwwT0Wd9ACoi7yo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250703114225.2074071-4-paul.elder@ideasonboard.com>","References":"<20250703114225.2074071-1-paul.elder@ideasonboard.com>\n\t<20250703114225.2074071-4-paul.elder@ideasonboard.com>","Subject":"Re: [PATCH v2 3/8] libcamera: camera: Add indirection to Camera\n\tsignal emissions","From":"Kieran Bingham ","Cc":"Paul Elder , barnabas.pocze@ideasonboard.com","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 23 Jul 2025 17:33:25 +0100","Message-ID":"<175328840548.50296.3199118352137487786@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]