{"id":23713,"url":"https://patchwork.libcamera.org/api/patches/23713/?format=json","web_url":"https://patchwork.libcamera.org/patch/23713/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250702121024.38728-9-mzamazal@redhat.com>","date":"2025-07-02T12:10:04","name":"[v8,08/10] libcamera: simple: Don't enforce conversion with an added raw stream","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0a1970ef8d32c38241a22eec1e0890f4b57db5ed","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23713/mbox/","series":[{"id":5264,"url":"https://patchwork.libcamera.org/api/series/5264/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5264","date":"2025-07-02T12:09:56","name":"Enable raw streams with software ISP","version":8,"mbox":"https://patchwork.libcamera.org/series/5264/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23713/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23713/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4AD3CBDCBF\n\tfor ;\n\tWed, 2 Jul 2025 12:11:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F16B768E4A;\n\tWed, 2 Jul 2025 14:11:09 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED73368E42\n\tfor ;\n\tWed, 2 Jul 2025 14:11:07 +0200 (CEST)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-394-XOf6HnAuPE2bdroJujVURw-1;\n\tWed, 02 Jul 2025 08:11:03 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.93])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 7A96219560BE; Wed, 2 Jul 2025 12:11:02 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.33.1])\n\tby mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 7B00218003FC; Wed, 2 Jul 2025 12:10:59 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"gEeUOAtm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1751458267;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=eqVaYIUoPfVLYjTay1s76z9DVkCiT/KCn1hwWgLuMgs=;\n\tb=gEeUOAtm2EtS6vdP//8cLz8P5aEkUloJj9LZ1WQdntDT7wpP3236K3SqypBQss8wElZGcL\n\tSXbF0hO2JIP2EP/eqGbBkmu1DBxUcaES0czzDYm0NNJ/gkyVQebHUYn40z+Lm/K6AqUzQs\n\tV2rAQ5YywnRiUBqkHdcTJVXgEFn81/U=","X-MC-Unique":"XOf6HnAuPE2bdroJujVURw-1","X-Mimecast-MFC-AGG-ID":"XOf6HnAuPE2bdroJujVURw_1751458262","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Laurent Pinchart\n\t, Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Paul Elder\n\t, Umang Jain ","Subject":"[PATCH v8 08/10] libcamera: simple: Don't enforce conversion with an\n\tadded raw stream","Date":"Wed, 2 Jul 2025 14:10:04 +0200","Message-ID":"<20250702121024.38728-9-mzamazal@redhat.com>","In-Reply-To":"<20250702121024.38728-1-mzamazal@redhat.com>","References":"<20250702121024.38728-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"7_AvEus4iyRpc48uYrPKHuEWM5dpAvlWzgaS-suuAJA_1751458262","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When a raw stream is requested, either alone or together with a\nprocessed stream, it can be produced without conversion. Let's amend\nthe corresponding check on the number of configurations, so that the\nmere presence of a raw stream doesn't enforce conversion.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex b1766c907..a85e8e4b4 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1225,7 +1225,7 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \t * require any conversion, similar to raw capture use cases). This is\n \t * left as a future improvement.\n \t */\n-\tneedConversion_ = config_.size() > 1;\n+\tneedConversion_ = config_.size() > 1 + (rawRequested_ ? 1 : 0);\n \n \tfor (unsigned int i = 0; i < config_.size(); ++i) {\n \t\tStreamConfiguration &cfg = config_[i];\n","prefixes":["v8","08/10"]}