{"id":23710,"url":"https://patchwork.libcamera.org/api/patches/23710/?format=json","web_url":"https://patchwork.libcamera.org/patch/23710/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250702121024.38728-6-mzamazal@redhat.com>","date":"2025-07-02T12:10:01","name":"[v8,05/10] libcamera: simple: Identify requested stream roles","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c42e44fda4790f72ae75496f86686e954952601a","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23710/mbox/","series":[{"id":5264,"url":"https://patchwork.libcamera.org/api/series/5264/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5264","date":"2025-07-02T12:09:56","name":"Enable raw streams with software ISP","version":8,"mbox":"https://patchwork.libcamera.org/series/5264/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23710/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23710/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9F84EBDCBF\n\tfor ;\n\tWed, 2 Jul 2025 12:11:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5098C68E44;\n\tWed, 2 Jul 2025 14:11:01 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 488E368E3D\n\tfor ;\n\tWed, 2 Jul 2025 14:10:59 +0200 (CEST)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-623-s6-aWNwDNhCB08fEPTfOjQ-1;\n\tWed, 02 Jul 2025 08:10:53 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.93])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 911BC180120E; Wed, 2 Jul 2025 12:10:52 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.33.1])\n\tby mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 2A17D1800288; Wed, 2 Jul 2025 12:10:49 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"DagpUOb7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1751458257;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=wkLCpDjPaE3TkzwBZo7++wGiGgE9FFwIXF5WEAnVchI=;\n\tb=DagpUOb7il+UgcRAfmKzEWK4E/dO2DHmDpHCTNZbFiZ24nkFL+M6A/N8X09qIQrGvHkOsi\n\trvSP9J8x+6gzQb4bKnA0Lo8hr+i/bpTKvtFxt6cAF4SscQ8CdU3eWbJKe2E3vhEz2qChCw\n\tcEUgOQLteeV13ZkG3sh8SB+5XN3sziA=","X-MC-Unique":"s6-aWNwDNhCB08fEPTfOjQ-1","X-Mimecast-MFC-AGG-ID":"s6-aWNwDNhCB08fEPTfOjQ_1751458252","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Laurent Pinchart\n\t, Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Paul Elder\n\t, Umang Jain ","Subject":"[PATCH v8 05/10] libcamera: simple: Identify requested stream roles","Date":"Wed, 2 Jul 2025 14:10:01 +0200","Message-ID":"<20250702121024.38728-6-mzamazal@redhat.com>","In-Reply-To":"<20250702121024.38728-1-mzamazal@redhat.com>","References":"<20250702121024.38728-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"rx27zYytPvL-47ZhFxzpIrizmy-hTHgtaeDS4SXWWG0_1751458252","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Currently, raw streams don't work in the simple pipeline and the\nrequested stream roles are ignored. In order to support raw streams, we\nnow track in SimpleCameraConfiguration whether raw and/or processed\nstreams are requested. We also check that at most one raw stream is\nrequested, there is no reason to have more.\n\nThat information will be used in the followup patches.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/pipeline/simple/simple.cpp | 20 +++++++++++++++++++-\n 1 file changed, 19 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 1a7474228..6330afeb5 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -384,6 +384,9 @@ public:\n \tbool needConversion() const { return needConversion_; }\n \tconst Transform &combinedTransform() const { return combinedTransform_; }\n \n+\tbool processedRequested_;\n+\tbool rawRequested_;\n+\n private:\n \t/*\n \t * The SimpleCameraData instance is guaranteed to be valid as long as\n@@ -1311,12 +1314,27 @@ std::unique_ptr\n SimplePipelineHandler::generateConfiguration(Camera *camera, Span roles)\n {\n \tSimpleCameraData *data = cameraData(camera);\n-\tstd::unique_ptr config =\n+\tstd::unique_ptr config =\n \t\tstd::make_unique(camera, data);\n \n+\tconfig->processedRequested_ = false;\n+\tconfig->rawRequested_ = false;\n+\n \tif (roles.empty())\n \t\treturn config;\n \n+\tfor (const auto &role : roles)\n+\t\tif (role == StreamRole::Raw) {\n+\t\t\tif (config->rawRequested_) {\n+\t\t\t\tLOG(SimplePipeline, Error)\n+\t\t\t\t\t<< \"Can't capture multiple raw streams\";\n+\t\t\t\treturn nullptr;\n+\t\t\t}\n+\t\t\tconfig->rawRequested_ = true;\n+\t\t} else {\n+\t\t\tconfig->processedRequested_ = true;\n+\t\t}\n+\n \t/* Create the formats map. */\n \tstd::map> formats;\n \n","prefixes":["v8","05/10"]}