{"id":23704,"url":"https://patchwork.libcamera.org/api/patches/23704/?format=json","web_url":"https://patchwork.libcamera.org/patch/23704/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250701112922.62285-3-uajain@igalia.com>","date":"2025-07-01T11:29:22","name":"[v2,2/2] lc-compliance: Ensure stream's colorspace is set after validate()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0ead61a190547958b42c8902d7d3a955c6836ee7","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/?format=json","name":"Umang Jain","email":"uajain@igalia.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23704/mbox/","series":[{"id":5263,"url":"https://patchwork.libcamera.org/api/series/5263/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5263","date":"2025-07-01T11:29:20","name":"lc-compliance: Ensure stream's colorspace is set after validate()","version":2,"mbox":"https://patchwork.libcamera.org/series/5263/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23704/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23704/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5CBA1C3237\n\tfor ;\n\tTue, 1 Jul 2025 11:29:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 186BE68E2A;\n\tTue, 1 Jul 2025 13:29:28 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5C5668E2A\n\tfor ;\n\tTue, 1 Jul 2025 13:29:25 +0200 (CEST)","from [49.36.69.141] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1uWZAy-00AwG9-55; Tue, 01 Jul 2025 13:29:24 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"dUnMkMmb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=LV561dU6pvdK+oCH138B7P/slDJecaPDdPgskP2DSLI=;\n\tb=dUnMkMmbhEWJsWnroDIBH/H9Ls\n\t5ahwCtyhc1YEFVKSQzAakZgpw48QHQ0ymODQ6KjWV8pCUB/+fFQ32ts8H5oBjEJP4ZQdTPEB2kg4R\n\tNPIm+vNcfYaPy0zoRPSLrwYOPnGT2l5ZFHCKuWkK5cfyeqxg7SnYMsR3ywlgPVVtX5vG6lHqUyFfV\n\t4BD1wbq6ZKbqiakXRvbO7dhYtJbd4P4BY5K9fYlzlXBdPs5+J18m0RrXs9WXN+g+cx7NLGKVquQ8m\n\t4fS5g5vCOrpeHMXoB0Srd9boQ2XXG6OeWiWlM4I7e1+cXOjKutnOB9G/GiDDrI1NHQ7YLHTp6Ge1V\n\tblr6bx+A==;","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Umang Jain ,\n\tKieran Bingham ","Subject":"[PATCH v2 2/2] lc-compliance: Ensure stream's colorspace is set\n\tafter validate()","Date":"Tue, 1 Jul 2025 16:59:22 +0530","Message-ID":"<20250701112922.62285-3-uajain@igalia.com>","X-Mailer":"git-send-email 2.50.0","In-Reply-To":"<20250701112922.62285-1-uajain@igalia.com>","References":"<20250701112922.62285-1-uajain@igalia.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"StreamConfiguration::colorspace is a std::optional<> and if unset by\nthe user, it should be populated by the pipeline handler after the\nCameraConfiguration::validate().\n\nAdd a EXPECT_TRUE() check to ensure that each stream in the\nCameraConfiguration has a colorspace set.\n\nSigned-off-by: Umang Jain \nReviewed-by: Kieran Bingham \n---\n src/apps/lc-compliance/helpers/capture.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/apps/lc-compliance/helpers/capture.cpp b/src/apps/lc-compliance/helpers/capture.cpp\nindex 2a3fa3b6..e767e45e 100644\n--- a/src/apps/lc-compliance/helpers/capture.cpp\n+++ b/src/apps/lc-compliance/helpers/capture.cpp\n@@ -52,6 +52,9 @@ void Capture::configure(libcamera::Span roles)\n \t\tFAIL() << \"Configuration not valid\";\n \t}\n \n+\tfor (auto &cfg : *config_)\n+\t\tEXPECT_TRUE(cfg.colorSpace) << cfg << \" - colorspace not set.\";\n+\n \tif (camera_->configure(config_.get())) {\n \t\tconfig_.reset();\n \t\tFAIL() << \"Failed to configure camera\";\n","prefixes":["v2","2/2"]}