{"id":23703,"url":"https://patchwork.libcamera.org/api/patches/23703/?format=json","web_url":"https://patchwork.libcamera.org/patch/23703/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250701112922.62285-2-uajain@igalia.com>","date":"2025-07-01T11:29:21","name":"[v2,1/2] pipeline: virtual: Provide and validate colorspace","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"fbb7b400efb37653af5c2c92ada891045c372114","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/?format=json","name":"Umang Jain","email":"uajain@igalia.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23703/mbox/","series":[{"id":5263,"url":"https://patchwork.libcamera.org/api/series/5263/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5263","date":"2025-07-01T11:29:20","name":"lc-compliance: Ensure stream's colorspace is set after validate()","version":2,"mbox":"https://patchwork.libcamera.org/series/5263/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23703/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23703/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC7B5C3237\n\tfor ;\n\tTue, 1 Jul 2025 11:29:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6B28E68E28;\n\tTue, 1 Jul 2025 13:29:25 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EEAA468E1A\n\tfor ;\n\tTue, 1 Jul 2025 13:29:22 +0200 (CEST)","from [49.36.69.141] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1uWZAv-00AwG9-HG; Tue, 01 Jul 2025 13:29:22 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"QYjtFo00\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=gbi1bHpDTvUWKxvWCxqhwX2/uT8BRTc0Rzvzm2zArd8=;\n\tb=QYjtFo00847nBx6PCvFMODMZ0H\n\tFWwjlrciSEJ+wLN/zKABtj1Oaj+zeNmQ6s0s9Xtil5bSNRpifCQOR5EgOfY5Td4adNMSACd25Lm+J\n\tRonqktLGWRPA0gpJM9zKEqbTOmTHuXjcax8bEl6s6NuhB0QOgdaFH7p9KfuvXCyDO9flm1+lullSI\n\tE/WNSvF6ZtGDXDyPq7rQk/hYHykaFdWZci8UN6oxrZiZ7EhmvUk8F/LDZpHrHHA/g+Fte4G5JAzet\n\th4ZwWc+K2dmCjCpq5tJe0mmV6yGn6M48bhNCek638vyFWQa06+NgbCfmVALiTf0Qz1rU7jhq5+Ws/\n\tn67NDy5Q==;","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Umang Jain ","Subject":"[PATCH v2 1/2] pipeline: virtual: Provide and validate colorspace","Date":"Tue, 1 Jul 2025 16:59:21 +0530","Message-ID":"<20250701112922.62285-2-uajain@igalia.com>","X-Mailer":"git-send-email 2.50.0","In-Reply-To":"<20250701112922.62285-1-uajain@igalia.com>","References":"<20250701112922.62285-1-uajain@igalia.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Virtual pipeline handler should provide colorSpace in\ngenerateConfiguration() and validate the colorspace in validate().\nIt is mandatory for a pipeline handler to set the colorspace if it\nis unset in the stream configuration, during validate().\n\nSigned-off-by: Umang Jain \n---\n src/libcamera/pipeline/virtual/virtual.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp\nindex 049ebcba..841846b4 100644\n--- a/src/libcamera/pipeline/virtual/virtual.cpp\n+++ b/src/libcamera/pipeline/virtual/virtual.cpp\n@@ -180,6 +180,17 @@ CameraConfiguration::Status VirtualCameraConfiguration::validate()\n \t\t\tadjusted = true;\n \t\t}\n \n+\t\tif (!cfg.colorSpace) {\n+\t\t\tcfg.colorSpace = ColorSpace::Sycc;\n+\t\t\tstatus = Adjusted;\n+\t\t\tadjusted = true;\n+\t\t}\n+\n+\t\tif (validateColorSpaces() == Adjusted) {\n+\t\t\tstatus = Adjusted;\n+\t\t\tadjusted = true;\n+\t\t}\n+\n \t\tif (adjusted)\n \t\t\tLOG(Virtual, Info)\n \t\t\t\t<< \"Stream configuration adjusted to \" << cfg.toString();\n@@ -244,6 +255,7 @@ PipelineHandlerVirtual::generateConfiguration(Camera *camera,\n \t\tcfg.pixelFormat = pixelFormat;\n \t\tcfg.size = data->config_.maxResolutionSize;\n \t\tcfg.bufferCount = VirtualCameraConfiguration::kBufferCount;\n+\t\tcfg.colorSpace = ColorSpace::Sycc;\n \n \t\tconfig->addConfiguration(cfg);\n \t}\n","prefixes":["v2","1/2"]}