[{"id":347,"web_url":"https://patchwork.libcamera.org/comment/347/","msgid":"<20190115222504.GI7393@bigcity.dyn.berto.se>","date":"2019-01-15T22:25:04","subject":"Re: [libcamera-devel] [PATCH v2 5/8] libcamera:\n\tevent_dispatcher_poll: Constify argument to processNotifiers","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-01-15 17:18:46 +0200, Laurent Pinchart wrote:\n> The EventDispatcherPoll::processNotifiers() function doesn't modify the\n> argument it receives, make it const.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/event_dispatcher_poll.cpp | 2 +-\n> src/libcamera/include/event_dispatcher_poll.h | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/event_dispatcher_poll.cpp b/src/libcamera/event_dispatcher_poll.cpp\n> index a497a7fe9177..69edfcbf2725 100644\n> --- a/src/libcamera/event_dispatcher_poll.cpp\n> +++ b/src/libcamera/event_dispatcher_poll.cpp\n> @@ -173,7 +173,7 @@ short EventDispatcherPoll::EventNotifierSetPoll::events() const\n> \treturn events;\n> }\n> \n> -void EventDispatcherPoll::processNotifiers(std::vector &pollfds)\n> +void EventDispatcherPoll::processNotifiers(const std::vector &pollfds)\n> {\n> \tstatic const struct {\n> \t\tEventNotifier::Type type;\n> diff --git a/src/libcamera/include/event_dispatcher_poll.h b/src/libcamera/include/event_dispatcher_poll.h\n> index 30fd58506d6b..a41926e11a11 100644\n> --- a/src/libcamera/include/event_dispatcher_poll.h\n> +++ b/src/libcamera/include/event_dispatcher_poll.h\n> @@ -41,7 +41,7 @@ private:\n> \tstd::map notifiers_;\n> \tstd::list timers_;\n> \n> -\tvoid processNotifiers(std::vector &pollfds);\n> +\tvoid processNotifiers(const std::vector &pollfds);\n> \tvoid processTimers();\n> };\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F06560C6A\n\tfor ;\n\tTue, 15 Jan 2019 23:25:06 +0100 (CET)","by mail-lf1-x143.google.com with SMTP id b20so3306773lfa.12\n\tfor ;\n\tTue, 15 Jan 2019 14:25:06 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tb20sm847264lfj.61.2019.01.15.14.25.04\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 15 Jan 2019 14:25:04 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=li1jBuTX8BIIxXw6aFO2KRq8p5eQynbAHMS2VQPkY5U=;\n\tb=iSxamrxDJOALEy2HXEGw9B7crua4zgTZ5e+yco1sEspEjKf7mmrspHzf6+0AaOi1GQ\n\t6El5p8FwfILjgMs6qJV7uauPTTAonq83jtEhBYCmtsYqnDb82tMyzyVma6frErA6m7e5\n\tZR7Lh3kwCMYU5WjRz/johkaGddUCi22GciWsQrdmNX1V63fkIZ5JDoaTnFgkLl7gxj6v\n\tYhr1zlRrHCoHVBf7ob9SmESWOXt3kR2HvWYVOfHaxBLeWo67BpSU7naZBixlH2nxklPd\n\t6EohD/IxzbYvLHwdPrkB9zQWWrZl6E8idRdW7/II4ZVUn2+7ty9Nwkn/WrXgaBZzqfPB\n\tTyyQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=li1jBuTX8BIIxXw6aFO2KRq8p5eQynbAHMS2VQPkY5U=;\n\tb=F6v/s/77+EwLtD+zruFJc9tnVS/SgKbRcvOEFP70TqGa/JKO99Xz+NzYFfYufVQrIO\n\tZz+/9wYQveDhVwNHUFRjKmgjMTr1E0wf1l0s+XOeIlujODbTeSe6I5Y0dtJkgSod6+qU\n\tJM76/kEktLs8MtqtBRvrUlBszzTvvuG3lDegnClb/byZZOHyIwIdxcRooryNeC6hxKDL\n\t+tpB5WK/GCyxOQP1Whp5omlYpKdzkeM7NlBXiJTdl+6CRB9jr9X/qozaA2o+ZpYYEgtI\n\tm39BhW4JZqUxBDBoCQfzmYK3LPhZ97qNKbqYdZ6iQ9ItqTfnolh1V3fROFnZ/G3dXEcx\n\tWlhA==","X-Gm-Message-State":"AJcUukdK740Jl6W3cTdjZzPFTJLweIJM1RZNOSeMF5HMWFOTRSexgitA\n\t331DX2iBPB0FBrNH/DpwZfKoQw==","X-Google-Smtp-Source":"ALg8bN7LdzWSby6NJM70g05WNYBZPzSEX2UmhigXOI+fYMEDJIPvoRpixYu1zYQrm4c+TLRBwUnwAg==","X-Received":"by 2002:a19:c345:: with SMTP id t66mr4245743lff.55.1547591105521;\n\tTue, 15 Jan 2019 14:25:05 -0800 (PST)","Date":"Tue, 15 Jan 2019 23:25:04 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190115222504.GI7393@bigcity.dyn.berto.se>","References":"<20190115151849.1547-1-laurent.pinchart@ideasonboard.com>\n\t<20190115151849.1547-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190115151849.1547-6-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 5/8] libcamera:\n\tevent_dispatcher_poll: Constify argument to processNotifiers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 15 Jan 2019 22:25:06 -0000"}}]