[{"id":34650,"web_url":"https://patchwork.libcamera.org/comment/34650/","msgid":"<20250626102618.GH8738@pendragon.ideasonboard.com>","date":"2025-06-26T10:26:18","subject":"Re: [PATCH v2] camera_sensor: Expand on computeTransform()\n\tdocumentation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jun 26, 2025 at 10:54:41AM +0530, Umang Jain wrote:\n> The description for computeTransform() when the desired orientation\n> cannot be achieved, can be expanded a further bit, to clearly report\n> that orientation will be adjusted to native camera sensor mounting\n> rotation.\n> \n> Signed-off-by: Umang Jain \n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Changes in v2:\n> - Use rotation instead of orientation for describing sensor mounting\n> ---\n> src/libcamera/sensor/camera_sensor.cpp | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/sensor/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp\n> index d19b5e2e..4f2fd269 100644\n> --- a/src/libcamera/sensor/camera_sensor.cpp\n> +++ b/src/libcamera/sensor/camera_sensor.cpp\n> @@ -302,8 +302,9 @@ int CameraSensor::setEmbeddedDataEnabled(bool enable)\n> * camera sensor, likely at configure() time.\n> *\n> * If the requested \\a orientation cannot be obtained, the \\a orientation\n> - * parameter is adjusted to report the current image orientation and\n> - * Transform::Identity is returned.\n> + * parameter is adjusted to report the native image orientation (i.e. resulting\n> + * from the physical mounting rotation of the camera sensor, without any\n> + * transformation) and Transform::Identity is returned.\n> *\n> * If the requested \\a orientation can be obtained, the function computes a\n> * Transform and does not adjust \\a orientation.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B600DBDCBF\n\tfor ;\n\tThu, 26 Jun 2025 10:26:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 68E8468DF7;\n\tThu, 26 Jun 2025 12:26:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 43AE368DE8\n\tfor ;\n\tThu, 26 Jun 2025 12:26:42 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-34-12-nat.elisa-mobile.fi\n\t[85.76.34.12])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 33747743;\n\tThu, 26 Jun 2025 12:26:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wVLxQGsn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1750933583;\n\tbh=o8WKyno2At19Yq5Q+ODDkeROen6vbsVOx+TUYzbmj+8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wVLxQGsnHXY7nVVN8wQOsaMM/SuNnZqhyYJG81yV/y7hOtPxBoblNUu3Gn6Daveg+\n\tTk0/Jf/6dwGTVu9I6zuMW869dvan51gLkl4HN+a/OWUr1pO44HXMzRtFxWDBn8PWe/\n\t5SDBV5DcKrfQ6+d8M/Uh3hN73SrRf/SnMUzEoxfs=","Date":"Thu, 26 Jun 2025 13:26:18 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org,\n\tJacopo Mondi ","Subject":"Re: [PATCH v2] camera_sensor: Expand on computeTransform()\n\tdocumentation","Message-ID":"<20250626102618.GH8738@pendragon.ideasonboard.com>","References":"<20250626052441.20305-1-uajain@igalia.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250626052441.20305-1-uajain@igalia.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]