{"id":23656,"url":"https://patchwork.libcamera.org/api/patches/23656/?format=json","web_url":"https://patchwork.libcamera.org/patch/23656/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250626052441.20305-1-uajain@igalia.com>","date":"2025-06-26T05:24:41","name":"[v2] camera_sensor: Expand on computeTransform() documentation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"bef609df180f39c0617981b4669e3e460ab193bc","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/?format=json","name":"Umang Jain","email":"uajain@igalia.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23656/mbox/","series":[{"id":5249,"url":"https://patchwork.libcamera.org/api/series/5249/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5249","date":"2025-06-26T05:24:41","name":"[v2] camera_sensor: Expand on computeTransform() documentation","version":2,"mbox":"https://patchwork.libcamera.org/series/5249/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23656/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23656/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 91C60BDCBF\n\tfor ;\n\tThu, 26 Jun 2025 05:24:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C469468DE2;\n\tThu, 26 Jun 2025 07:24:52 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5997661529\n\tfor ;\n\tThu, 26 Jun 2025 07:24:49 +0200 (CEST)","from [49.36.69.141] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1uUf6N-008qlr-Qi; Thu, 26 Jun 2025 07:24:48 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"ZAS2vZtp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:\n\tCc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tIn-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=g1+SopzQO8Z/5Xr4T8Y0GV4v7dlMMHBSZXnKE8X8RTQ=;\n\tb=ZAS2vZtpYmnESFe4DskBwYIBP+\n\tMFAxtQFSF7m8Hr7vkUNZ+us6/QtFaVwSGfCWe1jq3hZ1Ue2EJ0buXjqAd2+h5UpLVsaFW7rdpzA/m\n\teSJXXkT8AjNkrebWqs/tnE3tEXA1REVhiYb52o9vA0WIPrAEOQtNy1GCe2X4F5FiT9lYF3aZyH4IM\n\t0DTOlbxfLc7Q4O+mlMe4IfvabI5NtNfSE+b5tV2ogyJuio0+3fqq4yvT5vinLNhh16mi+UQgqsRoK\n\t1scRFRffLq2reS9RH6BHlxIW+CCvYr4XfB2ZLGHMF2GQV8l+Zqbhu77/XXdKO1VhY9ndVtgskL5Nh\n\tnJkr5OxA==;","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Umang Jain ,\n\tJacopo Mondi ","Subject":"[PATCH v2] camera_sensor: Expand on computeTransform() documentation","Date":"Thu, 26 Jun 2025 10:54:41 +0530","Message-ID":"<20250626052441.20305-1-uajain@igalia.com>","X-Mailer":"git-send-email 2.50.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The description for computeTransform() when the desired orientation\ncannot be achieved, can be expanded a further bit, to clearly report\nthat orientation will be adjusted to native camera sensor mounting\nrotation.\n\nSigned-off-by: Umang Jain \nReviewed-by: Jacopo Mondi \n---\nChanges in v2:\n- Use rotation instead of orientation for describing sensor mounting\n---\n src/libcamera/sensor/camera_sensor.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/sensor/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp\nindex d19b5e2e..4f2fd269 100644\n--- a/src/libcamera/sensor/camera_sensor.cpp\n+++ b/src/libcamera/sensor/camera_sensor.cpp\n@@ -302,8 +302,9 @@ int CameraSensor::setEmbeddedDataEnabled(bool enable)\n * camera sensor, likely at configure() time.\n *\n * If the requested \\a orientation cannot be obtained, the \\a orientation\n- * parameter is adjusted to report the current image orientation and\n- * Transform::Identity is returned.\n+ * parameter is adjusted to report the native image orientation (i.e. resulting\n+ * from the physical mounting rotation of the camera sensor, without any\n+ * transformation) and Transform::Identity is returned.\n *\n * If the requested \\a orientation can be obtained, the function computes a\n * Transform and does not adjust \\a orientation.\n","prefixes":["v2"]}