{"id":23646,"url":"https://patchwork.libcamera.org/api/patches/23646/?format=json","web_url":"https://patchwork.libcamera.org/patch/23646/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250624171223.2181226-3-kieran.bingham@ideasonboard.com>","date":"2025-06-24T17:12:22","name":"[2/3] libcamera: controls: Define a new core Hue control","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5c7fba822c907398c66fb76efbcbba864a5208f1","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23646/mbox/","series":[{"id":5245,"url":"https://patchwork.libcamera.org/api/series/5245/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5245","date":"2025-06-24T17:12:20","name":"rkisp1: cproc - Metadata and Hue developments","version":1,"mbox":"https://patchwork.libcamera.org/series/5245/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23646/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23646/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B535AC3237\n\tfor ;\n\tTue, 24 Jun 2025 17:12:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8CCE268DF7;\n\tTue, 24 Jun 2025 19:12:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E83C61536\n\tfor ;\n\tTue, 24 Jun 2025 19:12:27 +0200 (CEST)","from Monstersaurus.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EA7B26A6;\n\tTue, 24 Jun 2025 19:12:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qz5e6Rcq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1750785130;\n\tbh=ruvTkwLj/SkKTC/SNrMWgEW7H/eoXPodGYY3DLlb97k=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=qz5e6RcqqrLclJ7NshBOlhxx1BIIJXG1UEXsRmAGabwShjtYozln7ib0RcPCe1sV9\n\tRRtmuLzwVz9K2LR61A4iEK4E0mFQa8g/QFP/+alnTvPjbO/OFjEXn6Rp7E4r//iu1U\n\t3aont+qMO4RZ5tjOWRAfjw+rSNxo2N1yy8aCl0iE=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"\"van Veen, Stephan\" ,\n\tKieran Bingham ","Subject":"[PATCH 2/3] libcamera: controls: Define a new core Hue control","Date":"Tue, 24 Jun 2025 18:12:22 +0100","Message-ID":"<20250624171223.2181226-3-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250624171223.2181226-1-kieran.bingham@ideasonboard.com>","References":"<20250624171223.2181226-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: \"van Veen, Stephan\" \n\nDefine a new control to support configuration of Hue adjustments when\nsupported by the available platform.\n\nSigned-off-by: van Veen, Stephan \n[Kieran: Split control addition and implementation and refactor commit\nmessages]\nSigned-off-by: Kieran Bingham \n\n---\n\nOpen questions\n\nHow should we standardise the units on this control? Should this be a\nscale of -1, 0, +1 and scaled to the capability of the hardware by the\nIPA? Or should we standardise on similar units from a colour wheel and\nuse values in degrees (for RKISP1 use case this would be -90,0,+87.188).\n\nAs the RKISP1 makes a phase shift adjustment, is this expected to be\nsimilar on other pipelines? Or should we also expect anything that would\nexpose a full 360 degree explicit hue? (I assume not now I write that\n:D)\n\nSigned-off-by: Kieran Bingham \n---\n src/libcamera/control_ids_core.yaml | 10 ++++++++++\n 1 file changed, 10 insertions(+)","diff":"diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\nindex 028919ef3d3e..58abf8434eae 100644\n--- a/src/libcamera/control_ids_core.yaml\n+++ b/src/libcamera/control_ids_core.yaml\n@@ -1281,4 +1281,14 @@ controls:\n \n The FrameWallClock control can only be returned in metadata.\n \n+ - Hue:\n+ type: float\n+ direction: inout\n+ description: |\n+ Specify a fixed hue parameter.\n+\n+ Positive values (up to 1.0) produce an increase of the hue angle up to\n+ 90 degrees; negative values (up to -1.0) produce a decrease of the hue\n+ angle down to -90 degrees.\n+\n ...\n","prefixes":["2/3"]}