[{"id":35092,"web_url":"https://patchwork.libcamera.org/comment/35092/","msgid":"","date":"2025-07-24T09:23:37","subject":"Re: [PATCH 1/3] libcamera: camera_sensor_properties: Add vd56g3\n\tcamera sensor","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"On Fri, 20 Jun 2025 at 14:50, Benjamin Mugnier\n wrote:\n>\n> Add unit cell size from the 'pixel size' element in the datasheet.\n> Delays are set to 2 in case a setting is entered at the very and of the\n> N frame, the N+1 frame will miss it and only the N+2 frame will use this\n> new setting.\n>\n> Note that vd56g3 has a diagonal color test pattern, but does not match\n> any description in specified test patterns and therefore is ignored.\n>\n> Signed-off-by: Benjamin Mugnier \n\nI don't have the datasheet for this sensor, but the numbers look reasonable!\n\nReviewed-by: Naushir Patuck \n\n> ---\n> src/libcamera/sensor/camera_sensor_properties.cpp | 21 +++++++++++++++++++++\n> 1 file changed, 21 insertions(+)\n>\n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index c9e9e148a1f08d64b63343ca2e204deaf9ef68c8..0816e2093c6d1b4531779455ea3147dcf32e741d 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -456,6 +456,27 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> },\n> .sensorDelays = { },\n> } },\n> + { \"vd56g3\", {\n> + .unitCellSize = { 2160, 2160 },\n> + .testPatternModes = {\n> + { controls::draft::TestPatternModeOff, 0 },\n> + { controls::draft::TestPatternModeSolidColor, 1 },\n> + { controls::draft::TestPatternModePn9, 6 },\n> + /*\n> + * No corresponding test pattern mode for:\n> + * 2: \"Vertical Color Bars\"\n> + * 3: \"Horizontal Gray Scale\"\n> + * 4: \"Vertical Gray Scale\"\n> + * 5: \"Diagonal Gray Scale\"\n> + */\n> + },\n> + .sensorDelays = {\n> + .exposureDelay = 2,\n> + .gainDelay = 2,\n> + .vblankDelay = 2,\n> + .hblankDelay = 2\n> + },\n> + } },\n> };\n>\n> const auto it = sensorProps.find(sensor);\n>\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 172E7C3237\n\tfor ;\n\tThu, 24 Jul 2025 09:24:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B719F690D3;\n\tThu, 24 Jul 2025 11:24:18 +0200 (CEST)","from mail-vk1-xa31.google.com (mail-vk1-xa31.google.com\n\t[IPv6:2607:f8b0:4864:20::a31])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 93814690C8\n\tfor ;\n\tThu, 24 Jul 2025 11:24:16 +0200 (CEST)","by mail-vk1-xa31.google.com with SMTP id\n\t71dfb90a1353d-531618a6023so41362e0c.3\n\tfor ;\n\tThu, 24 Jul 2025 02:24:16 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"KzW3DXvN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1753349055; x=1753953855;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=QYpj/U2amQyq7dzNlPNfECPt4MiAoEQ3WEP2xiLPOkk=;\n\tb=KzW3DXvNVAEPEsEu+ok6lq44TXe0ynO+1BCOCbkxwS5GbFdqB15EMyucc42svNLIWI\n\tJqovkksrqK3VISE8wZOHNC9UjFTh8spgrAmeGdzSjE29GyJ4W5l+Lj2yRWJjedP9khK6\n\t/+G1pzVHWnWRTFkSLkoYsBZ0//tcXKVrPHlx0NsJC3gMv9xGoFayd6WagKjxHCWq3Rje\n\tl+xAASmPo0ZMNRwE+GGpHPN5t7yQxYqrYNccR7FJEhlTBHIE2kkMbJqDqOkPf+N7LnHo\n\t1kGKkKncQ2rIlHZIvcBTMTD8B2HgMkRw1rpg7Z1nCwrQr38MaEQUkscew5JfUjpqujsZ\n\tia4w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1753349055; x=1753953855;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=QYpj/U2amQyq7dzNlPNfECPt4MiAoEQ3WEP2xiLPOkk=;\n\tb=Ic7/kuuWAL7JF7WdtWivnv1a+FT5jLvdnBIaQ+Sw9cR+ukSGNcghkm/63hntCj8QfA\n\teZ/SLcFTBFW2oylSXR6zEv9bHAqx/868LCO0rC+iI3E51MPZQ2a3IbENgT7R3sW+67k6\n\tG5dL4VGpnpLcO5pbhM5P56KOjhqDBM+/HKEnWEkBkParXbQNSSskfCsRojOwy6b3m+OF\n\tlKWjxOM6wHV30HtN+e2ZtSugCgenMRWufnmM+J5+Zqn7b7yS4VxuFP6pkVPJGjRQFmq3\n\tWq8/jPAEDz/IgyileM9cT5cdusBESTbWGOsYHWv06U5+T1RG24cmlwn6h0/uekRUxBAG\n\tXhHw==","X-Gm-Message-State":"AOJu0YygChwIMNSM8jWi4sqibCbCeA56HLPWcCaU7CgeiLXhtQSPMKb1\n\tQfscDpm2FBuquJlhf2d/dpc8Irf5NgTFYNQZoVbhBTvY2mi8+kM4uTIAI+udfS6akDmUMZntnL2\n\t2skB2oOTuynyUluwtR2ZZS6uFG38mxi7p08pZjT0hRg==","X-Gm-Gg":"ASbGncsxbBLK7BapGZbWp1i4DoQlJ8dGzGjPyRB3IBNBEExrnyNUJTE4OdZ9oE9rmrJ\n\tuW5H4JwLfs/mPqDYzNu3bjmi85ryw2W/xA7fsHEeRa6VDGqTD2P8/2AUHdwTfpxmDcMckwgw4A8\n\tFDuachh5xMSF0UloAcGkUyup0F6q64rYOVBCCOw6Pq6oelKnPkRTCtvXGPWA0xZDhJKGpsu4P0M\n\tdCmCug=","X-Google-Smtp-Source":"AGHT+IHHnbDXj7y4L1IghBALAvdK7VouOFnDOUwLlA81OmbOzByM3kI4aEiSWO/aWMKDK/Dc916YOzxSEgpcQNZxfGQ=","X-Received":"by 2002:a05:6122:4404:b0:537:2f35:c839 with SMTP id\n\t71dfb90a1353d-537af55d5e1mr757780e0c.2.1753349053953; Thu, 24 Jul 2025\n\t02:24:13 -0700 (PDT)","MIME-Version":"1.0","References":"<20250620-vd56g3_support-v1-0-df434bdbc9bd@foss.st.com>\n\t<20250620-vd56g3_support-v1-1-df434bdbc9bd@foss.st.com>","In-Reply-To":"<20250620-vd56g3_support-v1-1-df434bdbc9bd@foss.st.com>","From":"Naushir Patuck ","Date":"Thu, 24 Jul 2025 10:23:37 +0100","X-Gm-Features":"Ac12FXzK1LQz3LBdokqpIb7-x103C8iFj-6nc5emgVLibmDDwn1Q3B915UmSAoY","Message-ID":"","Subject":"Re: [PATCH 1/3] libcamera: camera_sensor_properties: Add vd56g3\n\tcamera sensor","To":"Benjamin Mugnier ","Cc":"libcamera-devel@lists.libcamera.org, \n\tKieran Bingham , \n\tSylvain Petinot ,\n\tCyril Liotard , Jean Poire ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35095,"web_url":"https://patchwork.libcamera.org/comment/35095/","msgid":"<20250724101258.GF11202@pendragon.ideasonboard.com>","date":"2025-07-24T10:12:58","subject":"Re: [PATCH 1/3] libcamera: camera_sensor_properties: Add vd56g3\n\tcamera sensor","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Benjamin,\n\nOn Fri, Jun 20, 2025 at 03:49:16PM +0200, Benjamin Mugnier wrote:\n> Add unit cell size from the 'pixel size' element in the datasheet.\n> Delays are set to 2 in case a setting is entered at the very and of the\n\ns/and/end/\n\n> N frame, the N+1 frame will miss it and only the N+2 frame will use this\n> new setting.\n> \n> Note that vd56g3 has a diagonal color test pattern, but does not match\n> any description in specified test patterns and therefore is ignored.\n> \n> Signed-off-by: Benjamin Mugnier \n> ---\n> src/libcamera/sensor/camera_sensor_properties.cpp | 21 +++++++++++++++++++++\n> 1 file changed, 21 insertions(+)\n> \n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index c9e9e148a1f08d64b63343ca2e204deaf9ef68c8..0816e2093c6d1b4531779455ea3147dcf32e741d 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -456,6 +456,27 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t},\n> \t\t\t.sensorDelays = { },\n> \t\t} },\n> +\t\t{ \"vd56g3\", {\n> +\t\t\t.unitCellSize = { 2160, 2160 },\n\nAccording to https://www.st.com/resource/en/datasheet/vd56g3.pdf, the\npixel size is 2.61µm. This matches the optical array dimensions,\ndocumented as 3570.48 x 2944.08, for a total of 1368x1128 pixels.\n\nThe rest looks good to me. If this is the only required change, I can\nfix the typos when applying.\n\nReviewed-by: Laurent Pinchart \n\n> +\t\t\t.testPatternModes = {\n> +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n> +\t\t\t\t{ controls::draft::TestPatternModeSolidColor, 1 },\n> +\t\t\t\t{ controls::draft::TestPatternModePn9, 6 },\n> +\t\t\t\t/*\n> +\t\t\t\t * No corresponding test pattern mode for:\n> +\t\t\t\t * 2: \"Vertical Color Bars\"\n> +\t\t\t\t * 3: \"Horizontal Gray Scale\"\n> +\t\t\t\t * 4: \"Vertical Gray Scale\"\n> +\t\t\t\t * 5: \"Diagonal Gray Scale\"\n> +\t\t\t\t */\n> +\t\t\t},\n> +\t\t\t.sensorDelays = {\n> +\t\t\t\t.exposureDelay = 2,\n> +\t\t\t\t.gainDelay = 2,\n> +\t\t\t\t.vblankDelay = 2,\n> +\t\t\t\t.hblankDelay = 2\n> +\t\t\t},\n> +\t\t} },\n> \t};\n> \n> \tconst auto it = sensorProps.find(sensor);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6384EC3237\n\tfor ;\n\tThu, 24 Jul 2025 10:13:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 60C10690CF;\n\tThu, 24 Jul 2025 12:13:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7BFF469028\n\tfor ;\n\tThu, 24 Jul 2025 12:13:03 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 4B76FC78;\n\tThu, 24 Jul 2025 12:12:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ATf9InWl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753351944;\n\tbh=hQ4SrAnXF2x7ul9wDRDVGDcmswkzmRuizFAtqlbOFOE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ATf9InWlilLYXELwcNtamhxdnNBN1+zT1F3wUHK4CbWW41VYi8jWb5kmIk0Be6QUg\n\tS7UXFm51HcZLTjW+Dgx+ZFgHunkUil2yM+ApswV+DfvHDjCWWj9uxUs4cJv3Wh0DpT\n\tZssK7vdiNEBTCdmJve1yQvnIA657I+NOzdcazlCo=","Date":"Thu, 24 Jul 2025 13:12:58 +0300","From":"Laurent Pinchart ","To":"Benjamin Mugnier ","Cc":"libcamera-devel@lists.libcamera.org,\n\tNaushir Patuck ,\n\tKieran Bingham ,\n\tSylvain Petinot ,\n\tCyril Liotard , Jean Poire ","Subject":"Re: [PATCH 1/3] libcamera: camera_sensor_properties: Add vd56g3\n\tcamera sensor","Message-ID":"<20250724101258.GF11202@pendragon.ideasonboard.com>","References":"<20250620-vd56g3_support-v1-0-df434bdbc9bd@foss.st.com>\n\t<20250620-vd56g3_support-v1-1-df434bdbc9bd@foss.st.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250620-vd56g3_support-v1-1-df434bdbc9bd@foss.st.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]