{"id":23618,"url":"https://patchwork.libcamera.org/api/patches/23618/?format=json","web_url":"https://patchwork.libcamera.org/patch/23618/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250620-vd56g3_support-v1-1-df434bdbc9bd@foss.st.com>","date":"2025-06-20T13:49:16","name":"[1/3] libcamera: camera_sensor_properties: Add vd56g3 camera sensor","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"405a09e23d572b5e9ac6fec1036ef10c77bdb28d","submitter":{"id":227,"url":"https://patchwork.libcamera.org/api/people/227/?format=json","name":"Benjamin Mugnier","email":"benjamin.mugnier@foss.st.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23618/mbox/","series":[{"id":5236,"url":"https://patchwork.libcamera.org/api/series/5236/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5236","date":"2025-06-20T13:49:18","name":"Add vd56g3 support for rpi and libipa","version":1,"mbox":"https://patchwork.libcamera.org/series/5236/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23618/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23618/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62048BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 20 Jun 2025 13:50:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D8C068DED;\n\tFri, 20 Jun 2025 15:50:55 +0200 (CEST)","from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com\n\t[185.132.182.106])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8BAE761538\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 20 Jun 2025 15:50:52 +0200 (CEST)","from pps.filterd (m0241204.ppops.net [127.0.0.1])\n\tby mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id\n\t55KCnWDs027615; Fri, 20 Jun 2025 15:50:51 +0200","from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35])\n\tby mx07-00178001.pphosted.com (PPS) with ESMTPS id 4790e2ps59-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Fri, 20 Jun 2025 15:50:51 +0200 (MEST)","from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20])\n\tby beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id C31ED40045; \n\tFri, 20 Jun 2025 15:50:13 +0200 (CEST)","from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69])\n\tby euls16034.sgp.st.com (STMicroelectronics) with ESMTP id\n\t68698AB9FE8; Fri, 20 Jun 2025 15:49:37 +0200 (CEST)","from localhost (10.130.73.167) by SHFDAG1NODE1.st.com\n\t(10.75.129.69) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39;\n\tFri, 20 Jun 2025 15:49:37 +0200"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=foss.st.com header.i=@foss.st.com\n\theader.b=\"6R3PAjxI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=selector1; bh=\n\taE2GiMAj/FuUMXl44Qihy9PsetcNUqkPxuZReEw/hso=; b=6R3PAjxI6WMsQ4Cg\n\tcogIRygf84t0q7qAfqMWKvM7huaVD3MhmsGhxf0ShDg9u0Su+1eWzoofC8VJZQTY\n\tGzVpDvGkKJSO6xGtJSv3Hapseromo5yh8x5NpwWv7XYB4GSLtZ9Pm/LEHh5dVk2E\n\tLMvBoLB4VYUTM7tJ0Zy4cOf68hlsOCSuLZCCBEqwRiLoAz86l4jeA8aBXQ71b6at\n\tUJQN/HhDfGeOqfqEQEva97KxYGOixLpiNOwOj/2zQ9R4U75iEWvDmilmEoAtPljq\n\tdyPRXRRHZtdDZfhwEckui8kP9T8GjtSfoMa9V/jUgc5Voc9NnnxcaPl6X8IdY3jx\n\tLmyqGg==","From":"Benjamin Mugnier <benjamin.mugnier@foss.st.com>","Date":"Fri, 20 Jun 2025 15:49:16 +0200","Subject":"[PATCH 1/3] libcamera: camera_sensor_properties: Add vd56g3 camera\n\tsensor","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-ID":"<20250620-vd56g3_support-v1-1-df434bdbc9bd@foss.st.com>","References":"<20250620-vd56g3_support-v1-0-df434bdbc9bd@foss.st.com>","In-Reply-To":"<20250620-vd56g3_support-v1-0-df434bdbc9bd@foss.st.com>","To":"<libcamera-devel@lists.libcamera.org>","CC":"Naushir Patuck <naush@raspberrypi.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, Sylvain Petinot\n\t<sylvain.petinot@foss.st.com>, Cyril Liotard <cyril.liotard@st.com>,\n\t\"Jean Poire\" <jean.poire@st.com>,\n\tBenjamin Mugnier <benjamin.mugnier@foss.st.com>","X-Mailer":"b4 0.14.2","X-Originating-IP":"[10.130.73.167]","X-ClientProxiedBy":"SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com\n\t(10.75.129.69)","X-Proofpoint-Virus-Version":"vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1099, Hydra:6.0.736,\n\tFMLib:17.12.80.40\n\tdefinitions=2025-06-20_05,2025-06-20_01,2025-03-28_01","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Add unit cell size from the 'pixel size' element in the datasheet.\nDelays are set to 2 in case a setting is entered at the very and of the\nN frame, the N+1 frame will miss it and only the N+2 frame will use this\nnew setting.\n\nNote that vd56g3 has a diagonal color test pattern, but does not match\nany description in specified test patterns and therefore is ignored.\n\nSigned-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>\n---\n src/libcamera/sensor/camera_sensor_properties.cpp | 21 +++++++++++++++++++++\n 1 file changed, 21 insertions(+)","diff":"diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex c9e9e148a1f08d64b63343ca2e204deaf9ef68c8..0816e2093c6d1b4531779455ea3147dcf32e741d 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -456,6 +456,27 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t},\n \t\t\t.sensorDelays = { },\n \t\t} },\n+\t\t{ \"vd56g3\", {\n+\t\t\t.unitCellSize = { 2160, 2160 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeSolidColor, 1 },\n+\t\t\t\t{ controls::draft::TestPatternModePn9, 6 },\n+\t\t\t\t/*\n+\t\t\t\t * No corresponding test pattern mode for:\n+\t\t\t\t * 2: \"Vertical Color Bars\"\n+\t\t\t\t * 3: \"Horizontal Gray Scale\"\n+\t\t\t\t * 4: \"Vertical Gray Scale\"\n+\t\t\t\t * 5: \"Diagonal Gray Scale\"\n+\t\t\t\t */\n+\t\t\t},\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 2,\n+\t\t\t\t.gainDelay = 2,\n+\t\t\t\t.vblankDelay = 2,\n+\t\t\t\t.hblankDelay = 2\n+\t\t\t},\n+\t\t} },\n \t};\n \n \tconst auto it = sensorProps.find(sensor);\n","prefixes":["1/3"]}