[{"id":35093,"web_url":"https://patchwork.libcamera.org/comment/35093/","msgid":"","date":"2025-07-24T09:25:48","subject":"Re: [PATCH 3/3] libcamera: libipa: Add vd56g3 support for libipa","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Benjamin,\n\nOn Fri, 20 Jun 2025 at 14:50, Benjamin Mugnier\n wrote:\n>\n> Adapted from rpi cam_helper and tuning files. Values are sourced\n> initially from the vd56g3 user manual.\n>\n> Signed-off-by: Benjamin Mugnier \n\nReviewed-by: Naushir Patuck \n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n>\n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 7c66cd57d6857e43863375d0b32d688fb5a1063c..dcd69d9f2bbb39feabfefe41cee8b45f0f958127 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -745,6 +745,18 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"ov13858\", CameraSensorHelperOv13858)\n>\n> +class CameraSensorHelperVd56g3 : public CameraSensorHelper\n> +{\n> +public:\n> + CameraSensorHelperVd56g3()\n> + {\n> + /* From datasheet: 0x40 at 10bits. */\n> + blackLevel_ = 4096;\n> + gain_ = AnalogueGainLinear{ 0, 32, -1, 32 };\n> + }\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"vd56g3\", CameraSensorHelperVd56g3)\n> +\n> #endif /* __DOXYGEN__ */\n>\n> } /* namespace ipa */\n>\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F44DC3237\n\tfor ;\n\tThu, 24 Jul 2025 09:26:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 72689690D6;\n\tThu, 24 Jul 2025 11:26:27 +0200 (CEST)","from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com\n\t[IPv6:2607:f8b0:4864:20::e33])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B277C690D2\n\tfor ;\n\tThu, 24 Jul 2025 11:26:25 +0200 (CEST)","by mail-vs1-xe33.google.com with SMTP id\n\tada2fe7eead31-4e811c529a1so10833137.3\n\tfor ;\n\tThu, 24 Jul 2025 02:26:25 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ZUOaXBLH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1753349184; x=1753953984;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=IHp3/FvEW9ZNdqxLUkh+LnDmvxGUb5k5qcdpGYSWdGo=;\n\tb=ZUOaXBLHpm9z2pVKYUkF2xBOXlSmgFQyMW/m7NLBbj7EEiLA2cFzz65pwxvnn/9H69\n\tIBmKgMSBjeczK1LJdUt8pzj/xrRkhXThKNZgWCf1WdQCO4QJR3H+Y7Q/1udlmEgrNniB\n\tjvbBpjKZLvCC6mDtNrcItX4CbZBy92Xsrr0PRPWeBh9LB4OgicndzFSfvfJmKfbRU7qL\n\t7s82Ejrqxc1Ggfb9M6JTbWnI0qgjG/DEb4M5oXUROjL+I3Ki9kfyN/Z46chn/zJ3DODn\n\t3OHoM9YGmlFFQlN6WBpnA8VSRpeCEq834rbkFYZwp96KdsnlZ/jXDSdbaxa7HklEuEpt\n\t1vRw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1753349184; x=1753953984;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=IHp3/FvEW9ZNdqxLUkh+LnDmvxGUb5k5qcdpGYSWdGo=;\n\tb=b5US+f1oPMALFppbutTlKwufW/gUBA+Af1B/fbtGAVmt4L2a61p2GvOP12lxazWSpg\n\tP0sBTxtVn8W0EpWYVN4eOBTmTjfAidXTwirkjW7p3efbvf0HrbOJBW6smSftoJueHorE\n\tPWstwFsMsNh29rg267HgPkJerzaE5SGn/7KKu2s6e1mE/gYwS8iD/2Np6eTMsg5uZ+q3\n\tZLcPWe9RNGZomyzJ89gOYtmoCKAkjq6DM6e+kZXncQyqdgqeQMRV0YM34nvE9Ma3Gmvg\n\t7q5J06hU4SfYJFJD0tIlQml7nSwY9yVkfBRQcCFFaLNxQModCZBvNpKz4nZ407GGVETu\n\tdvsw==","X-Gm-Message-State":"AOJu0YwGKav3gqP4q+RYnxZy5d6f16qayVw4ZW9qoWSdJDFUDnBmWMCE\n\tzbGW4cJnSpI4N58QL9vGcF0vkvpQbM+e6siTi5B/u+3gJ93uqU1vbeXEhJKBRYahEfbjc5ZQaX3\n\t1TgXaunI9+0x0F8gB3VykuRniYU//FZXk0OL+WnkMFQ==","X-Gm-Gg":"ASbGnctMbo7O+n9u2Bpc/Sms+QvO2iZYVniykonF6b73XtPTUYl96i9F5rHb9yIbjMq\n\trguIGcfjPAUuI3Lu37Gc1bI7+5Y7bfW12WZf5ref9inuxsbF+IZ6eGvbDkfnrnCsDQAtjELXsGP\n\t49CBiHuL8y1vXuzMWoBj3KP9X6NGpvv3hTFfJa2zqDqcgZqIvJu6BsXgoT+cGsp8ryBKWCXNtDz\n\tRjqKyA=","X-Google-Smtp-Source":"AGHT+IHKR9ysrc6CI30qnLd4QHhVceuganimO0Ow5QhX1/8KKAdFapX7SBtXJgW4T6syK2oAp4MuAGehEREGrD7Sg34=","X-Received":"by 2002:a05:6102:b01:b0:4dd:b34f:2d4f with SMTP id\n\tada2fe7eead31-4fa14fff718mr1027375137.2.1753349184460;\n\tThu, 24 Jul 2025 02:26:24 -0700 (PDT)","MIME-Version":"1.0","References":"<20250620-vd56g3_support-v1-0-df434bdbc9bd@foss.st.com>\n\t<20250620-vd56g3_support-v1-3-df434bdbc9bd@foss.st.com>","In-Reply-To":"<20250620-vd56g3_support-v1-3-df434bdbc9bd@foss.st.com>","From":"Naushir Patuck ","Date":"Thu, 24 Jul 2025 10:25:48 +0100","X-Gm-Features":"Ac12FXyO5VwvTq66vWu9nQAdLmxT0Ifmb7vPGcnrI6vrPAIQy-3z0feNwcsTkCI","Message-ID":"","Subject":"Re: [PATCH 3/3] libcamera: libipa: Add vd56g3 support for libipa","To":"Benjamin Mugnier ","Cc":"libcamera-devel@lists.libcamera.org, \n\tKieran Bingham , \n\tSylvain Petinot ,\n\tCyril Liotard , Jean Poire ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35097,"web_url":"https://patchwork.libcamera.org/comment/35097/","msgid":"<20250724102321.GH11202@pendragon.ideasonboard.com>","date":"2025-07-24T10:23:21","subject":"Re: [PATCH 3/3] libcamera: libipa: Add vd56g3 support for libipa","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Benjamin,\n\nThank you for the patch.\n\nOn Fri, Jun 20, 2025 at 03:49:18PM +0200, Benjamin Mugnier wrote:\n> Adapted from rpi cam_helper and tuning files. Values are sourced\n\nFrom the tuning files too ? I think you can drop this first sentence,\nthe patch is just about describing the black level and gain model. With\nthat,\n\nReviewed-by: Laurent Pinchart \n\n> initially from the vd56g3 user manual.\n> \n> Signed-off-by: Benjamin Mugnier \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 7c66cd57d6857e43863375d0b32d688fb5a1063c..dcd69d9f2bbb39feabfefe41cee8b45f0f958127 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -745,6 +745,18 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"ov13858\", CameraSensorHelperOv13858)\n> \n> +class CameraSensorHelperVd56g3 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperVd56g3()\n> +\t{\n> +\t\t/* From datasheet: 0x40 at 10bits. */\n> +\t\tblackLevel_ = 4096;\n> +\t\tgain_ = AnalogueGainLinear{ 0, 32, -1, 32 };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"vd56g3\", CameraSensorHelperVd56g3)\n> +\n> #endif /* __DOXYGEN__ */\n> \n> } /* namespace ipa */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D1BF1C3237\n\tfor ;\n\tThu, 24 Jul 2025 10:23:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 170B4690DC;\n\tThu, 24 Jul 2025 12:23:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B1497690CF\n\tfor ;\n\tThu, 24 Jul 2025 12:23:25 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 91F2CC79;\n\tThu, 24 Jul 2025 12:22:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"weCi7E1Y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753352566;\n\tbh=q4G4W1AKKutOOx77CXG3IPXhocBa/Ng8CqWLcGY/a7c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=weCi7E1Yc1ssKyVcTT4/YodXfXUSjxazIIZU0nL72rQxl+kRUV0UDoukBh/mZ9LWg\n\tpxbG7qYea1tO+ZtaLH2lNtBblypBgxEowFHOoxMrtKp0iLtdiGhx2XL9lQoS2Tq5pQ\n\tdfsVqLrSnB3vILB/gcs94r250nY7UuZiSBIfvK1Q=","Date":"Thu, 24 Jul 2025 13:23:21 +0300","From":"Laurent Pinchart ","To":"Benjamin Mugnier ","Cc":"libcamera-devel@lists.libcamera.org,\n\tNaushir Patuck ,\n\tKieran Bingham ,\n\tSylvain Petinot ,\n\tCyril Liotard , Jean Poire ","Subject":"Re: [PATCH 3/3] libcamera: libipa: Add vd56g3 support for libipa","Message-ID":"<20250724102321.GH11202@pendragon.ideasonboard.com>","References":"<20250620-vd56g3_support-v1-0-df434bdbc9bd@foss.st.com>\n\t<20250620-vd56g3_support-v1-3-df434bdbc9bd@foss.st.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250620-vd56g3_support-v1-3-df434bdbc9bd@foss.st.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]