[{"id":34569,"web_url":"https://patchwork.libcamera.org/comment/34569/","msgid":"","date":"2025-06-19T11:50:46","subject":"Re: [PATCH] libcamera: controls: Revert incorrect SPDX removal","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Sorry I missed that accidental removal :(\n\nOn Thu, 19 Jun 2025 at 12:16, Kieran Bingham\n wrote:\n>\n> In commit 6a09deaf7d4a (\"controls: Add FrameWallClock control\") the\n> existing SPDX was accidentally removed, likely from a rebase operation\n> at some point.\n>\n> Unfortunately as this patch had already collected Reviewed-by tags, the\n> surruptious removal wasn't noticed until after it was merged.\n>\n> Re-insert the existing SPDX and copyright banner as the header to the\n> control definitions file.\n>\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Naushir Patuck \n\n> ---\n>\n> Ooops, I merged something that interferred with the existing copyright\n> header. This brings it back again.\n>\n> src/libcamera/control_ids_core.yaml | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index 028919ef3d3e..46f51436c215 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -1,4 +1,6 @@\n> -\n> +# SPDX-License-Identifier: LGPL-2.1-or-later\n> +#\n> +# Copyright (C) 2019, Google Inc.\n> #\n> %YAML 1.1\n> ---\n> --\n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA282C3237\n\tfor ;\n\tThu, 19 Jun 2025 11:51:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B0B0968DDD;\n\tThu, 19 Jun 2025 13:51:24 +0200 (CEST)","from mail-vk1-xa34.google.com (mail-vk1-xa34.google.com\n\t[IPv6:2607:f8b0:4864:20::a34])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24E2768DDB\n\tfor ;\n\tThu, 19 Jun 2025 13:51:23 +0200 (CEST)","by mail-vk1-xa34.google.com with SMTP id\n\t71dfb90a1353d-53189c89a18so15238e0c.2\n\tfor ;\n\tThu, 19 Jun 2025 04:51:23 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"A9TQblE+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1750333882; x=1750938682;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=JLmNJrdYN0/uAe3g2HDzaEBcagrL7XDkIHabg+MVmTk=;\n\tb=A9TQblE+y9sSQYtHh4H87mOLSy/Iq4RzXTWSeZ+yqETZrZghImPO3Lq5sRROBayScg\n\t2hAvDVlurZHBNw8V2jAlfgG0cYF1emWPDuBNqKPsiQde7tZEBROKYF7517xC0kaJRjY+\n\tis04/Ys7NrMx3nh09qH2XyPCdKWwLGZ2wcfW5fON1IZFJFSY1waOPJn+3MDBlWjh5jbW\n\trgK7boNiyCsYP0bNh/uRmcU423GGgFUdeQ0NpIsswu4w1EOPZomYDG0byl0ryvE3tFPi\n\tbB+sqdRnn22Tjz3d0BIBUVF9/BGe8u4J/PUSxpgzfqleVZ5e+CIQ2QVZNoZ+xiNgNKmg\n\tGavQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1750333882; x=1750938682;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=JLmNJrdYN0/uAe3g2HDzaEBcagrL7XDkIHabg+MVmTk=;\n\tb=Bijm6NmlPZgSIaH4OzldRGFK56ubjw3rdMTU1gt0+n8j2H4eGlC9HGCBWduQhwFfkJ\n\txOFtLCLf7KSAylzTsP/9FORl6VrfUeN1DOBSMrMG4kGrzd7ENdaNXf63RCl3+CAYJV5D\n\tCOKz9ALVRhYcpdUjly4NAUKMt5q5Hdqc9764xXN/RqwnYWFENp7KUuTfd+XVlGSZVStA\n\tJD+rmAvKYa3cHqcTTkhYT9aOp+KsA1JzrhrHm7W4CFVxdCTunYwCRp/ZOB/nyj1gUknK\n\tilLZOyHT8sMb6yxXarWPQIelDOdSyZFn08mTuVFirqoit7EIBruSojenVsRwp+mii+RP\n\tuikg==","X-Gm-Message-State":"AOJu0Yzfq8plxaA3ErzotjpziHO50c21OWu+vdLS1AUUThFakyDxxXw1\n\tqBYeSuR3B7fvLphoaIWpuIP/RseuVpvk5pQJShcEPgvLCBKdB4zuang37Ut5K3wsxJrQlDKRB0w\n\t1wKUdlz80yvgiitoYBLhBEqoeHy9j0PioQCdulJmBczW3QDQC5fdg","X-Gm-Gg":"ASbGnctl2CBm9uF5Ihjiy89cGJ0N3uZwxgPE0rDFa4dGvu9BbC+JZYhBCaubDIB8fIa\n\taW2std/1xaj5aJgSTIxOlCalxPkPY/PIFyw4wei1oFSUu9dn0qhiqxzpYdMHtDiXdPL42m3keGm\n\tctUfrqlmM7prj6+1HPEWzDBKmv+/amsqNuCM/b3oVoMNirPTnAFevicojmCxTNJ1oD1DCTPWNf9\n\ttA=","X-Google-Smtp-Source":"AGHT+IGUs5oTbUzKOxM/2xSJzWqqaZP4xH5zCliMiI3OEq4V4WVJJ5qaYi8REFL+jf7+7CtW5+eQQWKZEU4WEH0r5mo=","X-Received":"by 2002:a05:6122:2a01:b0:531:188b:c1a4 with SMTP id\n\t71dfb90a1353d-5319d17dfc3mr644353e0c.1.1750333882043; Thu, 19 Jun 2025\n\t04:51:22 -0700 (PDT)","MIME-Version":"1.0","References":"<20250619111614.1132382-1-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20250619111614.1132382-1-kieran.bingham@ideasonboard.com>","From":"Naushir Patuck ","Date":"Thu, 19 Jun 2025 12:50:46 +0100","X-Gm-Features":"Ac12FXyKU9QlQWTPF8XIokBEh3QO_w3TDisl0mknZ_h9br32nchQXl9NzzaIqJM","Message-ID":"","Subject":"Re: [PATCH] libcamera: controls: Revert incorrect SPDX removal","To":"Kieran Bingham ","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34571,"web_url":"https://patchwork.libcamera.org/comment/34571/","msgid":"<20250619120850.GG28826@pendragon.ideasonboard.com>","date":"2025-06-19T12:08:50","subject":"Re: [PATCH] libcamera: controls: Revert incorrect SPDX removal","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jun 19, 2025 at 12:16:14PM +0100, Kieran Bingham wrote:\n> In commit 6a09deaf7d4a (\"controls: Add FrameWallClock control\") the\n> existing SPDX was accidentally removed, likely from a rebase operation\n> at some point.\n> \n> Unfortunately as this patch had already collected Reviewed-by tags, the\n> surruptious removal wasn't noticed until after it was merged.\n> \n> Re-insert the existing SPDX and copyright banner as the header to the\n> control definitions file.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> \n> Ooops, I merged something that interferred with the existing copyright\n> header. This brings it back again.\n> \n> src/libcamera/control_ids_core.yaml | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index 028919ef3d3e..46f51436c215 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -1,4 +1,6 @@\n> -\n> +# SPDX-License-Identifier: LGPL-2.1-or-later\n> +#\n> +# Copyright (C) 2019, Google Inc.\n> #\n> %YAML 1.1\n> ---","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 778A8C3237\n\tfor ;\n\tThu, 19 Jun 2025 12:09:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8972568DE9;\n\tThu, 19 Jun 2025 14:09:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2495A68DDD\n\tfor ;\n\tThu, 19 Jun 2025 14:09:09 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4067099F;\n\tThu, 19 Jun 2025 14:08:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ME4kUnT9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1750334935;\n\tbh=L+BKg8ZQMynGnD6KEXGbQgxx4vuT9JUEfYQcKg67aEA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ME4kUnT9vjt3KpNrat5YhuSnIUNYKF0q/GP/ztgUE4Tguhn2ZrYyMAGsI/QOz+Z35\n\txKpOfmv6cNz2Dsquvglyn6zHdmtx4F7e1iAyWfpOoSn8qQN47/7658TZ7ZUqSgz6l1\n\t/YAS2JyKSsC6a6bp2KoVlZ5ShD/TjA3hpBqFvNd8=","Date":"Thu, 19 Jun 2025 15:08:50 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH] libcamera: controls: Revert incorrect SPDX removal","Message-ID":"<20250619120850.GG28826@pendragon.ideasonboard.com>","References":"<20250619111614.1132382-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250619111614.1132382-1-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]