[{"id":34562,"web_url":"https://patchwork.libcamera.org/comment/34562/","msgid":"<4520e751-338b-447d-b7a1-4db5e89f4aa3@ideasonboard.com>","date":"2025-06-19T11:07:12","subject":"Re: [PATCH 1/4] controls: Add FrameWallClock control","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 06. 19. 12:05 keltezéssel, Naushir Patuck írta:\n> From: David Plowman <david.plowman@raspberrypi.com>\n> \n> Add a FrameWallClock control that reports the same moment as the\n> frame's SensorTimestamp, but in wallclock units.\n> \n> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> Reviewed-by: Naushir Patuck <naush@raspberrypi.com>\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> ---\n>   src/libcamera/control_ids_core.yaml | 19 ++++++++++++++++---\n>   1 file changed, 16 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index aa7448645880..028919ef3d3e 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -1,6 +1,4 @@\n> -# SPDX-License-Identifier: LGPL-2.1-or-later\n> -#\n> -# Copyright (C) 2019, Google Inc.\n> +\n>   #\n>   %YAML 1.1\n>   ---\n> @@ -1268,4 +1266,19 @@ controls:\n>         description: |\n>           Enable or disable the debug metadata.\n>   \n> +  - FrameWallClock:\n> +      type: int64_t\n> +      direction: out\n> +      description: |\n> +        This timestamp corresponds to the same moment in time as the\n> +        SensorTimestamp, but is represented as a wall clock time as measured by\n> +        the CLOCK_REALTIME clock.\n\n`SensorTimestamp` is in nanoseconds, but based on the last patch, this is in microseconds.\nThis should be clarified, or ideally, the two should use the same unit. Or am I missing\nsomething?\n\n\nRegards,\nBarnabás Pőcze\n\n> +\n> +        Being a wall clock measurement, it can be used to synchronise timing\n> +        across different devices.\n> +\n> +        \\sa SensorTimestamp\n> +\n> +        The FrameWallClock control can only be returned in metadata.\n> +\n>   ...","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56AB4C3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Jun 2025 11:07:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D7C468DE3;\n\tThu, 19 Jun 2025 13:07:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6485668DDB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Jun 2025 13:07:17 +0200 (CEST)","from [192.168.33.22] (185.221.143.107.nat.pool.zt.hu\n\t[185.221.143.107])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 827B42EC;\n\tThu, 19 Jun 2025 13:07:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LYF3Fe6n\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1750331223;\n\tbh=014a63lLAAbYcU7yVKrSk7MJ7gg/bkY+Lt12JIr3VYE=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=LYF3Fe6nlFLVb/VReF/D0Q1APIFSwGLjJe21JtDz7ufFRYZ8F791MzEy4kiR3rVqy\n\te1e+jdcAt58lMhiC1qv/DAS0HgA2CmXXF1Ca1DAYdYcwtJuTepf73AJwPZtNvFGvxi\n\tGGveyeqkJQGnInRCOb9gK5G7f8ZRSULR4s1FI4kY=","Message-ID":"<4520e751-338b-447d-b7a1-4db5e89f4aa3@ideasonboard.com>","Date":"Thu, 19 Jun 2025 13:07:12 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/4] controls: Add FrameWallClock control","To":"Naushir Patuck <naush@raspberrypi.com>,\n\tlibcamera-devel@lists.libcamera.org","Cc":"kieran.bingham@ideasonboard.com,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>","References":"<20250619100857.124809-1-naush@raspberrypi.com>\n\t<20250619100857.124809-2-naush@raspberrypi.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250619100857.124809-2-naush@raspberrypi.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":34563,"web_url":"https://patchwork.libcamera.org/comment/34563/","msgid":"<175033129825.4005407.8363152140141235501@ping.linuxembedded.co.uk>","date":"2025-06-19T11:08:18","subject":"Re: [PATCH 1/4] controls: Add FrameWallClock control","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2025-06-19 11:05:53)\n> From: David Plowman <david.plowman@raspberrypi.com>\n> \n> Add a FrameWallClock control that reports the same moment as the\n> frame's SensorTimestamp, but in wallclock units.\n> \n> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> Reviewed-by: Naushir Patuck <naush@raspberrypi.com>\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> ---\n>  src/libcamera/control_ids_core.yaml | 19 ++++++++++++++++---\n>  1 file changed, 16 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index aa7448645880..028919ef3d3e 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -1,6 +1,4 @@\n> -# SPDX-License-Identifier: LGPL-2.1-or-later\n> -#\n> -# Copyright (C) 2019, Google Inc.\n> +\n\nARGH.\n\nAnd of course only after merging do I notice this change ...\n\nHow come the copyrights are removed here. I don't think that was\nintentional - but I'm also not sure if this was accurate or correct now?\n\n--\nKieran\n\n\n>  #\n>  %YAML 1.1\n>  ---\n> @@ -1268,4 +1266,19 @@ controls:\n>        description: |\n>          Enable or disable the debug metadata.\n>  \n> +  - FrameWallClock:\n> +      type: int64_t\n> +      direction: out\n> +      description: |\n> +        This timestamp corresponds to the same moment in time as the\n> +        SensorTimestamp, but is represented as a wall clock time as measured by\n> +        the CLOCK_REALTIME clock.\n> +\n> +        Being a wall clock measurement, it can be used to synchronise timing\n> +        across different devices.\n> +\n> +        \\sa SensorTimestamp\n> +\n> +        The FrameWallClock control can only be returned in metadata.\n> +\n>  ...\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 17229C3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Jun 2025 11:08:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C602568DE3;\n\tThu, 19 Jun 2025 13:08:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A60368DDB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Jun 2025 13:08:21 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D0A512EC;\n\tThu, 19 Jun 2025 13:08:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UsUJtCdF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1750331287;\n\tbh=dqZPjbE5GKnLHbrXaq9Xe49ebe6c/QJebCC+R7FUkaE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=UsUJtCdFIUSYgvsAx8h6J1fQjgwS8H+jE+P0IziqTw4bc4Ywwl0J3yMu0QPSDeHi3\n\tYklrR9f58PcwanSjBntupSggtQOIwHUxTCBbALaEnpsq0GRgIruHRvYDxoTf9WAdMx\n\tUxcvMgGvPPlV9dkFoqB9w/YFvZfZVY68VaeEHSP0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250619100857.124809-2-naush@raspberrypi.com>","References":"<20250619100857.124809-1-naush@raspberrypi.com>\n\t<20250619100857.124809-2-naush@raspberrypi.com>","Subject":"Re: [PATCH 1/4] controls: Add FrameWallClock control","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"David Plowman <david.plowman@raspberrypi.com>,\n\tNaushir Patuck <naush@raspberrypi.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Naushir Patuck <naush@raspberrypi.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 19 Jun 2025 12:08:18 +0100","Message-ID":"<175033129825.4005407.8363152140141235501@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":34567,"web_url":"https://patchwork.libcamera.org/comment/34567/","msgid":"<CAEmqJPobQt+jM77Y5YQK6+tWcSHpQrL_T5Rf4_bz6VRGx+pDSg@mail.gmail.com>","date":"2025-06-19T11:37:40","subject":"Re: [PATCH 1/4] controls: Add FrameWallClock control","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"On Thu, 19 Jun 2025 at 12:08, Kieran Bingham\n<kieran.bingham@ideasonboard.com> wrote:\n>\n> Quoting Naushir Patuck (2025-06-19 11:05:53)\n> > From: David Plowman <david.plowman@raspberrypi.com>\n> >\n> > Add a FrameWallClock control that reports the same moment as the\n> > frame's SensorTimestamp, but in wallclock units.\n> >\n> > Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n> > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > Reviewed-by: Naushir Patuck <naush@raspberrypi.com>\n> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> > ---\n> >  src/libcamera/control_ids_core.yaml | 19 ++++++++++++++++---\n> >  1 file changed, 16 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> > index aa7448645880..028919ef3d3e 100644\n> > --- a/src/libcamera/control_ids_core.yaml\n> > +++ b/src/libcamera/control_ids_core.yaml\n> > @@ -1,6 +1,4 @@\n> > -# SPDX-License-Identifier: LGPL-2.1-or-later\n> > -#\n> > -# Copyright (C) 2019, Google Inc.\n> > +\n>\n> ARGH.\n>\n> And of course only after merging do I notice this change ...\n>\n> How come the copyrights are removed here. I don't think that was\n> intentional - but I'm also not sure if this was accurate or correct now?\n\nGroan, I missed that. :(  I can send a correction!\n\n>\n> --\n> Kieran\n>\n>\n> >  #\n> >  %YAML 1.1\n> >  ---\n> > @@ -1268,4 +1266,19 @@ controls:\n> >        description: |\n> >          Enable or disable the debug metadata.\n> >\n> > +  - FrameWallClock:\n> > +      type: int64_t\n> > +      direction: out\n> > +      description: |\n> > +        This timestamp corresponds to the same moment in time as the\n> > +        SensorTimestamp, but is represented as a wall clock time as measured by\n> > +        the CLOCK_REALTIME clock.\n> > +\n> > +        Being a wall clock measurement, it can be used to synchronise timing\n> > +        across different devices.\n> > +\n> > +        \\sa SensorTimestamp\n> > +\n> > +        The FrameWallClock control can only be returned in metadata.\n> > +\n> >  ...\n> > --\n> > 2.43.0\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EEF1AC3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Jun 2025 11:38:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1775A68DDD;\n\tThu, 19 Jun 2025 13:38:19 +0200 (CEST)","from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com\n\t[IPv6:2607:f8b0:4864:20::92b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C7D268DDB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Jun 2025 13:38:17 +0200 (CEST)","by mail-ua1-x92b.google.com with SMTP id\n\ta1e0cc1a2514c-87ec6fb9cb9so25931241.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Jun 2025 04:38:17 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"s2i+oExa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1750333096; x=1750937896;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=qV4k18dfBPMv8BLqKseJm1WmEx1d/H04YSlmnlksbvA=;\n\tb=s2i+oExafiqGj9EOZstvsVDSq++KiB6Xbx2F73YKj7SwdOQILICdcH00q8k3WscbRP\n\t1O0r3GLNyO1WdYhfDiT1Vj2knvts4jRsfRb1CscQHneAi2fEUHt6W7LHc4HEa2bXMijA\n\tNeDv7e74FNwysKZxgDAHmk8gjpQterCQZAHLjiJdedA20VDngQHXfuT/7kIRYHwyB0ee\n\tDeYWhYAazdiN0eshCm7qJOH4n2YhQtVO+jg609Q+WN3CxBFaEhkH3oT9HKKz07VAN43H\n\tmjXQcXry+gOc4kvS/Ef7ZQXUdGXLHOShfe/cefVTEguU1AIZN01SrrUfcgd9GdlkHFZx\n\twhsQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1750333096; x=1750937896;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=qV4k18dfBPMv8BLqKseJm1WmEx1d/H04YSlmnlksbvA=;\n\tb=V/8MPxhtcuGEBnQ/2r6XBABBseL7Le8S7fM7Yd6IWxaQf2OmIaP0UOQQq9JA58IcZb\n\tl0nRwz6J1CsBFbkHPiS/ee14pzlUgqmuTDbFfRSwFvDod6ohK/hqxXZGcOCoal6nTIAw\n\tueBQ+w2oQItmb8uJLEzOmSh0/yELnQECiwYhAQz4ZwCLOkhKNctoZgxBuWkyxtgzpe7T\n\tq1Pb1hzMWCszeeMomwoIpQEPJ1m+59geBuwA9ekKkAd9ftb5KYOlpC1TyUwcALOR+G8P\n\tMgw5TvxbM1lHJTVDiLhExbVbhp7b2xcq1LDe5k3vBgpR0L52HLWalFJXmPSaBZKL0M2n\n\t+4xA==","X-Gm-Message-State":"AOJu0YwraaUYBbjpwFXBUZC86g069igi5stZdXW13ADTJzBwgUkgclLE\n\tQvx6l2nJmEQNETq9rfff0pBPhKGizWoQdY27zXzq6JjF0TLUtS8YodA9pKsDLx/2C8jlfsfUJYB\n\tTDUpMbK5vImGeQq9JqW/t0qgTLeB2dZUomsNeiu/0GQ==","X-Gm-Gg":"ASbGncs1rMsF8QdpMhvBDudI/g6gKaD1GuUxi1TsCNAdfVuWgg+HXX/7i96VneSbkbM\n\thxagd/UHcr3tZmRK0BcIeIQmgqVowbHJ9WJ/d81Ash0XoHXrgOJqfj02qGaOKnOrdEpWoRTTu1C\n\tPa3ownRUJ4ef8xj5+PRe7HWEfcJDXrIH1rgr5S4x7N/PoL5UhlaOUfXGsy6ZSRlW0QfIB1W09NN\n\tcs=","X-Google-Smtp-Source":"AGHT+IEbDEi2bTJdbcdPOX7nMZxhMwqf/1RJRkiikTgVh/XBxzEQBYJVYDUMX4ZMqGUeHUPe9KCrlEYNm+h1CAbze9A=","X-Received":"by 2002:a05:6122:811c:20b0:531:3fa0:d69c with SMTP id\n\t71dfb90a1353d-5319d0552aamr441643e0c.0.1750333096367; Thu, 19 Jun 2025\n\t04:38:16 -0700 (PDT)","MIME-Version":"1.0","References":"<20250619100857.124809-1-naush@raspberrypi.com>\n\t<20250619100857.124809-2-naush@raspberrypi.com>\n\t<175033129825.4005407.8363152140141235501@ping.linuxembedded.co.uk>","In-Reply-To":"<175033129825.4005407.8363152140141235501@ping.linuxembedded.co.uk>","From":"Naushir Patuck <naush@raspberrypi.com>","Date":"Thu, 19 Jun 2025 12:37:40 +0100","X-Gm-Features":"Ac12FXzJOwPcSBKO__r0MhkYuMbqj4-bCc2kXHZ_JJHAbzFiPbNG5nYZjgFH0k4","Message-ID":"<CAEmqJPobQt+jM77Y5YQK6+tWcSHpQrL_T5Rf4_bz6VRGx+pDSg@mail.gmail.com>","Subject":"Re: [PATCH 1/4] controls: Add FrameWallClock control","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org, \n\tDavid Plowman <david.plowman@raspberrypi.com>, \n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":34568,"web_url":"https://patchwork.libcamera.org/comment/34568/","msgid":"<175033361724.4005407.350433754891699391@ping.linuxembedded.co.uk>","date":"2025-06-19T11:46:57","subject":"Re: [PATCH 1/4] controls: Add FrameWallClock control","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2025-06-19 12:37:40)\n> On Thu, 19 Jun 2025 at 12:08, Kieran Bingham\n> <kieran.bingham@ideasonboard.com> wrote:\n> >\n> > Quoting Naushir Patuck (2025-06-19 11:05:53)\n> > > From: David Plowman <david.plowman@raspberrypi.com>\n> > >\n> > > Add a FrameWallClock control that reports the same moment as the\n> > > frame's SensorTimestamp, but in wallclock units.\n> > >\n> > > Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n> > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > > Reviewed-by: Naushir Patuck <naush@raspberrypi.com>\n> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> > > ---\n> > >  src/libcamera/control_ids_core.yaml | 19 ++++++++++++++++---\n> > >  1 file changed, 16 insertions(+), 3 deletions(-)\n> > >\n> > > diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> > > index aa7448645880..028919ef3d3e 100644\n> > > --- a/src/libcamera/control_ids_core.yaml\n> > > +++ b/src/libcamera/control_ids_core.yaml\n> > > @@ -1,6 +1,4 @@\n> > > -# SPDX-License-Identifier: LGPL-2.1-or-later\n> > > -#\n> > > -# Copyright (C) 2019, Google Inc.\n> > > +\n> >\n> > ARGH.\n> >\n> > And of course only after merging do I notice this change ...\n> >\n> > How come the copyrights are removed here. I don't think that was\n> > intentional - but I'm also not sure if this was accurate or correct now?\n> \n> Groan, I missed that. :(  I can send a correction!\n\nSorry, Already did! - I should have added you on cc.\n\nhttps://patchwork.libcamera.org/patch/23606/\n\n> \n> >\n> > --\n> > Kieran\n> >\n> >\n> > >  #\n> > >  %YAML 1.1\n> > >  ---\n> > > @@ -1268,4 +1266,19 @@ controls:\n> > >        description: |\n> > >          Enable or disable the debug metadata.\n> > >\n> > > +  - FrameWallClock:\n> > > +      type: int64_t\n> > > +      direction: out\n> > > +      description: |\n> > > +        This timestamp corresponds to the same moment in time as the\n> > > +        SensorTimestamp, but is represented as a wall clock time as measured by\n> > > +        the CLOCK_REALTIME clock.\n> > > +\n> > > +        Being a wall clock measurement, it can be used to synchronise timing\n> > > +        across different devices.\n> > > +\n> > > +        \\sa SensorTimestamp\n> > > +\n> > > +        The FrameWallClock control can only be returned in metadata.\n> > > +\n> > >  ...\n> > > --\n> > > 2.43.0\n> > >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2A8CC3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Jun 2025 11:47:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9160568DE3;\n\tThu, 19 Jun 2025 13:47:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E90F668DDB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Jun 2025 13:46:59 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 35DA0107;\n\tThu, 19 Jun 2025 13:46:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qpu1VH0f\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1750333606;\n\tbh=IphkdkqtJYUJG3fAy4gw5LlzhCj8GHVaGwULpy76ij4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=qpu1VH0fbQEfdbd7LJTq8K662OjFNwq54Xiu/eGyRXZ+/DosbJ2YMfnfh7gadr4fp\n\t7io+RUcRdCi4/77lae11Tp8VU+/OdaDooELA3XhGFpNApeiBbNIx4KSXeZBfFfEa3p\n\tz5q7vPgFsI7T6vVQ5UhpohQWSXitgU0FL5Rz6h+w=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<CAEmqJPobQt+jM77Y5YQK6+tWcSHpQrL_T5Rf4_bz6VRGx+pDSg@mail.gmail.com>","References":"<20250619100857.124809-1-naush@raspberrypi.com>\n\t<20250619100857.124809-2-naush@raspberrypi.com>\n\t<175033129825.4005407.8363152140141235501@ping.linuxembedded.co.uk>\n\t<CAEmqJPobQt+jM77Y5YQK6+tWcSHpQrL_T5Rf4_bz6VRGx+pDSg@mail.gmail.com>","Subject":"Re: [PATCH 1/4] controls: Add FrameWallClock control","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Naushir Patuck <naush@raspberrypi.com>","Date":"Thu, 19 Jun 2025 12:46:57 +0100","Message-ID":"<175033361724.4005407.350433754891699391@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]