[{"id":3149,"web_url":"https://patchwork.libcamera.org/comment/3149/","msgid":"<20191127145004.27s4qwe4uly2yzjj@uno.localdomain>","date":"2019-11-27T14:50:04","subject":"Re: [libcamera-devel] [PATCH 12/30] libcamera: v4l2_videodevice:\n\tRemove assertion involving BufferPool","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Wed, Nov 27, 2019 at 12:36:02AM +0100, Niklas Söderlund wrote:\n> The BufferPool class will be removed when the buffer logic is reworked.\n> During the transition some functions will be shared between the new and\n> old buffer code and removing this assert allows sharing of the\n> dequeueBuffer() function.\n>\n\nThis single line change alone doesn't make much sense to me.\nI would like to see it where it is actually required. Anyway\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/v4l2_videodevice.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n>\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 7b6fa5347ef320f8..644e4545a2f33b2e 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -1100,7 +1100,6 @@ Buffer *V4L2VideoDevice::dequeueBuffer()\n> \t\treturn nullptr;\n> \t}\n>\n> -\tASSERT(buf.index < bufferPool_->count());\n> \tLOG(V4L2, Debug) << \"Buffer \" << buf.index << \" is available\";\n>\n> \tauto it = queuedBuffers_.find(buf.index);\n> --\n> 2.24.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4492360C33\n\tfor ;\n\tWed, 27 Nov 2019 15:47:58 +0100 (CET)","from uno.localdomain (93-34-114-233.ip49.fastwebnet.it\n\t[93.34.114.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D9A4EC0007;\n\tWed, 27 Nov 2019 14:47:57 +0000 (UTC)"],"X-Originating-IP":"93.34.114.233","Date":"Wed, 27 Nov 2019 15:50:04 +0100","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191127145004.27s4qwe4uly2yzjj@uno.localdomain>","References":"<20191126233620.1695316-1-niklas.soderlund@ragnatech.se>\n\t<20191126233620.1695316-13-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"4n4ixqtuhmvyk6nl\"","Content-Disposition":"inline","In-Reply-To":"<20191126233620.1695316-13-niklas.soderlund@ragnatech.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 12/30] libcamera: v4l2_videodevice:\n\tRemove assertion involving BufferPool","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 27 Nov 2019 14:47:58 -0000"}},{"id":3233,"web_url":"https://patchwork.libcamera.org/comment/3233/","msgid":"<20191209182547.GC18060@pendragon.ideasonboard.com>","date":"2019-12-09T18:25:47","subject":"Re: [libcamera-devel] [PATCH 12/30] libcamera: v4l2_videodevice:\n\tRemove assertion involving BufferPool","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Wed, Nov 27, 2019 at 03:50:04PM +0100, Jacopo Mondi wrote:\n> On Wed, Nov 27, 2019 at 12:36:02AM +0100, Niklas Söderlund wrote:\n> > The BufferPool class will be removed when the buffer logic is reworked.\n> > During the transition some functions will be shared between the new and\n> > old buffer code and removing this assert allows sharing of the\n> > dequeueBuffer() function.\n> \n> This single line change alone doesn't make much sense to me.\n> I would like to see it where it is actually required. Anyway\n\nI agree with Jacopo, please squash this with the patch that requires it.\nIt's actually counter-productive this split this out from a review point\nof view as it forces me to figure out which patch triggered this change.\n\n> Reviewed-by: Jacopo Mondi \n> \n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/libcamera/v4l2_videodevice.cpp | 1 -\n> > 1 file changed, 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> > index 7b6fa5347ef320f8..644e4545a2f33b2e 100644\n> > --- a/src/libcamera/v4l2_videodevice.cpp\n> > +++ b/src/libcamera/v4l2_videodevice.cpp\n> > @@ -1100,7 +1100,6 @@ Buffer *V4L2VideoDevice::dequeueBuffer()\n> > \t\treturn nullptr;\n> > \t}\n> >\n> > -\tASSERT(buf.index < bufferPool_->count());\n> > \tLOG(V4L2, Debug) << \"Buffer \" << buf.index << \" is available\";\n> >\n> > \tauto it = queuedBuffers_.find(buf.index);","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1EF3960BDB\n\tfor ;\n\tMon, 9 Dec 2019 19:25:55 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7FBD411B7;\n\tMon, 9 Dec 2019 19:25:54 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1575915954;\n\tbh=S1GSaWKAUzpOaKfKzeknLPVRzQZ5i7ydttTFPBXn7VY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qXjbOKg8gB5vRWJHI6iqbVCK7tS5q0KSAXuklMpAlZp9JJ51h8PyaL4fxj4vUsFk5\n\tv7aGUdLL0h1v/hINh3kFBZ0OEE4aOOvnShBCV7CsE9j7PHvRBCa7w8JVdf6dbF8Bm/\n\tf8tr5LoT3g18yjtaEAVHzw4b+d89fccRX6SYG+Mg=","Date":"Mon, 9 Dec 2019 20:25:47 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","Message-ID":"<20191209182547.GC18060@pendragon.ideasonboard.com>","References":"<20191126233620.1695316-1-niklas.soderlund@ragnatech.se>\n\t<20191126233620.1695316-13-niklas.soderlund@ragnatech.se>\n\t<20191127145004.27s4qwe4uly2yzjj@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191127145004.27s4qwe4uly2yzjj@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 12/30] libcamera: v4l2_videodevice:\n\tRemove assertion involving BufferPool","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 09 Dec 2019 18:25:55 -0000"}}]