[{"id":346,"web_url":"https://patchwork.libcamera.org/comment/346/","msgid":"<20190115222342.GH7393@bigcity.dyn.berto.se>","date":"2019-01-15T22:23:43","subject":"Re: [libcamera-devel] [PATCH v2 4/8] libcamera: pipeline_handler:\n\tRename handlers() method to factories()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-01-15 17:18:45 +0200, Laurent Pinchart wrote:\n> The PipelineHandlerFactory::handlers() static method returns a list of\n> factories, not a list of handlers. Rename it accordingly.\n> \n> Signed-off-by: Laurent Pinchart \n\nNice call,\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/camera_manager.cpp | 4 ++--\n> src/libcamera/include/pipeline_handler.h | 2 +-\n> src/libcamera/pipeline_handler.cpp | 6 +++---\n> 3 files changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 4313994e97c8..a17bf3d13a04 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -86,9 +86,9 @@ int CameraManager::start()\n> \t * file and only fallback on all handlers if there is no\n> \t * configuration file.\n> \t */\n> -\tstd::vector &handlers = PipelineHandlerFactory::handlers();\n> +\tstd::vector &factories = PipelineHandlerFactory::factories();\n> \n> -\tfor (PipelineHandlerFactory *factory : handlers) {\n> +\tfor (PipelineHandlerFactory *factory : factories) {\n> \t\t/*\n> \t\t * Try each pipeline handler until it exhaust\n> \t\t * all pipelines it can provide.\n> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> index 764dde9ccc65..e976aaa13546 100644\n> --- a/src/libcamera/include/pipeline_handler.h\n> +++ b/src/libcamera/include/pipeline_handler.h\n> @@ -39,7 +39,7 @@ public:\n> \tconst std::string &name() const { return name_; }\n> \n> \tstatic void registerType(PipelineHandlerFactory *factory);\n> -\tstatic std::vector &handlers();\n> +\tstatic std::vector &factories();\n> \n> private:\n> \tstd::string name_;\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 08e3291e741a..4dfbc814a813 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -92,7 +92,7 @@ namespace libcamera {\n> * \\param[in] name Name of the pipeline handler class\n> *\n> * Creating an instance of the factory registers is with the global list of\n> - * factories, accessible through the handlers() function.\n> + * factories, accessible through the factories() function.\n> *\n> * The factory \\a name is used for debug purpose and shall be unique.\n> */\n> @@ -127,7 +127,7 @@ PipelineHandlerFactory::PipelineHandlerFactory(const char *name)\n> */\n> void PipelineHandlerFactory::registerType(PipelineHandlerFactory *factory)\n> {\n> -\tstd::vector &factories = handlers();\n> +\tstd::vector &factories = PipelineHandlerFactory::factories();\n> \n> \tfor (PipelineHandlerFactory *f : factories)\n> \t\tASSERT(factory->name() != f->name());\n> @@ -145,7 +145,7 @@ void PipelineHandlerFactory::registerType(PipelineHandlerFactory *factory)\n> *\n> * \\return the list of pipeline handler factories\n> */\n> -std::vector &PipelineHandlerFactory::handlers()\n> +std::vector &PipelineHandlerFactory::factories()\n> {\n> \tstatic std::vector factories;\n> \treturn factories;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C5A6960C6A\n\tfor ;\n\tTue, 15 Jan 2019 23:23:44 +0100 (CET)","by mail-lj1-x244.google.com with SMTP id x85-v6so3784415ljb.2\n\tfor ;\n\tTue, 15 Jan 2019 14:23:44 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tm21sm836417lfl.97.2019.01.15.14.23.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 15 Jan 2019 14:23:43 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=Eis5YvUjmdxPUTgnZCzWrgDWsYSDvLcxg7V1o8leIUc=;\n\tb=LBc0uGq1krDKwWA6AeciBzU9WHOKvQXTPNWzUpa69Wy58zzl/JDA/FW7c+Wv6/VTIf\n\tqlRo2bZXzAiShSVeKM2/dhoygV5f71PUIk7WAlt8G0VLHJ0D+FXwpPWlnWpepmaaUCOq\n\tkou+t3PQ55PcJEMReCAiTBF39neZqn5J66PokEisIgIhkhjQtNCEBDmKQqGWrMtiZisN\n\tiP58rdJRDyOtH+Lec8ek+l7bat+iRrNyXHned1xdL4eOrzdFGDemtLFerrrWm7Q+1X7p\n\tLxBwG2CUwXmACec68ZouXOKnNZmB8izoek+LfjWp3bfRGbOor8W3GCQvyUi+hH0/v9V+\n\tRulw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=Eis5YvUjmdxPUTgnZCzWrgDWsYSDvLcxg7V1o8leIUc=;\n\tb=IJdXQIAgrB7W8dKUIxU32a66REp4sQS5j0RJlA8WYFrKsgMfFc5La2jvKI4iBdHWPU\n\tNpE4oMlXxDxco3Z6xxBvngxEYQ0pfYi28C6QRZlKiTBLTAt63DCVBGQ4cRqH+BDuoWKV\n\tjhN3LnDBFQHBGOVW8Di4YnA4opiq7y1GTAWrJkxzYuwtFbUcimu0L68cfbMGK8w44xK2\n\t3IG43j7QbyOAFeiTaPJa37f97pDtA2VaZQRvFAy81IJAsvgTwGwSlEyuPH082csjlm5c\n\t5d7y3cVkMLPJyDUfOwMq7ge8dgCBsjQOq/ApbZecKx9elF7gjavQj+cRxXRUSNNyL+zD\n\t7tKA==","X-Gm-Message-State":"AJcUukdoOqN1suuZ3y1yG8wliDdh1m0Do4NyWRS7xf8WooM0rcVU1URI\n\t7hN+ydKiCrBeEjdloIIejy0LP8FP0JU=","X-Google-Smtp-Source":"ALg8bN4KIfOUwPB+F1DhSwXIy7MYKOPYbMYL6lFVDVIQzm81Nsqw15CVV/720x3z75IgOk0ch33DJQ==","X-Received":"by 2002:a2e:29d7:: with SMTP id\n\tp84-v6mr4328550ljp.12.1547591024152; \n\tTue, 15 Jan 2019 14:23:44 -0800 (PST)","Date":"Tue, 15 Jan 2019 23:23:43 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190115222342.GH7393@bigcity.dyn.berto.se>","References":"<20190115151849.1547-1-laurent.pinchart@ideasonboard.com>\n\t<20190115151849.1547-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190115151849.1547-5-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 4/8] libcamera: pipeline_handler:\n\tRename handlers() method to factories()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 15 Jan 2019 22:23:45 -0000"}}]