[{"id":34504,"web_url":"https://patchwork.libcamera.org/comment/34504/","msgid":"<175014644257.3625350.4289068933186610541@ping.linuxembedded.co.uk>","date":"2025-06-17T07:47:22","subject":"Re: [PATCH] ipa: rkisp1: Move Sharpness control creation to Filter\n\talgorithm","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-06-16 23:15:11)\n> The Sharpness control is used solely by the Filter algorithm. Create it\n> there, to avoid exposing it to applications when the algorithm is\n> disabled.\n> \n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/rkisp1/algorithms/filter.cpp | 11 +++++++++++\n> src/ipa/rkisp1/algorithms/filter.h | 1 +\n> src/ipa/rkisp1/rkisp1.cpp | 1 -\n> 3 files changed, 12 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/filter.cpp b/src/ipa/rkisp1/algorithms/filter.cpp\n> index 7598ef8a9f47..8ad79801792f 100644\n> --- a/src/ipa/rkisp1/algorithms/filter.cpp\n> +++ b/src/ipa/rkisp1/algorithms/filter.cpp\n> @@ -39,6 +39,17 @@ LOG_DEFINE_CATEGORY(RkISP1Filter)\n> static constexpr uint32_t kFiltLumWeightDefault = 0x00022040;\n> static constexpr uint32_t kFiltModeDefault = 0x000004f2;\n> \n> +/**\n> + * \\copydoc libcamera::ipa::Algorithm::init\n> + */\n> +int Filter::init(IPAContext &context,\n> + [[maybe_unused]] const YamlObject &tuningData)\n> +{\n> + auto &cmap = context.ctrlMap;\n> + cmap[&controls::Sharpness] = ControlInfo(0.0f, 10.0f, 1.0f);\n> +\n> + return 0;\n> +}\n> /**\n> * \\copydoc libcamera::ipa::Algorithm::queueRequest\n> */\n> diff --git a/src/ipa/rkisp1/algorithms/filter.h b/src/ipa/rkisp1/algorithms/filter.h\n> index 8f858e574fa2..37d8938d37bd 100644\n> --- a/src/ipa/rkisp1/algorithms/filter.h\n> +++ b/src/ipa/rkisp1/algorithms/filter.h\n> @@ -21,6 +21,7 @@ public:\n> Filter() = default;\n> ~Filter() = default;\n> \n> + int init(IPAContext &context, const YamlObject &tuningData) override;\n> void queueRequest(IPAContext &context, const uint32_t frame,\n> IPAFrameContext &frameContext,\n> const ControlList &controls) override;\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 1ed7d7d92166..cf66d5553dcd 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -116,7 +116,6 @@ const IPAHwSettings ipaHwSettingsV12{\n> /* List of controls handled by the RkISP1 IPA */\n> const ControlInfoMap::Map rkisp1Controls{\n> { &controls::DebugMetadataEnable, ControlInfo(false, true, false) },\n> - { &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n> { &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n> };\n> \n> \n> base-commit: b3ff75d7589a263412ad63008b3c8518d40e6316\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 02DA7BDE6B\n\tfor ;\n\tTue, 17 Jun 2025 07:47:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90FA768DC9;\n\tTue, 17 Jun 2025 09:47:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B77768DB4\n\tfor ;\n\tTue, 17 Jun 2025 09:47:26 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DCD83107;\n\tTue, 17 Jun 2025 09:47:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YhV5EaF1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1750146434;\n\tbh=07aNBDU9CegoXyZ7ToYAdz5zYXLJ7XZkv4MS7SI9GvU=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=YhV5EaF1K/oGAYBdLXchqVlIVtg2yE89tMNXjLMs6DiyhdG9nr9byxDzYidCCxK9s\n\tJuQLQuto3++rcba5pFWPp4S6mPfd8Va7PogSdE4RG1284GSHMmCNmfcMLBlwZiodJk\n\tCBgnHlsp57XVvogCAN71NOda5NrKYy3/77ZBJH0Q=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250616221511.1374-1-laurent.pinchart@ideasonboard.com>","References":"<20250616221511.1374-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH] ipa: rkisp1: Move Sharpness control creation to Filter\n\talgorithm","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 17 Jun 2025 08:47:22 +0100","Message-ID":"<175014644257.3625350.4289068933186610541@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34506,"web_url":"https://patchwork.libcamera.org/comment/34506/","msgid":"<175015431083.87816.15721661075328515087@neptunite.rasen.tech>","date":"2025-06-17T09:58:30","subject":"Re: [PATCH] ipa: rkisp1: Move Sharpness control creation to Filter\n\talgorithm","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-06-17 07:15:11)\n> The Sharpness control is used solely by the Filter algorithm. Create it\n> there, to avoid exposing it to applications when the algorithm is\n> disabled.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/rkisp1/algorithms/filter.cpp | 11 +++++++++++\n> src/ipa/rkisp1/algorithms/filter.h | 1 +\n> src/ipa/rkisp1/rkisp1.cpp | 1 -\n> 3 files changed, 12 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/filter.cpp b/src/ipa/rkisp1/algorithms/filter.cpp\n> index 7598ef8a9f47..8ad79801792f 100644\n> --- a/src/ipa/rkisp1/algorithms/filter.cpp\n> +++ b/src/ipa/rkisp1/algorithms/filter.cpp\n> @@ -39,6 +39,17 @@ LOG_DEFINE_CATEGORY(RkISP1Filter)\n> static constexpr uint32_t kFiltLumWeightDefault = 0x00022040;\n> static constexpr uint32_t kFiltModeDefault = 0x000004f2;\n> \n> +/**\n> + * \\copydoc libcamera::ipa::Algorithm::init\n> + */\n> +int Filter::init(IPAContext &context,\n> + [[maybe_unused]] const YamlObject &tuningData)\n> +{\n> + auto &cmap = context.ctrlMap;\n> + cmap[&controls::Sharpness] = ControlInfo(0.0f, 10.0f, 1.0f);\n> +\n> + return 0;\n> +}\n> /**\n> * \\copydoc libcamera::ipa::Algorithm::queueRequest\n> */\n> diff --git a/src/ipa/rkisp1/algorithms/filter.h b/src/ipa/rkisp1/algorithms/filter.h\n> index 8f858e574fa2..37d8938d37bd 100644\n> --- a/src/ipa/rkisp1/algorithms/filter.h\n> +++ b/src/ipa/rkisp1/algorithms/filter.h\n> @@ -21,6 +21,7 @@ public:\n> Filter() = default;\n> ~Filter() = default;\n> \n> + int init(IPAContext &context, const YamlObject &tuningData) override;\n> void queueRequest(IPAContext &context, const uint32_t frame,\n> IPAFrameContext &frameContext,\n> const ControlList &controls) override;\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 1ed7d7d92166..cf66d5553dcd 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -116,7 +116,6 @@ const IPAHwSettings ipaHwSettingsV12{\n> /* List of controls handled by the RkISP1 IPA */\n> const ControlInfoMap::Map rkisp1Controls{\n> { &controls::DebugMetadataEnable, ControlInfo(false, true, false) },\n> - { &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n> { &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n> };\n> \n> \n> base-commit: b3ff75d7589a263412ad63008b3c8518d40e6316\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64256BDE6B\n\tfor ;\n\tTue, 17 Jun 2025 09:58:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D847668DC9;\n\tTue, 17 Jun 2025 11:58:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99B5B68DB4\n\tfor ;\n\tTue, 17 Jun 2025 11:58:38 +0200 (CEST)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:8af5:6d9e:2e04:8344])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id E002D496;\n\tTue, 17 Jun 2025 11:58:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GlTHUU/1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1750154306;\n\tbh=DHDa6TI1bu68w0PFhPCeT0J7rHZYH9YuJ1w21Bv/aHs=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=GlTHUU/1U9h4SOPU0wVIaTTCEKrvGxw3JCTe13oSDBlswnui+uUpV9GzhApkzvYbw\n\tovzWDbQBs5uPxto25OE+e7173H0IIh/vhgaf1yR2fbVzDAw8YYsIbDATjGqR+sjDsw\n\toBZViMa5FiEptATgi1MRGRNmpp3mIt3o1Mfhg7RY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250616221511.1374-1-laurent.pinchart@ideasonboard.com>","References":"<20250616221511.1374-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH] ipa: rkisp1: Move Sharpness control creation to Filter\n\talgorithm","From":"Paul Elder ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 17 Jun 2025 18:58:30 +0900","Message-ID":"<175015431083.87816.15721661075328515087@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]