{"id":23580,"url":"https://patchwork.libcamera.org/api/patches/23580/?format=json","web_url":"https://patchwork.libcamera.org/patch/23580/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250616221511.1374-1-laurent.pinchart@ideasonboard.com>","date":"2025-06-16T22:15:11","name":"ipa: rkisp1: Move Sharpness control creation to Filter algorithm","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8b3fa59c2622f6a88aa4e1b3c357d3664f5f59cb","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23580/mbox/","series":[{"id":5224,"url":"https://patchwork.libcamera.org/api/series/5224/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5224","date":"2025-06-16T22:15:11","name":"ipa: rkisp1: Move Sharpness control creation to Filter algorithm","version":1,"mbox":"https://patchwork.libcamera.org/series/5224/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23580/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23580/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1454EC3237\n\tfor ;\n\tMon, 16 Jun 2025 22:15:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0CEBF68DCB;\n\tTue, 17 Jun 2025 00:15:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCE1661548\n\tfor ;\n\tTue, 17 Jun 2025 00:15:27 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C45E122A\n\tfor ;\n\tTue, 17 Jun 2025 00:15:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MoLLH83m\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1750112116;\n\tbh=edUcuUXEpMTDOWltcqArEjteoDTSr9+SgCOfVQZElQs=;\n\th=From:To:Subject:Date:From;\n\tb=MoLLH83mWCjDoc2507POk2WZo3uyycbk1LRjKamq80Pr+2zFrXaqp+MRL3+iuX9c9\n\tzE91f6pChI4jqOj2pSuv76HKGkNQfrzYJObfx6tzuSpY5ZON/ljG0L/BncUuLeJZIe\n\tiR6nsbcNvi+e1CUR2lPtDHNofM271ooM+Dk3mZyg=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH] ipa: rkisp1: Move Sharpness control creation to Filter\n\talgorithm","Date":"Tue, 17 Jun 2025 01:15:11 +0300","Message-ID":"<20250616221511.1374-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The Sharpness control is used solely by the Filter algorithm. Create it\nthere, to avoid exposing it to applications when the algorithm is\ndisabled.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/rkisp1/algorithms/filter.cpp | 11 +++++++++++\n src/ipa/rkisp1/algorithms/filter.h | 1 +\n src/ipa/rkisp1/rkisp1.cpp | 1 -\n 3 files changed, 12 insertions(+), 1 deletion(-)\n\n\nbase-commit: b3ff75d7589a263412ad63008b3c8518d40e6316\n--\nRegards,\n\nLaurent Pinchart","diff":"diff --git a/src/ipa/rkisp1/algorithms/filter.cpp b/src/ipa/rkisp1/algorithms/filter.cpp\nindex 7598ef8a9f47..8ad79801792f 100644\n--- a/src/ipa/rkisp1/algorithms/filter.cpp\n+++ b/src/ipa/rkisp1/algorithms/filter.cpp\n@@ -39,6 +39,17 @@ LOG_DEFINE_CATEGORY(RkISP1Filter)\n static constexpr uint32_t kFiltLumWeightDefault = 0x00022040;\n static constexpr uint32_t kFiltModeDefault = 0x000004f2;\n\n+/**\n+ * \\copydoc libcamera::ipa::Algorithm::init\n+ */\n+int Filter::init(IPAContext &context,\n+\t\t [[maybe_unused]] const YamlObject &tuningData)\n+{\n+\tauto &cmap = context.ctrlMap;\n+\tcmap[&controls::Sharpness] = ControlInfo(0.0f, 10.0f, 1.0f);\n+\n+\treturn 0;\n+}\n /**\n * \\copydoc libcamera::ipa::Algorithm::queueRequest\n */\ndiff --git a/src/ipa/rkisp1/algorithms/filter.h b/src/ipa/rkisp1/algorithms/filter.h\nindex 8f858e574fa2..37d8938d37bd 100644\n--- a/src/ipa/rkisp1/algorithms/filter.h\n+++ b/src/ipa/rkisp1/algorithms/filter.h\n@@ -21,6 +21,7 @@ public:\n \tFilter() = default;\n \t~Filter() = default;\n\n+\tint init(IPAContext &context, const YamlObject &tuningData) override;\n \tvoid queueRequest(IPAContext &context, const uint32_t frame,\n \t\t\t IPAFrameContext &frameContext,\n \t\t\t const ControlList &controls) override;\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 1ed7d7d92166..cf66d5553dcd 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -116,7 +116,6 @@ const IPAHwSettings ipaHwSettingsV12{\n /* List of controls handled by the RkISP1 IPA */\n const ControlInfoMap::Map rkisp1Controls{\n \t{ &controls::DebugMetadataEnable, ControlInfo(false, true, false) },\n-\t{ &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n \t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n };\n\n","prefixes":[]}