[{"id":34469,"web_url":"https://patchwork.libcamera.org/comment/34469/","msgid":"<174982781452.425770.10828479080701129038@ping.linuxembedded.co.uk>","date":"2025-06-13T15:16:54","subject":"Re: [PATCH v1] apps: common: image: Fix assertion","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-06-13 15:37:19)\n> `plane` must be strictly less than the vector's size,\n> it cannot be equal to it.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/apps/common/image.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/apps/common/image.cpp b/src/apps/common/image.cpp\n> index a2a0f58f3..9a67238aa 100644\n> --- a/src/apps/common/image.cpp\n> +++ b/src/apps/common/image.cpp\n> @@ -98,12 +98,12 @@ unsigned int Image::numPlanes() const\n> \n> Span Image::data(unsigned int plane)\n> {\n> - assert(plane <= planes_.size());\n> + assert(plane < planes_.size());\n> return planes_[plane];\n> }\n> \n> Span Image::data(unsigned int plane) const\n> {\n> - assert(plane <= planes_.size());\n> + assert(plane < planes_.size());\n> return planes_[plane];\n> }\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DE07C3237\n\tfor ;\n\tFri, 13 Jun 2025 15:17:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C68768DB4;\n\tFri, 13 Jun 2025 17:16:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F30EB61550\n\tfor ;\n\tFri, 13 Jun 2025 17:16:57 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5203E4A4;\n\tFri, 13 Jun 2025 17:16:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"L7iH9wdF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749827808;\n\tbh=CFCwJe52K0mIAw8fk/zQGI6C2ZpkSeQRZPRZH/uctME=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=L7iH9wdFiQKhHidSk8GlZ1u7w5sZ0voB68SCvQ9F/P838djc5eQHlk0VBlQoUfUVW\n\tRSQ9jsk00bpq7130eDXORqqZQSyEOV56lfBB1mTrcqnQ6NlKvT8NeOu6xL6DjQfBhV\n\tloiMNw3CG4MhUT9R/czq5qCwFTZg2Ltjl+yRyZas=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250613143719.1131707-1-barnabas.pocze@ideasonboard.com>","References":"<20250613143719.1131707-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] apps: common: image: Fix assertion","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 13 Jun 2025 16:16:54 +0100","Message-ID":"<174982781452.425770.10828479080701129038@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34470,"web_url":"https://patchwork.libcamera.org/comment/34470/","msgid":"<20250615001805.GS10542@pendragon.ideasonboard.com>","date":"2025-06-15T00:18:05","subject":"Re: [PATCH v1] apps: common: image: Fix assertion","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Jun 13, 2025 at 04:37:19PM +0200, Barnabás Pőcze wrote:\n> `plane` must be strictly less than the vector's size,\n> it cannot be equal to it.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/apps/common/image.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/apps/common/image.cpp b/src/apps/common/image.cpp\n> index a2a0f58f3..9a67238aa 100644\n> --- a/src/apps/common/image.cpp\n> +++ b/src/apps/common/image.cpp\n> @@ -98,12 +98,12 @@ unsigned int Image::numPlanes() const\n> \n> Span Image::data(unsigned int plane)\n> {\n> -\tassert(plane <= planes_.size());\n> +\tassert(plane < planes_.size());\n> \treturn planes_[plane];\n> }\n> \n> Span Image::data(unsigned int plane) const\n> {\n> -\tassert(plane <= planes_.size());\n> +\tassert(plane < planes_.size());\n> \treturn planes_[plane];\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9CFAC3237\n\tfor ;\n\tSun, 15 Jun 2025 00:18:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7207368DC4;\n\tSun, 15 Jun 2025 02:18:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51AD661538\n\tfor ;\n\tSun, 15 Jun 2025 02:18:19 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9358C6F9;\n\tSun, 15 Jun 2025 02:18:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dFN/0BkX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749946688;\n\tbh=rgpgyRLVzzXVM3i6RstevD8sxXeEfRhObSPzNuFJjxA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dFN/0BkXftvNRF/lyAy3ApaPUYC22j3OyVvUZb45WoP6eFOGPcv4U8Z5euPrCrAIA\n\tHbWNCtP3r1aarDyCqLHZ/eCmTSEc9uMHcJGR7JA8nj5qLmV42ZpmX81cjm8CxTjhtP\n\tjF0VBdLYhLKK2tCnOK7tiSUZi0CCj8QRV5J9zZyU=","Date":"Sun, 15 Jun 2025 03:18:05 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] apps: common: image: Fix assertion","Message-ID":"<20250615001805.GS10542@pendragon.ideasonboard.com>","References":"<20250613143719.1131707-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250613143719.1131707-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]