{"id":23548,"url":"https://patchwork.libcamera.org/api/patches/23548/?format=json","web_url":"https://patchwork.libcamera.org/patch/23548/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250611142431.33306-6-mzamazal@redhat.com>","date":"2025-06-11T14:24:21","name":"[v9,05/13] config: Look up rpi config path in configuration file","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f30e10ab24886c55566dc24c9301c68892aed248","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23548/mbox/","series":[{"id":5215,"url":"https://patchwork.libcamera.org/api/series/5215/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5215","date":"2025-06-11T14:24:16","name":"Add global configuration file","version":9,"mbox":"https://patchwork.libcamera.org/series/5215/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23548/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23548/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1554C3325\n\tfor ;\n\tWed, 11 Jun 2025 14:24:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5161968DCA;\n\tWed, 11 Jun 2025 16:24:59 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D75B168DC9\n\tfor ;\n\tWed, 11 Jun 2025 16:24:55 +0200 (CEST)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-32-jYU5VhB_MKWJ-Y2H8ynBrg-1;\n\tWed, 11 Jun 2025 10:24:52 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id EF17B19560B6; Wed, 11 Jun 2025 14:24:50 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.33.76])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id BDE2F18003FC; Wed, 11 Jun 2025 14:24:48 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"PzQ2tZjM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1749651894;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=8KUIEKL7vct6WbfNpd6rdbuBTRdbwj8xHjaxpmfmvVg=;\n\tb=PzQ2tZjME8V9P5x2ZNKnbh4Tq1Ai1M00iIMvbjVjIzNscrI9Rzve9SGm3FlH5bNOUn1hBv\n\tzOiFtbGa2ziz7Z1/t+bzHCmOdYNIiTx1vVdrAQ7VIpNK6COEKkcogeQEWma5TkNhsZLCTa\n\t0XoqX5WmQL69V7LUysjlE6INLnia0ig=","X-MC-Unique":"jYU5VhB_MKWJ-Y2H8ynBrg-1","X-Mimecast-MFC-AGG-ID":"jYU5VhB_MKWJ-Y2H8ynBrg_1749651891","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Laurent Pinchart\n\t","Subject":"[PATCH v9 05/13] config: Look up rpi config path in configuration\n\tfile","Date":"Wed, 11 Jun 2025 16:24:21 +0200","Message-ID":"<20250611142431.33306-6-mzamazal@redhat.com>","In-Reply-To":"<20250611142431.33306-1-mzamazal@redhat.com>","References":"<20250611142431.33306-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"-wWCgcqqTkaBEYarpJkv7EwJeIbulopBnTuXQaCHXok_1749651891","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Let's introduce a configuration option for rpi configuration file path.\nIt may be arguable whether pipeline specific configurations belong to\nthe global configuration file. But:\n\n- Having a single configuration file is generally easier for the user.\n- The original configuration via environment variables can be already\n considered global.\n- This option points to other configuration files and it makes little\n sense to add another configuration file to the chain.\n\nThe configuration snippet:\n\n configuration:\n pipeline:\n rpi:\n config_file: FILENAME\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex 1f13e5230..dc84537d4 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -20,6 +20,7 @@\n #include \n \n #include \"libcamera/internal/camera_lens.h\"\n+#include \"libcamera/internal/global_configuration.h\"\n #include \"libcamera/internal/ipa_manager.h\"\n #include \"libcamera/internal/v4l2_subdevice.h\"\n \n@@ -1102,7 +1103,12 @@ int CameraData::loadPipelineConfiguration()\n \t/* Initial configuration of the platform, in case no config file is present */\n \tplatformPipelineConfigure({});\n \n-\tchar const *configFromEnv = utils::secure_getenv(\"LIBCAMERA_RPI_CONFIG_FILE\");\n+\tconst GlobalConfiguration &config = pipe()->cameraManager()->_d()->configuration();\n+\tstd::optional configFile =\n+\t\tconfig.envOption(\"LIBCAMERA_RPI_CONFIG_FILE\", \"pipelines.rpi.config_file\");\n+\tif (!configFile.has_value())\n+\t\treturn 0;\n+\tchar const *configFromEnv = configFile.value().c_str();\n \tif (!configFromEnv || *configFromEnv == '\\0')\n \t\treturn 0;\n \n","prefixes":["v9","05/13"]}