[{"id":34454,"web_url":"https://patchwork.libcamera.org/comment/34454/","msgid":"<20250611142333.GK24465@pendragon.ideasonboard.com>","date":"2025-06-11T14:23:33","subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Silently ignore\n\t`AeEnable`","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jun 11, 2025 at 03:19:35PM +0100, Kieran Bingham wrote:\n> Quoting Barnabás Pőcze (2025-06-11 14:41:18)\n> > The `AeEnable` control is handled in `Camera::queueRequest()`\n> > but it still reaches the pipeline handler, so ignore it silently.\n> > \n> > Fixes: ffcecda4d5b9b5 (\"libcamera: pipeline: uvcvideo: Report new AeEnable control as available\")\n> > Signed-off-by: Barnabás Pőcze \n> > ---\n> > src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 2 ++\n> > 1 file changed, 2 insertions(+)\n> > \n> > diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> > index 58aa0eb4c..d52b88042 100644\n> > --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> > +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> > @@ -331,6 +331,8 @@ int PipelineHandlerUVC::processControl(const UVCCameraData *data, ControlList *c\n> > cid = V4L2_CID_GAIN;\n> > else if (id == controls::Gamma)\n> > cid = V4L2_CID_GAMMA;\n> > + else if (id == controls::AeEnable)\n> > + return 0; /* Handled in `Camera::queueRequest()`. */\n> \n> I think this is probably the best thing to do here - I wonder if we\n> should have a way to 'remove' the AeEnable control during\n> Camera::queueRequest so that it doesn't have to have these special\n> cases, but I'm not sure we can do that at the moment.\n\nWe should, but we can't ATM :-/\n\n> So,\n> \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> > else\n> > return -EINVAL;\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52F27C3237\n\tfor ;\n\tWed, 11 Jun 2025 14:23:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 02D6B68DBC;\n\tWed, 11 Jun 2025 16:23:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33A0961552\n\tfor ;\n\tWed, 11 Jun 2025 16:23:46 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 185AA526;\n\tWed, 11 Jun 2025 16:23:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wmc0Rv5b\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749651818;\n\tbh=LtTACTpQqOLEobOQNnjVtuAQL7wWhHykeEIWCYN6tjY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wmc0Rv5blHJwduiabR9Mca8wFfl5E7c75Qn+Ocbis583AA8YzdQpL12VGvROMIgzs\n\tNsycWxnA8hVdcCPjhsypzq/BqKVsWnJp01Iz77teFbHcexv6xAQHdRK7jmniZqttXs\n\tnE8L2mT+/juA5myFjNavKA3qugWJOyWXshDISucU=","Date":"Wed, 11 Jun 2025 17:23:33 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Silently ignore\n\t`AeEnable`","Message-ID":"<20250611142333.GK24465@pendragon.ideasonboard.com>","References":"<20250611134118.585044-1-barnabas.pocze@ideasonboard.com>\n\t<174965157551.3656751.1488130690448059339@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<174965157551.3656751.1488130690448059339@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34455,"web_url":"https://patchwork.libcamera.org/comment/34455/","msgid":"<20250611142357.GL24465@pendragon.ideasonboard.com>","date":"2025-06-11T14:23:57","subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Silently ignore\n\t`AeEnable`","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jun 11, 2025 at 05:23:35PM +0300, Laurent Pinchart wrote:\n> On Wed, Jun 11, 2025 at 03:19:35PM +0100, Kieran Bingham wrote:\n> > Quoting Barnabás Pőcze (2025-06-11 14:41:18)\n> > > The `AeEnable` control is handled in `Camera::queueRequest()`\n> > > but it still reaches the pipeline handler, so ignore it silently.\n> > > \n> > > Fixes: ffcecda4d5b9b5 (\"libcamera: pipeline: uvcvideo: Report new AeEnable control as available\")\n> > > Signed-off-by: Barnabás Pőcze \n> > > ---\n> > > src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 2 ++\n> > > 1 file changed, 2 insertions(+)\n> > > \n> > > diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> > > index 58aa0eb4c..d52b88042 100644\n> > > --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> > > +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> > > @@ -331,6 +331,8 @@ int PipelineHandlerUVC::processControl(const UVCCameraData *data, ControlList *c\n> > > cid = V4L2_CID_GAIN;\n> > > else if (id == controls::Gamma)\n> > > cid = V4L2_CID_GAMMA;\n> > > + else if (id == controls::AeEnable)\n> > > + return 0; /* Handled in `Camera::queueRequest()`. */\n> > \n> > I think this is probably the best thing to do here - I wonder if we\n> > should have a way to 'remove' the AeEnable control during\n> > Camera::queueRequest so that it doesn't have to have these special\n> > cases, but I'm not sure we can do that at the moment.\n> \n> We should, but we can't ATM :-/\n\nIt would be nice to explain this in the commit message.\n\n> > So,\n> > \n> > Reviewed-by: Kieran Bingham \n> \n> Reviewed-by: Laurent Pinchart \n> \n> > > else\n> > > return -EINVAL;\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 265E9C3237\n\tfor ;\n\tWed, 11 Jun 2025 14:24:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C461868DC3;\n\tWed, 11 Jun 2025 16:24:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 02D3E68DBC\n\tfor ;\n\tWed, 11 Jun 2025 16:24:10 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E185E6BE;\n\tWed, 11 Jun 2025 16:24:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WpSBLjkq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749651842;\n\tbh=lzV8buq6ZqGiwzh++qsBU8LhijLesj7wRHvZccDJKJ0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WpSBLjkqDD6Yh94SU92pu2srmnpRSfd8qXCmbmnx1cbifbpacU/xmuvSq/iaz7fzM\n\tv+zsvy1my6pI9uKeWPrHZGR29AyusXWS870msAJD4ItQmEbxd5/WLrihqOv4DEx08S\n\tlNFtb9coutC2kKdMIvSTiIw0RRA513k6rku3xQjo=","Date":"Wed, 11 Jun 2025 17:23:57 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Silently ignore\n\t`AeEnable`","Message-ID":"<20250611142357.GL24465@pendragon.ideasonboard.com>","References":"<20250611134118.585044-1-barnabas.pocze@ideasonboard.com>\n\t<174965157551.3656751.1488130690448059339@ping.linuxembedded.co.uk>\n\t<20250611142333.GK24465@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250611142333.GK24465@pendragon.ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34456,"web_url":"https://patchwork.libcamera.org/comment/34456/","msgid":"","date":"2025-06-11T14:27:19","subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Silently ignore\n\t`AeEnable`","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 06. 11. 16:19 keltezéssel, Kieran Bingham írta:\n> Quoting Barnabás Pőcze (2025-06-11 14:41:18)\n>> The `AeEnable` control is handled in `Camera::queueRequest()`\n>> but it still reaches the pipeline handler, so ignore it silently.\n>>\n>> Fixes: ffcecda4d5b9b5 (\"libcamera: pipeline: uvcvideo: Report new AeEnable control as available\")\n>> Signed-off-by: Barnabás Pőcze \n>> ---\n>> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 2 ++\n>> 1 file changed, 2 insertions(+)\n>>\n>> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n>> index 58aa0eb4c..d52b88042 100644\n>> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n>> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n>> @@ -331,6 +331,8 @@ int PipelineHandlerUVC::processControl(const UVCCameraData *data, ControlList *c\n>> cid = V4L2_CID_GAIN;\n>> else if (id == controls::Gamma)\n>> cid = V4L2_CID_GAMMA;\n>> + else if (id == controls::AeEnable)\n>> + return 0; /* Handled in `Camera::queueRequest()`. */\n> \n> I think this is probably the best thing to do here - I wonder if we\n> should have a way to 'remove' the AeEnable control during\n> Camera::queueRequest so that it doesn't have to have these special\n> cases, but I'm not sure we can do that at the moment.\n\nIt should be simple to add `extract()/remove()` to `ControlList`, but I\ndon't know why it hasn't been done so far.\n\n\nRegards,\nBarnabás Pőcze\n\n> \n> So,\n> \n> \n> Reviewed-by: Kieran Bingham \n> \n>> else\n>> return -EINVAL;\n>>\n>> --\n>> 2.49.0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AA88ABDE6B\n\tfor ;\n\tWed, 11 Jun 2025 14:27:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3EC6568DD0;\n\tWed, 11 Jun 2025 16:27:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6521B61552\n\tfor ;\n\tWed, 11 Jun 2025 16:27:23 +0200 (CEST)","from [192.168.33.24] (185.221.142.30.nat.pool.zt.hu\n\t[185.221.142.30])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2BFC2526;\n\tWed, 11 Jun 2025 16:27:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ddWGnicW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749652035;\n\tbh=dfDfMCy1qqq5SmjsJtEoc8ZOJ0QYPkQXegeVjJwV4j0=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=ddWGnicW9S9qogzkF7doEJlQvSCFylQeSfW5k0GfK6nf0KUfwNh58bu2pBa1Hu78d\n\tl+ukOwUqUZtPXTQBHeYJE0rCBu7Bz4E68p/h6lY1Wlw7S6TbNogn4qSHSHFkbxQn0V\n\tNczI2NPiKbgwLpyHX3FeMGVzie34VzsMR6lDbur0=","Message-ID":"","Date":"Wed, 11 Jun 2025 16:27:19 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Silently ignore\n\t`AeEnable`","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20250611134118.585044-1-barnabas.pocze@ideasonboard.com>\n\t<174965157551.3656751.1488130690448059339@ping.linuxembedded.co.uk>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<174965157551.3656751.1488130690448059339@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34457,"web_url":"https://patchwork.libcamera.org/comment/34457/","msgid":"<89e49780-3433-4f21-8671-0cc271accfcb@ideasonboard.com>","date":"2025-06-11T14:31:01","subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Silently ignore\n\t`AeEnable`","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 06. 11. 16:23 keltezéssel, Laurent Pinchart írta:\n> On Wed, Jun 11, 2025 at 05:23:35PM +0300, Laurent Pinchart wrote:\n>> On Wed, Jun 11, 2025 at 03:19:35PM +0100, Kieran Bingham wrote:\n>>> Quoting Barnabás Pőcze (2025-06-11 14:41:18)\n>>>> The `AeEnable` control is handled in `Camera::queueRequest()`\n>>>> but it still reaches the pipeline handler, so ignore it silently.\n>>>>\n>>>> Fixes: ffcecda4d5b9b5 (\"libcamera: pipeline: uvcvideo: Report new AeEnable control as available\")\n>>>> Signed-off-by: Barnabás Pőcze \n>>>> ---\n>>>> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 2 ++\n>>>> 1 file changed, 2 insertions(+)\n>>>>\n>>>> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n>>>> index 58aa0eb4c..d52b88042 100644\n>>>> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n>>>> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n>>>> @@ -331,6 +331,8 @@ int PipelineHandlerUVC::processControl(const UVCCameraData *data, ControlList *c\n>>>> cid = V4L2_CID_GAIN;\n>>>> else if (id == controls::Gamma)\n>>>> cid = V4L2_CID_GAMMA;\n>>>> + else if (id == controls::AeEnable)\n>>>> + return 0; /* Handled in `Camera::queueRequest()`. */\n>>>\n>>> I think this is probably the best thing to do here - I wonder if we\n>>> should have a way to 'remove' the AeEnable control during\n>>> Camera::queueRequest so that it doesn't have to have these special\n>>> cases, but I'm not sure we can do that at the moment.\n>>\n>> We should, but we can't ATM :-/\n> \n> It would be nice to explain this in the commit message.\n\nI will modify it as follows:\n\n The `AeEnable` control is handled in `Camera::queueRequest()` but it\n still reaches the pipeline handler because a single element cannot be\n removed from a `ControlList`. So ignore it silently.\n\n\n\n> \n>>> So,\n>>>\n>>> Reviewed-by: Kieran Bingham \n>>\n>> Reviewed-by: Laurent Pinchart \n>>\n>>>> else\n>>>> return -EINVAL;\n>>>>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60662C3237\n\tfor ;\n\tWed, 11 Jun 2025 14:31:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 743E668DC4;\n\tWed, 11 Jun 2025 16:31:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A0DEC68DBC\n\tfor ;\n\tWed, 11 Jun 2025 16:31:05 +0200 (CEST)","from [192.168.33.24] (185.221.142.30.nat.pool.zt.hu\n\t[185.221.142.30])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2BEDA526;\n\tWed, 11 Jun 2025 16:30:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Xt4iw9Bm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749652257;\n\tbh=2xpXy82iUbAiuk0brRNtSb+ZqoJ3G09xg8id8ercUcg=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=Xt4iw9BmWdswyICL2jYmaSYQaoldHhG7b0mGrU0WMnPs11qADp3QBxTvFWeoPfklH\n\tLbpP027znIdC8rOW8lvy08rgtGudTz8XTdoVq5ZmYnjdGUxKQ+vlGUlTNJ2Vqz1GHF\n\tM+CtLivMf0AKAxOy5t3f4r6zZcln2ufjW7C7zYJs=","Message-ID":"<89e49780-3433-4f21-8671-0cc271accfcb@ideasonboard.com>","Date":"Wed, 11 Jun 2025 16:31:01 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Silently ignore\n\t`AeEnable`","To":"Laurent Pinchart ,\n\tKieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20250611134118.585044-1-barnabas.pocze@ideasonboard.com>\n\t<174965157551.3656751.1488130690448059339@ping.linuxembedded.co.uk>\n\t<20250611142333.GK24465@pendragon.ideasonboard.com>\n\t<20250611142357.GL24465@pendragon.ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250611142357.GL24465@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34458,"web_url":"https://patchwork.libcamera.org/comment/34458/","msgid":"<20250611144556.GB32107@pendragon.ideasonboard.com>","date":"2025-06-11T14:45:56","subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Silently ignore\n\t`AeEnable`","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jun 11, 2025 at 04:31:01PM +0200, Barnabás Pőcze wrote:\n> 2025. 06. 11. 16:23 keltezéssel, Laurent Pinchart írta:\n> > On Wed, Jun 11, 2025 at 05:23:35PM +0300, Laurent Pinchart wrote:\n> >> On Wed, Jun 11, 2025 at 03:19:35PM +0100, Kieran Bingham wrote:\n> >>> Quoting Barnabás Pőcze (2025-06-11 14:41:18)\n> >>>> The `AeEnable` control is handled in `Camera::queueRequest()`\n> >>>> but it still reaches the pipeline handler, so ignore it silently.\n> >>>>\n> >>>> Fixes: ffcecda4d5b9b5 (\"libcamera: pipeline: uvcvideo: Report new AeEnable control as available\")\n> >>>> Signed-off-by: Barnabás Pőcze \n> >>>> ---\n> >>>> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 2 ++\n> >>>> 1 file changed, 2 insertions(+)\n> >>>>\n> >>>> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> >>>> index 58aa0eb4c..d52b88042 100644\n> >>>> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> >>>> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> >>>> @@ -331,6 +331,8 @@ int PipelineHandlerUVC::processControl(const UVCCameraData *data, ControlList *c\n> >>>> cid = V4L2_CID_GAIN;\n> >>>> else if (id == controls::Gamma)\n> >>>> cid = V4L2_CID_GAMMA;\n> >>>> + else if (id == controls::AeEnable)\n> >>>> + return 0; /* Handled in `Camera::queueRequest()`. */\n> >>>\n> >>> I think this is probably the best thing to do here - I wonder if we\n> >>> should have a way to 'remove' the AeEnable control during\n> >>> Camera::queueRequest so that it doesn't have to have these special\n> >>> cases, but I'm not sure we can do that at the moment.\n> >>\n> >> We should, but we can't ATM :-/\n> > \n> > It would be nice to explain this in the commit message.\n> \n> I will modify it as follows:\n> \n> The `AeEnable` control is handled in `Camera::queueRequest()` but it\n> still reaches the pipeline handler because a single element cannot be\n> removed from a `ControlList`. So ignore it silently.\n\nPerfect.\n\n> >>> So,\n> >>>\n> >>> Reviewed-by: Kieran Bingham \n> >>\n> >> Reviewed-by: Laurent Pinchart \n> >>\n> >>>> else\n> >>>> return -EINVAL;\n> >>>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 45799BDE6B\n\tfor ;\n\tWed, 11 Jun 2025 14:46:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E9A5068DBF;\n\tWed, 11 Jun 2025 16:46:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D32168DBC\n\tfor ;\n\tWed, 11 Jun 2025 16:46:09 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F1F81526;\n\tWed, 11 Jun 2025 16:46:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RUbXjW8C\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749653161;\n\tbh=MjlAGKMgM4it26YKcB1QfZmdLSNGzPlP73GpeZmx0rk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RUbXjW8CmKXHgWxuAX6jTpKUwIoZ9wSTFZ4W51b7mk0Zmkn8ujfeul42J+JW1wHoF\n\t+shX9K0EaVzJRnuA/kXmzVfWLJx+1VV7PaGizV6gnioXEB6eCUO48Zimln01FHQJBy\n\tksD4ssYKnkxIIZogG58GjcISTIG9V3o9UdMaChyc=","Date":"Wed, 11 Jun 2025 17:45:56 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Silently ignore\n\t`AeEnable`","Message-ID":"<20250611144556.GB32107@pendragon.ideasonboard.com>","References":"<20250611134118.585044-1-barnabas.pocze@ideasonboard.com>\n\t<174965157551.3656751.1488130690448059339@ping.linuxembedded.co.uk>\n\t<20250611142333.GK24465@pendragon.ideasonboard.com>\n\t<20250611142357.GL24465@pendragon.ideasonboard.com>\n\t<89e49780-3433-4f21-8671-0cc271accfcb@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<89e49780-3433-4f21-8671-0cc271accfcb@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34466,"web_url":"https://patchwork.libcamera.org/comment/34466/","msgid":"<174965157551.3656751.1488130690448059339@ping.linuxembedded.co.uk>","date":"2025-06-11T14:19:35","subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Silently ignore\n\t`AeEnable`","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-06-11 14:41:18)\n> The `AeEnable` control is handled in `Camera::queueRequest()`\n> but it still reaches the pipeline handler, so ignore it silently.\n> \n> Fixes: ffcecda4d5b9b5 (\"libcamera: pipeline: uvcvideo: Report new AeEnable control as available\")\n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 58aa0eb4c..d52b88042 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -331,6 +331,8 @@ int PipelineHandlerUVC::processControl(const UVCCameraData *data, ControlList *c\n> cid = V4L2_CID_GAIN;\n> else if (id == controls::Gamma)\n> cid = V4L2_CID_GAMMA;\n> + else if (id == controls::AeEnable)\n> + return 0; /* Handled in `Camera::queueRequest()`. */\n\nI think this is probably the best thing to do here - I wonder if we\nshould have a way to 'remove' the AeEnable control during\nCamera::queueRequest so that it doesn't have to have these special\ncases, but I'm not sure we can do that at the moment.\n\nSo,\n\n\nReviewed-by: Kieran Bingham \n\n> else\n> return -EINVAL;\n> \n> --\n> 2.49.0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC18DC3237\n\tfor ;\n\tFri, 13 Jun 2025 14:00:30 +0000 (UTC)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net\n\t[86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 144FE348\n\tfor ;\n\tFri, 13 Jun 2025 16:00:21 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749823221;\n\tbh=4phUOPAu2bwJGdO692hNW0f8hWNmrKcTya0KM0EiQzQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:Resent-From:Resent-To:\n\tFrom;\n\tb=PZ++2a3AawADSItSw/eeccBDCFOYBUcZASlUNPiawkacOlwcjwttQKA1YhZMG6pM2\n\tfOn7n9n0BlBcH7gyHtA1iVNCP5IZ/E51X3UAhAWzTf6wsTpvxsbh4qj7gqqAKvsNPV\n\tF3EVFJfpGCZ0gfaC8V6zFe+q6L4TiaCl+gQDMfDU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250611134118.585044-1-barnabas.pocze@ideasonboard.com>","References":"<20250611134118.585044-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Silently ignore\n\t`AeEnable`","From":"Kieran Bingham ","To":"Barnab??s P??cze ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 11 Jun 2025 15:19:35 +0100","Message-ID":"<174965157551.3656751.1488130690448059339@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","Resent-From":"Kieran Bingham ","Resent-To":"parsemail@patchwork.libcamera.org"}},{"id":34673,"web_url":"https://patchwork.libcamera.org/comment/34673/","msgid":"<175100522897.2836253.10023535694913903590@neptunite.rasen.tech>","date":"2025-06-27T06:20:28","subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Silently ignore\n\t`AeEnable`","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-06-11 22:41:18)\n> The `AeEnable` control is handled in `Camera::queueRequest()`\n> but it still reaches the pipeline handler, so ignore it silently.\n> \n> Fixes: ffcecda4d5b9b5 (\"libcamera: pipeline: uvcvideo: Report new AeEnable control as available\")\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 58aa0eb4c..d52b88042 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -331,6 +331,8 @@ int PipelineHandlerUVC::processControl(const UVCCameraData *data, ControlList *c\n> cid = V4L2_CID_GAIN;\n> else if (id == controls::Gamma)\n> cid = V4L2_CID_GAMMA;\n> + else if (id == controls::AeEnable)\n> + return 0; /* Handled in `Camera::queueRequest()`. */\n> else\n> return -EINVAL;\n> \n> --\n> 2.49.0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A963EC3237\n\tfor ;\n\tFri, 27 Jun 2025 06:20:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 66F2668DF7;\n\tFri, 27 Jun 2025 08:20:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 28C4761528\n\tfor ;\n\tFri, 27 Jun 2025 08:20:35 +0200 (CEST)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:e17c:62b2:2597:dc1b])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 3DB3F6A6;\n\tFri, 27 Jun 2025 08:20:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J/+C7rPf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751005215;\n\tbh=uIEnqhpqY0NkvYdGF2kTYSDb1A+8xzC691N4tPKt7i8=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=J/+C7rPfZclcdsqzO90HS1sH/4XdEjHX+c4oYchG+INGdKgx9jMi2vW9VppFTELyb\n\tlskQDD8rabVFlaYrPQjzeXc1immj56ZnZpXJjxjEBt5mkvpjr86kbDlfWZhJz4aiot\n\tfqQeh//DgYskxNfNvyCBpceg0bUUWX96qc6Ir0Go=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250611134118.585044-1-barnabas.pocze@ideasonboard.com>","References":"<20250611134118.585044-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Silently ignore\n\t`AeEnable`","From":"Paul Elder ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 27 Jun 2025 15:20:28 +0900","Message-ID":"<175100522897.2836253.10023535694913903590@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]