{"id":23542,"url":"https://patchwork.libcamera.org/api/patches/23542/?format=json","web_url":"https://patchwork.libcamera.org/patch/23542/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250611134118.585044-1-barnabas.pocze@ideasonboard.com>","date":"2025-06-11T13:41:18","name":"[v1] libcamera: pipeline: uvcvideo: Silently ignore `AeEnable`","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ef0f0eff3fa77f96a7c717c4c405562d6cd04197","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23542/mbox/","series":[{"id":5213,"url":"https://patchwork.libcamera.org/api/series/5213/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5213","date":"2025-06-11T13:41:18","name":"[v1] libcamera: pipeline: uvcvideo: Silently ignore `AeEnable`","version":1,"mbox":"https://patchwork.libcamera.org/series/5213/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23542/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23542/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93471BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Jun 2025 13:41:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B528468DC0;\n\tWed, 11 Jun 2025 15:41:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 83DCF61552\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Jun 2025 15:41:23 +0200 (CEST)","from pb-laptop.local (185.221.142.30.nat.pool.zt.hu\n\t[185.221.142.30])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7482B352\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Jun 2025 15:41:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"m78/OFyZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749649275;\n\tbh=0U3II/jl5EQWqJwsmQv5hAV3OowuHxkn8zds2hSZjIo=;\n\th=From:To:Subject:Date:From;\n\tb=m78/OFyZFPndazSUehVEFIcQ3BHB1eVwc+MzK//R45/XDibBBTPoXjlAOC4ilP0qw\n\tzBnmgSW7jLhaQo7t4kNn22CEt6rMSNN1ZZx7Gz576zPNyVaqNojGROxgiUi1cNS+A3\n\ti17YXvs2dN4gYLiFaqUp3hHuykZqVuAMfLLQQ8+c=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] libcamera: pipeline: uvcvideo: Silently ignore `AeEnable`","Date":"Wed, 11 Jun 2025 15:41:18 +0200","Message-ID":"<20250611134118.585044-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The `AeEnable` control is handled in `Camera::queueRequest()`\nbut it still reaches the pipeline handler, so ignore it silently.\n\nFixes: ffcecda4d5b9b5 (\"libcamera: pipeline: uvcvideo: Report new AeEnable control as available\")\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 2 ++\n 1 file changed, 2 insertions(+)\n\n--\n2.49.0","diff":"diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex 58aa0eb4c..d52b88042 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -331,6 +331,8 @@ int PipelineHandlerUVC::processControl(const UVCCameraData *data, ControlList *c\n \t\tcid = V4L2_CID_GAIN;\n \telse if (id == controls::Gamma)\n \t\tcid = V4L2_CID_GAMMA;\n+\telse if (id == controls::AeEnable)\n+\t\treturn 0; /* Handled in `Camera::queueRequest()`. */\n \telse\n \t\treturn -EINVAL;\n\n","prefixes":["v1"]}