[{"id":34496,"web_url":"https://patchwork.libcamera.org/comment/34496/","msgid":"<1ca57e77-2831-4286-b12c-ee54988271d0@linaro.org>","date":"2025-06-16T19:22:33","subject":"Re: [PATCH 29/35] libcamera: software_isp: Make isStandardBayerOrder\n\tstatic","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"content":"On 11/06/2025 02:32, Bryan O'Donoghue wrote:\n> Make this member function static so that it may be called from static\n> members of derived classes.\n> \n> Signed-off-by: Bryan O'Donoghue \n> ---\n> src/libcamera/software_isp/debayer.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\n> index 214bcdd3..3893318b 100644\n> --- a/src/libcamera/software_isp/debayer.h\n> +++ b/src/libcamera/software_isp/debayer.h\n> @@ -88,7 +88,7 @@ private:\n> protected:\n> \tvoid setParams(DebayerParams ¶ms);\n> \tvoid dmaSyncBegin(std::vector &dmaSyncers, FrameBuffer *input, FrameBuffer *output);\n> -\tbool isStandardBayerOrder(BayerFormat::Order order);\n> +\tstatic bool isStandardBayerOrder(BayerFormat::Order order);\n> };\n> \n> } /* namespace libcamera */\n> --\n> 2.49.0\n> \n\nBoth this and the next patch can/should be dropped, provided we can tell \nGBM to do 24 BPP at a reasonable stage in the object instantiation logic.\n\nWe need not have static methods in the Bayer classes to ask what pixel \nformats they support.\n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D6A7CBDE6B\n\tfor ;\n\tMon, 16 Jun 2025 19:22:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8EB0B68DCF;\n\tMon, 16 Jun 2025 21:22:36 +0200 (CEST)","from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F158368DC0\n\tfor ;\n\tMon, 16 Jun 2025 21:22:34 +0200 (CEST)","by mail-wm1-x333.google.com with SMTP id\n\t5b1f17b1804b1-451ebd3d149so32533065e9.2\n\tfor ;\n\tMon, 16 Jun 2025 12:22:34 -0700 (PDT)","from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-3a57b15015fsm6146194f8f.95.2025.06.16.12.22.33\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tMon, 16 Jun 2025 12:22:34 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"DcU2FbYz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1750101754; x=1750706554;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:to:subject:user-agent:mime-version:date:message-id:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=Jbs2JIKqX5cgxQO0QvxpVMjB6oLtqagbL5I90LusO3o=;\n\tb=DcU2FbYzCT4VcpA2ENrpST+Qnwgv2gyEJtyUTIGfmXVxvryDBxQalTtDDA06ZNI5xG\n\tUCegLpcap1aTDwf96uuO5dyRNafnVnr8jPuxtzuPkOF8CcJcoqj7XGj07z6c7LJR8AjI\n\tkoxSo9CAzWEcdPEXF87l1GNQWAsaXYnAoZc6Q46XtiZgI1ytIjxvEuM+m+NWWorDz2zf\n\t0scRt38hcRJXRseV1aa/b0Zb7JPkV5+EZn6AZ5LWmHLmCRVD2SQ894qkxKsiq+nGfOqq\n\tL6MOyskSmJVM8lFy7slg8dJ6kAhA1FCfzppJQ/z//xu3ug0WiqKrTYS677Vgyfik72uI\n\t4LnQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1750101754; x=1750706554;\n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=Jbs2JIKqX5cgxQO0QvxpVMjB6oLtqagbL5I90LusO3o=;\n\tb=JoXMD8T7AgBR3gSEkD0jmIPoZQtnd/jl0Uh2FBbikjTUwJANNjldompcl6ij5HYApB\n\tOnt7U5oDzDL0IfKiNrJqJrNKOrsWz1ZrskvchEK9w+rFxiiGYdUuzFqx6j84jPh2vPrn\n\tGoQatceyujAXMdUWR0nJKsldWBE4ciEgFSH8KYce10h+MEuNIdU8tVSwBxMbybum0XNm\n\tA2jO3gx35pdGD1gOZjrTubJtWlutqh3kPXN6shcVYsQ8Jf/fOU82GAU6xmzRs5wv9q8Z\n\tGKyFp9EUF2vpat2TxVYKbn5OnTRE1LbmFhsmvGPQ5n5kC3VfwRTXJNSN/FfpWPD2N/7J\n\txWrA==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCVXWLqwkoy7aUv1mcv7SGjkWN4mU9282T62RAsb19Nmde/pBZlp+1ltLF2PzPn136xjzdV7EfJzSBiksSOIVnE=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YwHe/2svzK8G3mtYQnv5T1WB9Usf2cmcVHMwwRFG9vobR9W3P1g\n\tgsR9+PNoXK2hqApvOg3DR0yWitUVkweWOJ6VMxYqO4sW3cngyODxu4jV0RyQfyLvpETpKLUh1cr\n\t42vyA8Yw=","X-Gm-Gg":"ASbGncs8Z06gRazw27+mvBR95DR1AwRC3hhx7onfhtWuBxt9G5SncybrYJbC2INuYlo\n\teZ43QvfGkfIc0XY17adFv8mGViKah0wE/KmXdK1VmgXSCwA3XzBC0g6bhfO9j28jQ5EsP8euIcz\n\tvox5g9UvvxFQKhBOM1BStcVI5WsOqTC21/jTLVNPzgJvPYugzWj1pVOVQIDxejX3m+p2dLWGRzV\n\tlLoZ0jFRZdliaBT6o1jlf9JFKgeCgaeR41PlURTIbpA8s8nNqWQvDuO9pRPMz2ZNmfB6Dqti3jE\n\t5aTn3RIzbrhwbrcbfRU/wgQL+Fg2Q27VC4TPKdVPn2s+wt7vA8g2OoeVrbIypClCgyr8DBhrBEA\n\tSi6QLM8tsviKpuY5Ys3LqfzzdGb8=","X-Google-Smtp-Source":"AGHT+IE12XUPoS2P5/D3CHKSoJFhROrNJ8tKiErUPEunIDt0sDJjWv3h6lahahNzkdnrig2rgeBMWA==","X-Received":"by 2002:a05:600c:1d1f:b0:440:68db:9fef with SMTP id\n\t5b1f17b1804b1-4534f9f165amr23550145e9.20.1750101754605; \n\tMon, 16 Jun 2025 12:22:34 -0700 (PDT)","Message-ID":"<1ca57e77-2831-4286-b12c-ee54988271d0@linaro.org>","Date":"Mon, 16 Jun 2025 20:22:33 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 29/35] libcamera: software_isp: Make isStandardBayerOrder\n\tstatic","To":"Bryan O'Donoghue ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20250611013245.133785-1-bryan.odonoghue@linaro.org>\n\t\n\t<20250611013245.133785-30-bryan.odonoghue@linaro.org>","Content-Language":"en-US","From":"Bryan O'Donoghue ","In-Reply-To":"<20250611013245.133785-30-bryan.odonoghue@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]