[{"id":34545,"web_url":"https://patchwork.libcamera.org/comment/34545/","msgid":"<85y0tpxmd3.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-06-18T12:31:04","subject":"Re: [PATCH 27/35] libcamera: software_isp: debayer_egl: Convert\n\tfrom identity CCM to CCM calculated by SoftIPA","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> src/libcamera/software_isp/debayer_egl.cpp | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> index 824cd6d3..b30d2107 100644\n> --- a/src/libcamera/software_isp/debayer_egl.cpp\n> +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> @@ -293,7 +293,7 @@ int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n> \tinputConfig_.stride = inputCfg.stride;\n> \twidth_ = inputCfg.size.width;\n> \theight_ = inputCfg.size.height;\n> -\tccmEnabled_ = ccmEnabled = true;\n> +\tccmEnabled_ = ccmEnabled;\n> \n> \tif (outputCfgs.size() != 1) {\n> \t\tLOG(Debayer, Error)\n> @@ -511,10 +511,10 @@ void DebayerEGL::debayerGPU(MappedFrameBuffer &in, MappedFrameBuffer &out, Debay\n> \n> \t// Populate bayer parameters\n> \tif (ccmEnabled_) {\n> -\t\tGLfloat ccm[] = {\n> -\t\t\t1, 0, 0,\n> -\t\t\t0, 1, 0,\n> -\t\t\t0, 0, 1,\n> +\t\tGLfloat ccm[9] = {\n> +\t\t\tparams.ccm[0][0], params.ccm[0][1], params.ccm[0][2],\n> +\t\t\tparams.ccm[1][0], params.ccm[1][1], params.ccm[1][2],\n> +\t\t\tparams.ccm[2][0], params.ccm[2][1], params.ccm[2][2],\n\nI thought there must be a /nicer/ way to get ccm from params.ccm.data()\nbut I couldn't find any.\n\nAnyway, waiting with my ack until the patches settle down a bit, to be\nsure the element ordering is correct.\n\n> \t\t};\n> \t\tglUniformMatrix3fv(ccmUniformDataIn_, 1, GL_FALSE, ccm);\n> \t} else {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC00AC3237\n\tfor ;\n\tWed, 18 Jun 2025 12:31:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F2C5168DC9;\n\tWed, 18 Jun 2025 14:31:12 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 14A1568DC1\n\tfor ;\n\tWed, 18 Jun 2025 14:31:10 +0200 (CEST)","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n\t[209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-352-yUtOuZYOOWaNRUw22y2HRg-1; Wed, 18 Jun 2025 08:31:08 -0400","by mail-wm1-f69.google.com with SMTP id\n\t5b1f17b1804b1-450db029f2aso31958035e9.3\n\tfor ;\n\tWed, 18 Jun 2025 05:31:08 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4533fa7a9a8sm138623765e9.23.2025.06.18.05.31.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 18 Jun 2025 05:31:05 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"YEz9M6Ya\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1750249870;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=uJ2Bz+9+e8Aq0GKc8o7C74tljI+sqL3FwC8jjM3G7j4=;\n\tb=YEz9M6Ya+k8CWMhF4eFRhsRvP0sRqiP4O/F5o6r5qTB4CYRyl+WvsSYLuDq1pRV1wUvQ1o\n\tq6AXvzxIbVjjqGURCry36ZIASZLknLVjUp0uTDKz4KbxV2rK7IE/SZMVIv8qE4BrygvyVU\n\tTLobKujrlZZtzH2U+QHXaN5bydcrH/w=","X-MC-Unique":"yUtOuZYOOWaNRUw22y2HRg-1","X-Mimecast-MFC-AGG-ID":"yUtOuZYOOWaNRUw22y2HRg_1750249867","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1750249866; x=1750854666;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=uJ2Bz+9+e8Aq0GKc8o7C74tljI+sqL3FwC8jjM3G7j4=;\n\tb=j6T0XG+b5QqD/4bNLrr5Lu/B3jhvHWQzLUL/0VqJNc/8RYDQ/1aaZfqXcA6pSNwx9G\n\tMFUUOHZPSFeUQDcnRcLVK3RcQMugSxgCM/EYCB9w6C1x+gRz07zBezHKS48yrWPDn2u8\n\tz9TH4VpSg3d2Wdvj9OwWF3BG/fb86gdpp3Or1m7WgjtLoOR0GEfmfh2k78K7fO+v6se+\n\tgJaWpFilFtwczslCvIWvI/FqswuBqLmCLLd20DCRqgVODi7TSUCxKoJ4ZyTf5L8FFQdO\n\tyycP8C7A2+VUlKYx7itGzBL4TtStIMEee/PfAI7Bfejnjl1HImQc0rimCv7cpESNjrlv\n\toALA==","X-Gm-Message-State":"AOJu0YwXpdxRrA/oprePofmoGUUoNFuRN3EV66hjAbiJvvolk50OdakY\n\tYNcNl76lKUDI3hhRWCV4D0HbwePeawoWyWHUME1TQrvxVk/24AARduYQ+lnXNlWbzsIhK1FzsuW\n\t+D1l3YdVmlBj/A8wNK/QbT+g7bzul67UbbYgX0j6MjAQ9P2sUkvmCkNaHogGlN+zZ1JyM05VqYo\n\tanLFG8DVyS/FDztSssipiOUkIhc/l1Yp09R+1om6TDl7OkZRl8e7ZWBnc2b+w=","X-Gm-Gg":"ASbGncsWSIeNob58kKI2fGR6c5LNDNL+oG6bYM0QPKWA2HKKEKxv+dN/7rikEuBtMKJ\n\tv2Ta7JZWOTu5zqo4e9A2MbIRVYeEqJM0uR/6R08FY0KESgBMWp4qgHrMzPuVdcEDJVvk/ut5ynL\n\tZCUESO5WxCzArfGmnkQcmEM6ZpTinGPbp9M5auNM7S9nuRezUgZx/Ekza2oKMEGB1kIe4ebjvNo\n\tjN51kXluJv/oL4jWPrSoraaMeXGbrSLdofxqKUoVzZF9TThlGHrjN2ixEv6Jhg160/R5/IKfmJ+\n\toRVGxtGTIIxYXSC/GN6pkx+FTguuiITRnN4hixPFQVr/0US3xPiSK4NLBAflSeiizv48g009G9o\n\t=","X-Received":["by 2002:a05:600c:3f07:b0:442:f4a3:b5ec with SMTP id\n\t5b1f17b1804b1-4533ca7a34bmr175500105e9.4.1750249866365; \n\tWed, 18 Jun 2025 05:31:06 -0700 (PDT)","by 2002:a05:600c:3f07:b0:442:f4a3:b5ec with SMTP id\n\t5b1f17b1804b1-4533ca7a34bmr175499625e9.4.1750249865877; \n\tWed, 18 Jun 2025 05:31:05 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IEYkXttw8wvSy50UjetZPee+0X++BqPodJ58vyXEmtSz7sJTQwXO2TAOSgcKNhbP5yzPvg0Cg==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 27/35] libcamera: software_isp: debayer_egl: Convert\n\tfrom identity CCM to CCM calculated by SoftIPA","In-Reply-To":"<20250611013245.133785-28-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Wed, 11 Jun 2025 02:32:37 +0100\")","References":"<20250611013245.133785-1-bryan.odonoghue@linaro.org>\n\t<20250611013245.133785-28-bryan.odonoghue@linaro.org>","Date":"Wed, 18 Jun 2025 14:31:04 +0200","Message-ID":"<85y0tpxmd3.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"w00z6-WMVdAfFSyW8EoZgtW_Cv7rsmvFgBf8fb9ZDBk_1750249867","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]