[{"id":34497,"web_url":"https://patchwork.libcamera.org/comment/34497/","msgid":"<4cef17a8-07ed-47a9-8821-0212ff41a8af@linaro.org>","date":"2025-06-16T19:26:48","subject":"Re: [PATCH 20/35] libcamera: software_isp: lut: Make gain corrected\n\tCCM in lut.cpp available in debayer params","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"content":"On 11/06/2025 02:32, Bryan O'Donoghue wrote:\n> There is another CCM calculated in this algorithm callback, this time based\n> on the LUT.\n> \n> Signed-off-by: Bryan O'Donoghue \n> ---\n> src/ipa/simple/algorithms/lut.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\n> index d1d5f727..a161adb1 100644\n> --- a/src/ipa/simple/algorithms/lut.cpp\n> +++ b/src/ipa/simple/algorithms/lut.cpp\n> @@ -126,6 +126,7 @@ void Lut::prepare(IPAContext &context,\n> \t\tauto &red = params->redCcm;\n> \t\tauto &green = params->greenCcm;\n> \t\tauto &blue = params->blueCcm;\n> +\t\tparams->ccm = ccm;\n\n\nPardon me, I copy/pasted my second reply to patch #19 which was meant \nfor patch #20.\n\nReposting here:\n\nPing Milan\n\nOr is this additional latch in lut relevant ?\n\nIts not 100% clear to me - I could trace the data inside of IPA or I\ncould just ask someone like you who knows the IPA code better.\n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 87CB7C3237\n\tfor ;\n\tMon, 16 Jun 2025 19:26:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BACB168DCF;\n\tMon, 16 Jun 2025 21:26:51 +0200 (CEST)","from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0CCC568DC0\n\tfor ;\n\tMon, 16 Jun 2025 21:26:50 +0200 (CEST)","by mail-wr1-x436.google.com with SMTP id\n\tffacd0b85a97d-3a375e72473so2776056f8f.0\n\tfor ;\n\tMon, 16 Jun 2025 12:26:49 -0700 (PDT)","from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-3a568a800d9sm11704290f8f.45.2025.06.16.12.26.48\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tMon, 16 Jun 2025 12:26:49 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"me4npJ9A\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1750102009; x=1750706809;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:to:subject:user-agent:mime-version:date:message-id:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=92EFbP1nk/QLISPgfyNonYqeSW0+ipkj73RuNo53N2U=;\n\tb=me4npJ9AOrjLImknyxUKEJMAvczdZ+mxAOdMU5ckL3yzLcw/4xtxOLo7qiIZ5XrlQs\n\t+SFxgDMsL5khXky2vMz/n+EVPULmAVvKF2we994Vm5ifVas552AT239SrGEIA3QyhJBc\n\tSiRLcoLC2njqNEd/+pqDaq+D6wSdZx0t3TrN0+7rq5rdiwIwj9ockG7/KYhkHrBc4g6S\n\tlsapaBmaQ5Otf3cO8CwVUBovGE/MAFp0M1ZWm+fUvAFvxzbk8FJWcTfPYsYVvfARlNMp\n\t4vLj6QpX7KuGGE3E6tC74dvrvxPMlHvwwbx/XNHzJuKTGyQ/vvKBzRxnloMGI/IFDgcF\n\t+oJA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1750102009; x=1750706809;\n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=92EFbP1nk/QLISPgfyNonYqeSW0+ipkj73RuNo53N2U=;\n\tb=AiTkD8dYow29vCc4gZ8+tEGG7Qd1d23ua0itgMGYeF2ChXDmOAJD9w84CK3W0Wnva9\n\tsomTSvIE+FO3BpIaxhjdEj8KjAaoOj7QeM1+b1SC5z2a7tYbT8AauE3iS94lsQ3M8N77\n\tdK80y1WEtuR4H6Yq+a+nwVuSY8jJN08ryXvh/+UK/cRHNPN/4Niy8xxhsyo5o0MvM6cJ\n\tz087GPiyNeOTk6qGho7+VQV8XJhJ8boj5eezId0ryoE0KNwDYiNXmNNBQCo2uL98osHg\n\tDDBkRVnzTYn+Zya2SsrObGBSnJRRQnmlYDQZgNJ4rzuj8qY/ePNTB+BjQnegh810VUF5\n\tcbIg==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCX3HjaX0deg35biiMTnonE2RqFE0h+AZq0JIwtlO0fOFqhMURxLvbtxY0uUUcjj0IqHbpOZMd8EZtSn3ZbCo/A=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YySJBM2DHetIe6Vr4xE16V4SDotmBG7EFhSt71dIPoKhpJLyMW5\n\t656VVsz/o/oG8prlFg0Coyul8UeAzLg50NwWFTPsz9dYjIusYr5xTCipGZbgWgaNwm8=","X-Gm-Gg":"ASbGnctIrqgc+hMDHptRF9Yze8S5aYCcxYd49r4gVLyqIOUtiLhciw1yU18GGrGNqgH\n\tZPHtYD0/vYxG0OxbfFTNtBz/vHp02iy1nhseBA79A1EbEwi4Nrf6teIjbK79osDRKinORXnL+l3\n\tMto6at7br3aO+8ApSxs5b53Hd7DiiPc2Mxdq8tu97CAjTh8UiK8e02JtYau642BHZqmnlrSabke\n\tBS+u0JJE8qJZHyM/o9CRwGM6vot3z7IQZ//n5lUXESwv95w2wM9FIs4zxZpkC8XBPgTacWdGbjc\n\tfxeF0ODZlbm2H5GP6LGWELzzPXRS/Zu0Ju1edQibaElT43SWRO7Ge9sevJQYlpZUeEhg4opTbsz\n\t8Au0QZqGNIa0x9ZUyEEhX7h8MbuM=","X-Google-Smtp-Source":"AGHT+IHhXoXfUEcjcdr05MhcmsK5meSEhQz4H3cbO59ynsqtmm16na+eCvoxhiIqp1nqiSvAgiwcDA==","X-Received":"by 2002:a05:6000:250c:b0:3a5:2cca:6054 with SMTP id\n\tffacd0b85a97d-3a572367c51mr9005755f8f.4.1750102009397; \n\tMon, 16 Jun 2025 12:26:49 -0700 (PDT)","Message-ID":"<4cef17a8-07ed-47a9-8821-0212ff41a8af@linaro.org>","Date":"Mon, 16 Jun 2025 20:26:48 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 20/35] libcamera: software_isp: lut: Make gain corrected\n\tCCM in lut.cpp available in debayer params","To":"Bryan O'Donoghue ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20250611013245.133785-1-bryan.odonoghue@linaro.org>\n\t\n\t<20250611013245.133785-21-bryan.odonoghue@linaro.org>","Content-Language":"en-US","From":"Bryan O'Donoghue ","In-Reply-To":"<20250611013245.133785-21-bryan.odonoghue@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34526,"web_url":"https://patchwork.libcamera.org/comment/34526/","msgid":"<85jz5aa2wd.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-06-17T13:55:30","subject":"Re: [PATCH 20/35] libcamera: software_isp: lut: Make gain corrected\n\tCCM in lut.cpp available in debayer params","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> There is another CCM calculated in this algorithm callback, this time based\n> on the LUT.\n\nThe commit message should be reworded if the preceding patch gets\ndropped; as for the change itself:\n\nReviewed-by: Milan Zamazal \n\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> src/ipa/simple/algorithms/lut.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\n> index d1d5f727..a161adb1 100644\n> --- a/src/ipa/simple/algorithms/lut.cpp\n> +++ b/src/ipa/simple/algorithms/lut.cpp\n> @@ -126,6 +126,7 @@ void Lut::prepare(IPAContext &context,\n> \t\tauto &red = params->redCcm;\n> \t\tauto &green = params->greenCcm;\n> \t\tauto &blue = params->blueCcm;\n> +\t\tparams->ccm = ccm;\n> \t\tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n> \t\t\tred[i].r = ccmValue(i, ccm[0][0]);\n> \t\t\tred[i].g = ccmValue(i, ccm[1][0]);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 89D39BDE6B\n\tfor ;\n\tTue, 17 Jun 2025 13:55:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D54FA68DC3;\n\tTue, 17 Jun 2025 15:55:37 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 706F068DB1\n\tfor ;\n\tTue, 17 Jun 2025 15:55:35 +0200 (CEST)","from mail-wr1-f70.google.com (mail-wr1-f70.google.com\n\t[209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-19-lH1W1Dj-MMGG3Zyrlsc3sA-1; Tue, 17 Jun 2025 09:55:33 -0400","by mail-wr1-f70.google.com with SMTP id\n\tffacd0b85a97d-3a5058f9ef4so1738729f8f.2\n\tfor ;\n\tTue, 17 Jun 2025 06:55:32 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb ([85.93.96.130])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4534226aa44sm105544075e9.13.2025.06.17.06.55.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 17 Jun 2025 06:55:30 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"izJQf+LY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1750168534;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=CZTp/ZZCPCx+lt5aFAkhe8q33KL6SNAyiTpD06dNZHw=;\n\tb=izJQf+LYTHh8zuKoc7dv3Vtn/1rYHmQAgAZe9By+C/M12Kk8mu92t6yhlRdtgB0aREuMAV\n\tnbcW1+Q1bGmGMlTvmg0jipBoa+gxnUz9J185EU57nfoeG2tASvyh6xSt9hsOx7pZsIgFHi\n\tiQMU9HqJVpLEqPji3y9SYKNsXFnCBeI=","X-MC-Unique":"lH1W1Dj-MMGG3Zyrlsc3sA-1","X-Mimecast-MFC-AGG-ID":"lH1W1Dj-MMGG3Zyrlsc3sA_1750168532","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1750168531; x=1750773331;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=CZTp/ZZCPCx+lt5aFAkhe8q33KL6SNAyiTpD06dNZHw=;\n\tb=Q5W2cXDEZCqQzGB8v/z+rLDD5TpGIABN0b6YxO0bMzdraCaNBxpWyE6CnCy6i0IeQl\n\t5ff1zqhExq0408BWOlBWBOdcDrNSgeG035r3/ac+ykpfwUU/cZboeYqTPYBZfxo/9xJS\n\t2U916cCXRoKlBDfwF3RQM0kiT1Xs8PI6+VNthmPtxHmSpnOGHdDr0wlKX7LysqSF1J06\n\tj6ai41HGCb+U6/xG8kcm1nn8URNdGtBA33Wf4gfDEgVvGXtatnG/pXgJ32mJ+sDmJN45\n\ta1L1YUpZ2GlnYbbhd9WL5dNDHRUoiUBXCvs17kWuGzPVswL2Ce4uSbKQntUGzpfJReu2\n\tzReA==","X-Gm-Message-State":"AOJu0YzeqJzaUEmuyehizk+6SlhxIr57oS+ar+IkP0YSG+zid9LPq6Fi\n\trmUT7og20PG0zyghfmTH5Cxo8Sus2V5WVkk9MVUPw/V2pQMRnN3xqZFzOXtA8bvc/uxVy5OzPSp\n\tPp2AWtlQPfOtnZ/Yi3Vq3wOnAXddD7rebsyHc2K4ekb6ZH4vu1uVYHUHYapg32tN79kWPxJLczm\n\to3QotpGofQlMNJmeUvdIpYVq1ANhG1sdgPslGpoj9FuUjszOoPHzTh5yUZvEo=","X-Gm-Gg":"ASbGncs9pcTIGxYu8OBP/dNa/iAjKUXRJ2M+Et6ZR1tmrnWzk016QcNcBg6lBbv4xOI\n\tCaFVqX6JDZjKr3AZ8AwPtHdh6RUXd2FBV6VDvVw/vuh5p7bB3sZOK9N9SPilvbjU2A+uHTJZAE7\n\tlhdWdWsiDSAPCzLQplStQr2OVu7O4tctBikp6PBSpbAMBjyYcb224FTY0d/Lyf5lPEmOcXQWO1F\n\tDCLeRq6WoUQFxVP5NNNNybdXrI8kecC+eOH0OlO/6z9FVKVWsbpU1vMfqt9wPsdQttNKs4nzdNP\n\tHToAEKnvSmkAGD4QXD1HkhLP/VpjqBTCXzaWEptd8TVpFvY=","X-Received":["by 2002:a05:6000:250c:b0:3a3:648e:1b74 with SMTP id\n\tffacd0b85a97d-3a572367b97mr11001109f8f.6.1750168531567; \n\tTue, 17 Jun 2025 06:55:31 -0700 (PDT)","by 2002:a05:6000:250c:b0:3a3:648e:1b74 with SMTP id\n\tffacd0b85a97d-3a572367b97mr11001078f8f.6.1750168531134; \n\tTue, 17 Jun 2025 06:55:31 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IFu6JWISkMrATc55Pk0O8urlvYtLkwvDiWd0IDtTv+OSYTx3oIWgltReekuXQkjnSHhWdmg2A==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 20/35] libcamera: software_isp: lut: Make gain corrected\n\tCCM in lut.cpp available in debayer params","In-Reply-To":"<20250611013245.133785-21-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Wed, 11 Jun 2025 02:32:30 +0100\")","References":"<20250611013245.133785-1-bryan.odonoghue@linaro.org>\n\t<20250611013245.133785-21-bryan.odonoghue@linaro.org>","Date":"Tue, 17 Jun 2025 15:55:30 +0200","Message-ID":"<85jz5aa2wd.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"j6aHwFlJsBp4RRE_Py2d-VMqqtpDM8LmXZVIjr_E3EQ_1750168532","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]