[{"id":34512,"web_url":"https://patchwork.libcamera.org/comment/34512/","msgid":"<858qlqbnrl.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-06-17T11:39:26","subject":"Re: [PATCH 15/35] libcamera: software_isp: debayer: Extend\n\tDebayerParams struct to hold a copy of per-frame CCM values","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Bryan,\n\nBryan O'Donoghue writes:\n\n> Add an element to the DebayerParams structure to capture the calculated\n> CCM. This allows us to pass the CCM into the eGL Debayer shader later on.\n>\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> include/libcamera/internal/software_isp/debayer_params.h | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\n> index 217cd5d9..56803195 100644\n> --- a/include/libcamera/internal/software_isp/debayer_params.h\n> +++ b/include/libcamera/internal/software_isp/debayer_params.h\n> @@ -13,6 +13,8 @@\n> #include \n> #include \n> \n> +#include \"libcamera/internal/matrix.h\"\n> +\n> namespace libcamera {\n> \n> struct DebayerParams {\n> @@ -49,6 +51,11 @@ struct DebayerParams {\n> \tCcmLookupTable greenCcm;\n> \tCcmLookupTable blueCcm;\n> \tLookupTable gammaLut;\n> +\n> +\t/*\n> +\t * Per frame CCM values as calcualted by the IPA\n\ns/calcualted/calculated/\n\nAnd I think a one line comment can/should be formatted as\n\n /* ... */\n\nWith this fixed:\n\nReviewed-by: Milan Zamazal \n\n> +\t */\n> +\tMatrix ccm;\n> };\n> \n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE3EFBDE6B\n\tfor ;\n\tTue, 17 Jun 2025 11:39:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A32668DD2;\n\tTue, 17 Jun 2025 13:39:34 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 038EF68DCD\n\tfor ;\n\tTue, 17 Jun 2025 13:39:31 +0200 (CEST)","from mail-wr1-f72.google.com (mail-wr1-f72.google.com\n\t[209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-266-h8xYCxvSNtGV_HK82fBiMg-1; Tue, 17 Jun 2025 07:39:29 -0400","by mail-wr1-f72.google.com with SMTP id\n\tffacd0b85a97d-3a578958000so1059131f8f.3\n\tfor ;\n\tTue, 17 Jun 2025 04:39:29 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb ([85.93.96.130])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-3a568b7431esm14034978f8f.97.2025.06.17.04.39.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 17 Jun 2025 04:39:26 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"HkzzOcqK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1750160370;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=aK7oWSqAw+jPna5Ys9pyhGWi33qgSFClUbDz4kLpfj4=;\n\tb=HkzzOcqKdF9W6Agpf5bNlWJTUIpPtOr0K0wAzO5xWvuRgc3BdApLhrRmFZU71GBrLVekaE\n\tB8PiGBPT16Xr4yErLRVSYd/6zUmh/iTU/duUIamDh2oqHo4WNhStVrnDZ/Vr3zKeMX4/Zj\n\tSQMnyAIMeYSaMRFBWiU6UiBPfDRp2Is=","X-MC-Unique":"h8xYCxvSNtGV_HK82fBiMg-1","X-Mimecast-MFC-AGG-ID":"h8xYCxvSNtGV_HK82fBiMg_1750160368","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1750160368; x=1750765168;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=aK7oWSqAw+jPna5Ys9pyhGWi33qgSFClUbDz4kLpfj4=;\n\tb=avkGTQaV53tqAXpIiSQduOORkI9Yk4KC79I/xCNWnGGWuGKYYtDQyLo2qUh87lGSq/\n\tLTvM1EBiOoHIu98YCQjSf2AWqViXRwBHcwnfQrm0fvEf2y/DbjmApcBVCjb3fXAszZ27\n\t0WTmmyLz0It+89zTRJGOLRMIRwUKWASez4DuF3sg3L3a1ffj77kcWvvk5siufdUOYCYf\n\t7IXZoxYRBom/ctolUgzYXO3IUUPJP9a1lpAuast9FG3+60ksfBixJ9cvLXEcBqNzNzgB\n\tKOjHcpNAMIKZlEJAdWLPs3jFK7MSdxzILwEg1LfOrn04oiQVmNyXp0ujA7ok0eQc3T4I\n\tlntg==","X-Gm-Message-State":"AOJu0YxodRWlyT7HKXSnhiY6pmSimBO/+/0wGdOQS/cTRXcKfSxideVq\n\tphH0BovG51ty5GX+Bz5rRDeV/Nwq4wLXcLBQ8g1QOzmBdAeF1bZQEiVBrOm7XODoGai3IezHoJn\n\tYPjaP16iOM3tEnHOe9pzwg/N0G1uIxPXMSpd0SL5fx+EHrjspfCgqZw7XXZaxuTXtJBd062lYj7\n\tWqxoed/hwE6iHi4Y4qxSAmr5NBQd3yjOk36OPZ8CDdNk2j3XpnEPjVNk0X43o=","X-Gm-Gg":"ASbGncutn/W8i1Pi0kZp/nIwAR8VXPmAAl+mJJwkR+CGlxbLZsLk62KS1cM3ZHE5feQ\n\t+VFYA689jmWL+p+3FPTvMTpDvhiwEjzprUZECdIt0kQywznqBLUB3+bob6BAeClB3QP/sPilw4o\n\tSpuwgJotvAr3GFzP89uCXHqai0sGZctqauzHViArzX2cUqBdcQ1Qy39smovlme4gKKxBjl2j0Oa\n\tyiXc/IvrmYvDgeeV/O2Lwk9S2wY+piP3puqBqLYhx8yL9CcI/Q7qYmXXWQAHX7pnDE5c5mvvDzI\n\tGPUCqou2HS3Ht5pHlEdeP48XqanIIDSzcFCjflfeZ/UK9Ec=","X-Received":["by 2002:a05:6000:711:b0:3a5:27ba:47a8 with SMTP id\n\tffacd0b85a97d-3a572e99895mr10046636f8f.52.1750160367927; \n\tTue, 17 Jun 2025 04:39:27 -0700 (PDT)","by 2002:a05:6000:711:b0:3a5:27ba:47a8 with SMTP id\n\tffacd0b85a97d-3a572e99895mr10046611f8f.52.1750160367416; \n\tTue, 17 Jun 2025 04:39:27 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IEp7NInSUo3kGBF12Gf50xTOnB7WN1h+nNH725xLc9o/tqcTUEFV6N4YjqIUKpQ0R4ODEbUuA==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 15/35] libcamera: software_isp: debayer: Extend\n\tDebayerParams struct to hold a copy of per-frame CCM values","In-Reply-To":"<20250611013245.133785-16-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Wed, 11 Jun 2025 02:32:25 +0100\")","References":"<20250611013245.133785-1-bryan.odonoghue@linaro.org>\n\t<20250611013245.133785-16-bryan.odonoghue@linaro.org>","Date":"Tue, 17 Jun 2025 13:39:26 +0200","Message-ID":"<858qlqbnrl.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"TwehaSK61SgS8F9cRzq2cKy9PuuRlgxLgCk9YYJ5IFw_1750160368","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]