[{"id":34509,"web_url":"https://patchwork.libcamera.org/comment/34509/","msgid":"<85cyb2boaq.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-06-17T11:27:57","subject":"Re: [PATCH 14/35] libcamera: software_isp: debayer: Make the\n\tdebayer_ object of type class Debayer not DebayerCpu","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> Make the type of object Debayer not DebayerCpu thus allowing us to assign\n> the object to either DebayerCpu or DebayerEGL.\n>\n> Signed-off-by: Bryan O'Donoghue \n\nReviewed-by: Milan Zamazal \n\n> ---\n> include/libcamera/internal/software_isp/software_isp.h | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n>\n> diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\n> index 78624659..ad89c9b3 100644\n> --- a/include/libcamera/internal/software_isp/software_isp.h\n> +++ b/include/libcamera/internal/software_isp/software_isp.h\n> @@ -37,7 +37,7 @@\n> \n> namespace libcamera {\n> \n> -class DebayerCpu;\n> +class Debayer;\n> class FrameBuffer;\n> class PixelFormat;\n> class Stream;\n> @@ -94,8 +94,7 @@ private:\n> \tvoid statsReady(uint32_t frame, uint32_t bufferId);\n> \tvoid inputReady(FrameBuffer *input);\n> \tvoid outputReady(FrameBuffer *output);\n> -\n> -\tstd::unique_ptr debayer_;\n> +\tstd::unique_ptr debayer_;\n> \tThread ispWorkerThread_;\n> \tSharedMemObject sharedParams_;\n> \tDebayerParams debayerParams_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC290C3237\n\tfor ;\n\tTue, 17 Jun 2025 11:28:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6DDD768DC3;\n\tTue, 17 Jun 2025 13:28:05 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E82568DC3\n\tfor ;\n\tTue, 17 Jun 2025 13:28:03 +0200 (CEST)","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n\t[209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-436-ekQoO4agMRuFzegSSqJyVA-1; Tue, 17 Jun 2025 07:28:00 -0400","by mail-wr1-f71.google.com with SMTP id\n\tffacd0b85a97d-3a4f85f31d9so2158096f8f.1\n\tfor ;\n\tTue, 17 Jun 2025 04:28:00 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb ([85.93.96.130])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4532e13cfbesm174262615e9.22.2025.06.17.04.27.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 17 Jun 2025 04:27:58 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"XHs6ACTn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1750159682;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Uo6ZGdMU8uoBYE9FQQc3oOB/HDo/npohZV+Ax3bGrw0=;\n\tb=XHs6ACTnQINFomGr9/BD5ZMlHT22nN7Wyyj7gVsYvzys3pajkM6Kpxy8lCZkiq2cI/Gupt\n\tzPqUPoUWh86a9D0skfl1bwD0oUO/4c0pdZzwD4uD20DkWVegMN1KVzZVrKHom7w+2qnUpy\n\tT2alo7TAMpou9DptOxpqTHNdXiJzVq8=","X-MC-Unique":"ekQoO4agMRuFzegSSqJyVA-1","X-Mimecast-MFC-AGG-ID":"ekQoO4agMRuFzegSSqJyVA_1750159680","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1750159679; x=1750764479;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Uo6ZGdMU8uoBYE9FQQc3oOB/HDo/npohZV+Ax3bGrw0=;\n\tb=NqkPdptSqelqBKaNKifimewMEI5ZbTcnggYPQmOGr6lxGS3oC7Xkbi9WP1PKE4/oFV\n\tEm2E4xCHJr3ek1KSKx802asRVHwPdY7aRjThN73EKzvVX+u8BnulxQJ1phTYc8RRrvn4\n\tE1JUUSfujJ5YuneTD+EXkqHNbese4WiyG7P85aMW2k3CrO9AeGZhiw2EBX2ugezR1K85\n\tIJqQokY6ecPiORlnYuh1dX1Qp1nQ8N+80H23nnB72mIQPKdSjfm6G7yzMbfXiFwdY5JL\n\ttDiJ1MVjT+Bb3vgiTIzNsmG0VA5RrIJ77KsICr2jxz4l/ZWGwTJF6j+2ccn3F9BGrcNN\n\tQaVg==","X-Gm-Message-State":"AOJu0YwUTLtUXWVqMC/+ULJ4OqyQT2TR8XSY2cy6pQtdq+BwT/7BspVI\n\tCkS9fYP1oqN1+iira/I5JkTAlhsaZQASX7FokKqtmdS0cvruB2DUryanlYr2D6mPpcVXAzIcASV\n\ta90BOYTwBXjTIyOFhJmTOua7hqhURwYJ92aP3ZBKIpSvbNxYACrp6tyhaag/J5k3hJBuhrmYyeO\n\tecWPrFn6u003fJ5HiFh+GWVjP1Xj03fX1Exd3wMjE5w4OKVA0aLhjpIPMOFAk=","X-Gm-Gg":"ASbGncvADdet8rApZn8ZLJFVV0UvA2tkj2FyGAksHbO+uK2SI8WCRFjXc+qZIWSWEZI\n\tRMi5y8VMkN4FFIBoags4e1QOPjABDuUeXfR/JHV1L/K6CLr3j97eeiR8/LfJFB4RGuSyCo8n4KX\n\toqL7/I9HjN0vqC1jr+LR2/hozUP3DRDY40E3GEVY8RNya0OGNLyDC7zC8ChE08nYNA/+PTIy1Qr\n\tg7HLKnZ0et3O9IKRFtPAlczd4bi1eMTHioDAqRwoawfdng5GtMlIPVl/++9Y/Q9meZcknpz621a\n\tfZLmBqxghL+DbVXxtyaGWdSDZ6EMwPmzX0LW6Zv4RI0H3w4=","X-Received":["by 2002:a05:6000:1887:b0:3a4:ec32:e4da with SMTP id\n\tffacd0b85a97d-3a5723a17fbmr11620934f8f.15.1750159679129; \n\tTue, 17 Jun 2025 04:27:59 -0700 (PDT)","by 2002:a05:6000:1887:b0:3a4:ec32:e4da with SMTP id\n\tffacd0b85a97d-3a5723a17fbmr11620911f8f.15.1750159678711; \n\tTue, 17 Jun 2025 04:27:58 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IENslWloB6zu1LPY9h8YYPnp0qh5Ciz/uKDbaTkBzW/NfgL/PQpsQSLUudo2/5G9MzIw54E1A==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 14/35] libcamera: software_isp: debayer: Make the\n\tdebayer_ object of type class Debayer not DebayerCpu","In-Reply-To":"<20250611013245.133785-15-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Wed, 11 Jun 2025 02:32:24 +0100\")","References":"<20250611013245.133785-1-bryan.odonoghue@linaro.org>\n\t<20250611013245.133785-15-bryan.odonoghue@linaro.org>","Date":"Tue, 17 Jun 2025 13:27:57 +0200","Message-ID":"<85cyb2boaq.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"0yTRH3TTpDBA77_3sRW0x2hqLmMo0vMPLWXaruXrf48_1750159680","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]