[{"id":34480,"web_url":"https://patchwork.libcamera.org/comment/34480/","msgid":"<85wm9bk1ez.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-06-16T18:05:08","subject":"Re: [PATCH 09/35] libcamera: software_isp: Move Bayer parans init\n\tfrom DebayerCpu to Debayer","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Bryan,\n\nin the subject: s/parans/params/\n\nBryan O'Donoghue <bryan.odonoghue@linaro.org> writes:\n\n> Move the initialisation of Bayer params and CCM to a new constructor in the\n> Debayer class.\n>\n> Ensure we call the base class constructor from DebayerCpu's constructor in\n> the expected constructor order Debayer then DebayerCpu.\n\nOh, is it otherwise by default?  How about Object's constructor then\n(before and after)?\n\n> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n> ---\n>  src/libcamera/software_isp/debayer.cpp     | 11 +++++++++++\n>  src/libcamera/software_isp/debayer.h       |  1 +\n>  src/libcamera/software_isp/debayer_cpu.cpp | 10 +---------\n>  3 files changed, 13 insertions(+), 9 deletions(-)\n>\n> diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\n> index e9e18c48..29fdcbbf 100644\n> --- a/src/libcamera/software_isp/debayer.cpp\n> +++ b/src/libcamera/software_isp/debayer.cpp\n> @@ -103,6 +103,17 @@ namespace libcamera {\n>  \n>  LOG_DEFINE_CATEGORY(Debayer)\n>  \n> +Debayer::Debayer()\n> +{\n> +\t/* Initialize color lookup tables */\n> +\tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n> +\t\tred_[i] = green_[i] = blue_[i] = i;\n> +\t\tredCcm_[i] = { static_cast<int16_t>(i), 0, 0 };\n> +\t\tgreenCcm_[i] = { 0, static_cast<int16_t>(i), 0 };\n> +\t\tblueCcm_[i] = { 0, 0, static_cast<int16_t>(i) };\n> +\t}\n> +}\n> +\n>  Debayer::~Debayer()\n>  {\n>  }\n> diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\n> index 45da822a..01b6e916 100644\n> --- a/src/libcamera/software_isp/debayer.h\n> +++ b/src/libcamera/software_isp/debayer.h\n> @@ -32,6 +32,7 @@ LOG_DECLARE_CATEGORY(Debayer)\n>  class Debayer : public Object\n>  {\n>  public:\n> +\tDebayer();\n>  \tvirtual ~Debayer() = 0;\n>  \n>  \tvirtual int configure(const StreamConfiguration &inputCfg,\n> diff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\n> index 8d30bf4a..13db8a8c 100644\n> --- a/src/libcamera/software_isp/debayer_cpu.cpp\n> +++ b/src/libcamera/software_isp/debayer_cpu.cpp\n> @@ -40,7 +40,7 @@ namespace libcamera {\n>   * \\param[in] stats Pointer to the stats object to use\n>   */\n>  DebayerCpu::DebayerCpu(std::unique_ptr<SwStatsCpu> stats)\n> -\t: stats_(std::move(stats))\n> +\t: Debayer(), stats_(std::move(stats))\n>  {\n>  \t/*\n>  \t * Reading from uncached buffers may be very slow.\n> @@ -51,14 +51,6 @@ DebayerCpu::DebayerCpu(std::unique_ptr<SwStatsCpu> stats)\n>  \t * future.\n>  \t */\n>  \tenableInputMemcpy_ = true;\n> -\n> -\t/* Initialize color lookup tables */\n> -\tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n> -\t\tred_[i] = green_[i] = blue_[i] = i;\n> -\t\tredCcm_[i] = { static_cast<int16_t>(i), 0, 0 };\n> -\t\tgreenCcm_[i] = { 0, static_cast<int16_t>(i), 0 };\n> -\t\tblueCcm_[i] = { 0, 0, static_cast<int16_t>(i) };\n> -\t}\n>  }\n>  \n>  DebayerCpu::~DebayerCpu() = default;","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5C0D5BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 16 Jun 2025 18:05:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2959368DC0;\n\tMon, 16 Jun 2025 20:05:17 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE6B268DC0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Jun 2025 20:05:15 +0200 (CEST)","from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n\t[209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-335-BPZv3qXtPTG-z82KWi6X0Q-1; Mon, 16 Jun 2025 14:05:13 -0400","by mail-wm1-f71.google.com with SMTP id\n\t5b1f17b1804b1-45334219311so17768475e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Jun 2025 11:05:13 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4532e25f207sm150715615e9.35.2025.06.16.11.05.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 16 Jun 2025 11:05:10 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"KvJM9RzM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1750097114;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=ytlIZZN1867CefiN2agutcp4+LqStN6VkDux3lH4/9A=;\n\tb=KvJM9RzMnhrXunoXO5tM3e1MVQQhAV+el2Vt+n60UikxznmQjp3QYwdZdjSA2E1W96rG+0\n\tKsVH/DGyWonU25OnhmCDnRcAitiK3ktyF3ochLdp1PxuincPVs9tBEpem0HzKgEq02itd8\n\tKwcBNsEalzEcz23XrzFpx4xXU6IHygQ=","X-MC-Unique":"BPZv3qXtPTG-z82KWi6X0Q-1","X-Mimecast-MFC-AGG-ID":"BPZv3qXtPTG-z82KWi6X0Q_1750097112","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1750097112; x=1750701912;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=ytlIZZN1867CefiN2agutcp4+LqStN6VkDux3lH4/9A=;\n\tb=gNmOAMcGBhCTXszUYqP/+yyVF6+1SQBD9/f7CPq/JDkleAtydGQrqs+nunr7nMnKJ8\n\t/DZ93iI1BNxm5kNIjDuSgHTHmf4yD12T6OaDgNfIRfyvsAmgXhgob6f1QaHsRzFk44tE\n\tAg+YGPmz7ic3QAfsiaadRt9tP/h6ywrc3RJueoVgqslLhSvz+IB0NuHzULYXIV5D/Wya\n\tkkEmP2WToZxtG/hYxFN1OK2+LK689auIWjWiqfCv4WI0lPhnRob+9ZtjKJKs4dYRvgl2\n\tGkjZ4pHEZIBGlrK22TlUP10RsoixpBqt0yk82T2wnQiLoMdZGHO3VoTvHaNgpzZpL8fU\n\t/65A==","X-Gm-Message-State":"AOJu0YxfYz6PLlEzbaL32LETsniDzNntfjpveRzLluLG4Btex9GaiRu1\n\tKINIrzKvEzw+bYzeVPkwnIrDodPZDqYBKCyDIjNuapN8OV8sDLtCAq0BPwWC967EPzx88G2opn6\n\tlVEEAQao3zPe7W7iz6IlUYTnT4WdN5COUvaZnW1GmEpvupWnOYvLwpO70wbLnuLX2Sr+mVTTGEe\n\t0LJegK9IwlZ0fxjEcMslVNpdzhZ1Lfv6GOfFhp/RqtjWKiS0bPv+yr1sgEsGw=","X-Gm-Gg":"ASbGncsPEIaD5YdFrEFqVcLx/w+yWdFnByEhxCpghp5ImnGCzHtptCgWF48ZmlNznBG\n\tDhceSGuOZbh74BAEV6zkRNvEGZb1e1IUpKB2jQcNuqgMl8gae++J1i8jdPMmEpf69xdnyHbx/OH\n\toQ5IjaNDkFfNmQffD1ADoS2Mac4Grxq5OBNgW6/nvR6giJc8EQ6Bk9tOxd3cVdcAnHg4bjiu1ze\n\tZv+7QfWP7mLVGcVyKK9HmtGNlU7D3o2SMtH9Rf0C4a/cbMifGHFkxsfZgyG8h5mQ/B5dcp+sO3L\n\t9espC9KTqCzxLxbhhorIaXMrqipu5iBBJlcX45K2qORbZqUiB/YGXRFmrjGfXNaFcJDXeQiw04w\n\t=","X-Received":["by 2002:a05:600c:1d01:b0:442:ccf9:e6f2 with SMTP id\n\t5b1f17b1804b1-4533caa6bb6mr97424335e9.16.1750097111617; \n\tMon, 16 Jun 2025 11:05:11 -0700 (PDT)","by 2002:a05:600c:1d01:b0:442:ccf9:e6f2 with SMTP id\n\t5b1f17b1804b1-4533caa6bb6mr97424005e9.16.1750097111174; \n\tMon, 16 Jun 2025 11:05:11 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IGuXJSKrGTTIfmQV+5sRwoADhxDFNjhpLdUTrglDvfP93GTEbOM8zUx6VXdjshvuB/iU5MB8Q==","From":"Milan Zamazal <mzamazal@redhat.com>","To":"Bryan O'Donoghue <bryan.odonoghue@linaro.org>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 09/35] libcamera: software_isp: Move Bayer parans init\n\tfrom DebayerCpu to Debayer","In-Reply-To":"<20250611013245.133785-10-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Wed, 11 Jun 2025 02:32:19 +0100\")","References":"<20250611013245.133785-1-bryan.odonoghue@linaro.org>\n\t<20250611013245.133785-10-bryan.odonoghue@linaro.org>","Date":"Mon, 16 Jun 2025 20:05:08 +0200","Message-ID":"<85wm9bk1ez.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"c3IrRtdk_MWfef7qFu_GOyvs6y0Cxq44kmcNpwkDyMY_1750097112","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":34511,"web_url":"https://patchwork.libcamera.org/comment/34511/","msgid":"<3497db4c-196d-466b-8760-e9703c31c159@ideasonboard.com>","date":"2025-06-17T11:37:03","subject":"Re: [PATCH 09/35] libcamera: software_isp: Move Bayer parans init\n\tfrom DebayerCpu to Debayer","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 06. 16. 20:05 keltezéssel, Milan Zamazal írta:\n> Hi Bryan,\n> \n> in the subject: s/parans/params/\n> \n> Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes:\n> \n>> Move the initialisation of Bayer params and CCM to a new constructor in the\n>> Debayer class.\n>>\n>> Ensure we call the base class constructor from DebayerCpu's constructor in\n>> the expected constructor order Debayer then DebayerCpu.\n> > Oh, is it otherwise by default?  How about Object's constructor then\n> (before and after)?\n\nThe addition of the call to `Debayer()` should not be needed.\nIs there a compiler warning or something else?\n\n\nRegards,\nBarnabás Pőcze\n\n\n> \n>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n>> ---\n>>   src/libcamera/software_isp/debayer.cpp     | 11 +++++++++++\n>>   src/libcamera/software_isp/debayer.h       |  1 +\n>>   src/libcamera/software_isp/debayer_cpu.cpp | 10 +---------\n>>   3 files changed, 13 insertions(+), 9 deletions(-)\n>>\n>> diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\n>> index e9e18c48..29fdcbbf 100644\n>> --- a/src/libcamera/software_isp/debayer.cpp\n>> +++ b/src/libcamera/software_isp/debayer.cpp\n>> @@ -103,6 +103,17 @@ namespace libcamera {\n>>   \n>>   LOG_DEFINE_CATEGORY(Debayer)\n>>   \n>> +Debayer::Debayer()\n>> +{\n>> +\t/* Initialize color lookup tables */\n>> +\tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n>> +\t\tred_[i] = green_[i] = blue_[i] = i;\n>> +\t\tredCcm_[i] = { static_cast<int16_t>(i), 0, 0 };\n>> +\t\tgreenCcm_[i] = { 0, static_cast<int16_t>(i), 0 };\n>> +\t\tblueCcm_[i] = { 0, 0, static_cast<int16_t>(i) };\n>> +\t}\n>> +}\n>> +\n>>   Debayer::~Debayer()\n>>   {\n>>   }\n>> diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\n>> index 45da822a..01b6e916 100644\n>> --- a/src/libcamera/software_isp/debayer.h\n>> +++ b/src/libcamera/software_isp/debayer.h\n>> @@ -32,6 +32,7 @@ LOG_DECLARE_CATEGORY(Debayer)\n>>   class Debayer : public Object\n>>   {\n>>   public:\n>> +\tDebayer();\n>>   \tvirtual ~Debayer() = 0;\n>>   \n>>   \tvirtual int configure(const StreamConfiguration &inputCfg,\n>> diff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\n>> index 8d30bf4a..13db8a8c 100644\n>> --- a/src/libcamera/software_isp/debayer_cpu.cpp\n>> +++ b/src/libcamera/software_isp/debayer_cpu.cpp\n>> @@ -40,7 +40,7 @@ namespace libcamera {\n>>    * \\param[in] stats Pointer to the stats object to use\n>>    */\n>>   DebayerCpu::DebayerCpu(std::unique_ptr<SwStatsCpu> stats)\n>> -\t: stats_(std::move(stats))\n>> +\t: Debayer(), stats_(std::move(stats))\n>>   {\n>>   \t/*\n>>   \t * Reading from uncached buffers may be very slow.\n>> @@ -51,14 +51,6 @@ DebayerCpu::DebayerCpu(std::unique_ptr<SwStatsCpu> stats)\n>>   \t * future.\n>>   \t */\n>>   \tenableInputMemcpy_ = true;\n>> -\n>> -\t/* Initialize color lookup tables */\n>> -\tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n>> -\t\tred_[i] = green_[i] = blue_[i] = i;\n>> -\t\tredCcm_[i] = { static_cast<int16_t>(i), 0, 0 };\n>> -\t\tgreenCcm_[i] = { 0, static_cast<int16_t>(i), 0 };\n>> -\t\tblueCcm_[i] = { 0, 0, static_cast<int16_t>(i) };\n>> -\t}\n>>   }\n>>   \n>>   DebayerCpu::~DebayerCpu() = default;\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B721BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 17 Jun 2025 11:37:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 54D3068DD2;\n\tTue, 17 Jun 2025 13:37:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 67B5868DCD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 17 Jun 2025 13:37:07 +0200 (CEST)","from [192.168.33.11] (185.221.143.107.nat.pool.zt.hu\n\t[185.221.143.107])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE7A8666;\n\tTue, 17 Jun 2025 13:36:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ueAkB/nl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1750160215;\n\tbh=XlWp+HMORydntYkkdJoChtXxnGWmw01MHzLxeW+09kc=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=ueAkB/nlHC/JexiwkGhza4oBxuqgnfCIrhzFJ5LGPyCQlUpqE3wdZHDco2OsnjZeR\n\t0/nSzJeizaHbHh38vYA0F8WsBXyda9ZMyw+pLXDwjb4Pd/lRiM5B+cWbnGd4UdYQxX\n\tMjqJBAIR9RQeyT3sdGbGixNHaAf1hptbOkoBbCeA=","Message-ID":"<3497db4c-196d-466b-8760-e9703c31c159@ideasonboard.com>","Date":"Tue, 17 Jun 2025 13:37:03 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 09/35] libcamera: software_isp: Move Bayer parans init\n\tfrom DebayerCpu to Debayer","To":"Milan Zamazal <mzamazal@redhat.com>,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>","Cc":"libcamera-devel@lists.libcamera.org","References":"<20250611013245.133785-1-bryan.odonoghue@linaro.org>\n\t<20250611013245.133785-10-bryan.odonoghue@linaro.org>\n\t<85wm9bk1ez.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<85wm9bk1ez.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":34513,"web_url":"https://patchwork.libcamera.org/comment/34513/","msgid":"<eff07c2c-828d-437a-91e1-107d68dcc337@linaro.org>","date":"2025-06-17T11:42:24","subject":"Re: [PATCH 09/35] libcamera: software_isp: Move Bayer parans init\n\tfrom DebayerCpu to Debayer","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"content":"On 17/06/2025 12:37, Barnabás Pőcze wrote:\n>>>\n>> > Oh, is it otherwise by default?  How about Object's constructor then\n>> (before and after)?\n> \n> The addition of the call to `Debayer()` should not be needed.\n> Is there a compiler warning or something else?\n> \n> \n> Regards,\n> Barnabás Pőcze\n\nI have no memory of why I added this commit.\n\nYou should only have to invoke a base class constructor if its a \nnon-default constructor and I don't think that stats_(std::move) matters.\n\n---\nbod","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 853B6C3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 17 Jun 2025 11:42:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C810E68DD2;\n\tTue, 17 Jun 2025 13:42:27 +0200 (CEST)","from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5F4F68DCD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 17 Jun 2025 13:42:26 +0200 (CEST)","by mail-wm1-x32b.google.com with SMTP id\n\t5b1f17b1804b1-4530921461aso48143705e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 17 Jun 2025 04:42:26 -0700 (PDT)","from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-3a568b08dfesm13966356f8f.60.2025.06.17.04.42.25\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 17 Jun 2025 04:42:25 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"N4YBma9T\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1750160546; x=1750765346;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=QASab/twWKYV6OcSEjr3XoLksIRmb7Ilts2sA9GAecg=;\n\tb=N4YBma9TUfcvnGqIzbFXGOwqfyuWFM9fZMi4TF9M2S1I9kpM+QpSlunM0TnAbvoc0G\n\tV+1jm+kWIusRNGcEyijelgkeU1omdTxThIFSvLaPO1ce0VnKRaMOV+cKXkMBfrhpjYFf\n\t7ACHdr7BF7E02cRsFof6yG5mo9ewyU4Hf1EGpd7ii8sK+gegV7iVCi3rRFCZgaTaeIiZ\n\txT6N9eNbWTwKnhDEEw006RKAWUc3oujOV5uTw1EI9xIfQ+GxgP+5+PbvifZbfFcTkDfE\n\tkCgWdj7fMgvvVlU8MbHKrfmXZre+BYhbz81+T6ExjZP7nynGSzpmcln4TtIJGN8plCLn\n\tIfUw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1750160546; x=1750765346;\n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=QASab/twWKYV6OcSEjr3XoLksIRmb7Ilts2sA9GAecg=;\n\tb=vMm8dA9WSHPu5rUj7cLzqG+yjqVeFEKadBZks1aPaEWvqJnvz2hbWpTkfCBXdeRtG6\n\t90+SNlwE63g6pTZt5J9j5Kss98c8Q3Yct1R31+XrQcZRLDifdIPFZx5FcWHeNSsZapR3\n\tfGt+VkndXjmzLDPdg+2eg0yI1QbsyUhVhNhXZdu091TWeZdyMYc0cqF8QfYb5MGbv46H\n\tx4KBhfcIvSQe9PS4DTrWCCPfPNOeYg0bIyc8gct0+c9O32lFHiwUwfvuPuH7CNgg/5dt\n\tM2azQZsaEB3n16WJ78Kie4PyUZqRefZVJ4p0OtrRKHzHnTNy7YPgPxIxHRbNquLM9d7X\n\tVscQ==","X-Gm-Message-State":"AOJu0Yxpy2HVLPrN2W2OwR1L7xyICASbRqN1ZO8NFml/Q6CPRxpPmbyN\n\tgVdvHSBne5B4HaCMRfREoaP2vYr1y8xgBiAx/Sc/5sB3vHZoEwk+RCjvhl1K0qewk9Q=","X-Gm-Gg":"ASbGnctC6myDd/911cs3G/jQxg5D/Yai1iXGJlrwl71ghYUWVoBJ74uU/koxROA2dfh\n\tPlsCPjxPHP2rySD7u1PBCUR/GHUxywSrBIPKKwGcVYRNYSTOzlBAHBSF9B0HiehPvgZH/kBxm3b\n\tB49Rbw+uQYqy0YQvPHmvroMa/fs4I+erglAZ3U1VpNSYNsDGavZgArWb+ljKolBygRWSDoeyilS\n\t3mRoXBBkAxBJfk/c2Bjj+cKdS7050onr+PFgsJ3mNTXsiKiE3XT9hh3hJvSJWBcW0vj7X1LZSNd\n\t3+M+3ucdzlIuYEuKxj+97krIUy/IqTQ1tiTV0PrwhjIz/6O/Lbb37gQuUJi5ZuTzMn3BjrPKKvG\n\tCqEb3Y2WVrkJBw+FG7WSgFdEx02A=","X-Google-Smtp-Source":"AGHT+IFqwysDsPy0xM2piDLZcTnMJZcaMLblMu9Gs94FWAjfefVmxoN5y70YOgeRybdkAfulQg2Uqg==","X-Received":"by 2002:a05:600c:1d29:b0:44b:eb56:1d48 with SMTP id\n\t5b1f17b1804b1-45341b05d3amr107888885e9.4.1750160546103; \n\tTue, 17 Jun 2025 04:42:26 -0700 (PDT)","Message-ID":"<eff07c2c-828d-437a-91e1-107d68dcc337@linaro.org>","Date":"Tue, 17 Jun 2025 12:42:24 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 09/35] libcamera: software_isp: Move Bayer parans init\n\tfrom DebayerCpu to Debayer","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>","Cc":"libcamera-devel@lists.libcamera.org","References":"<20250611013245.133785-1-bryan.odonoghue@linaro.org>\n\t<20250611013245.133785-10-bryan.odonoghue@linaro.org>\n\t<85wm9bk1ez.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>\n\t<3497db4c-196d-466b-8760-e9703c31c159@ideasonboard.com>","Content-Language":"en-US","From":"Bryan O'Donoghue <bryan.odonoghue@linaro.org>","In-Reply-To":"<3497db4c-196d-466b-8760-e9703c31c159@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]