{"id":23515,"url":"https://patchwork.libcamera.org/api/patches/23515/?format=json","web_url":"https://patchwork.libcamera.org/patch/23515/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250611013245.133785-10-bryan.odonoghue@linaro.org>","date":"2025-06-11T01:32:19","name":"[09/35] libcamera: software_isp: Move Bayer parans init from DebayerCpu to Debayer","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7ecec3f531c4a988c284fc91b7318ba55aa898b1","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23515/mbox/","series":[{"id":5212,"url":"https://patchwork.libcamera.org/api/series/5212/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5212","date":"2025-06-11T01:32:10","name":"Add GLES 2.0 GPUISP to libcamera","version":1,"mbox":"https://patchwork.libcamera.org/series/5212/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23515/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23515/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 146E3C3324\n\tfor ;\n\tWed, 11 Jun 2025 01:33:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD79568DD0;\n\tWed, 11 Jun 2025 03:33:30 +0200 (CEST)","from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com\n\t[IPv6:2a00:1450:4864:20::42d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7367E68DD1\n\tfor ;\n\tWed, 11 Jun 2025 03:33:27 +0200 (CEST)","by mail-wr1-x42d.google.com with SMTP id\n\tffacd0b85a97d-3a503d9ef59so5107789f8f.3\n\tfor ;\n\tTue, 10 Jun 2025 18:33:27 -0700 (PDT)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4532514138asm5680625e9.3.2025.06.10.18.33.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 10 Jun 2025 18:33:26 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"azb/5Mdi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1749605607; x=1750210407;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=MnMhF/Y9/Rt41akuVWJPY/Wx/I+HkuTsZYCBn4kRXXw=;\n\tb=azb/5MdiG1QgwEY9nf3pUHiduUYRzk/goEEPKrwJfwIMqSAalrV2o434Coi03+WWPK\n\tsVaJ65GU8B1ebxp2/RxccCGXhe6wXqyDIVW6dKmtzITODUCEXJBr3GixYhDWHOwEDzfV\n\tMR9R+IOrP4rRxGmEhZSBQyiXWQcU2tgGZly34HDHrAMdagjm2cVx14iUQGRd9/qG4DER\n\tu2riStg6PDFXlCTq+xcXhb2UDSxtNiRJWuDfrei4OZXpGdxY5nRpFK8wuAo2PZfIDJPn\n\t35+UEmBJGMC8sknelwLa/dSv1ipV42KIIHRwpg+g2n9ePRtR2tkXJxFbVFonCrfsS1TS\n\tipGw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1749605607; x=1750210407;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=MnMhF/Y9/Rt41akuVWJPY/Wx/I+HkuTsZYCBn4kRXXw=;\n\tb=cMGxwIdcyAbcl9aRD7ljvuFOQbS+35lF2Sis27WKvrXiKS5LA3cC09Ssw9JhKEqsOc\n\tt5YSIajMmN4LDVtpxFpbrE/CE3K4L8drHyuttdea++gUyXdIFJis7FP610BL5NsbJuH1\n\tmfoTodukasTnMQ/f5WIlOfN8QZuGF2CjVPREDk9ofX3Iu2M6SgmVBWwf5T6COYa65Dd7\n\tBOYYcV1cgjhaXPCGwqyAM0AMbKJKYWBjE6KxLwd2QjTWO/AxVdxn0bvoTGOxw8kPw3i9\n\tC5oAmz0wct8qgbTRIl0un8urhmHa2QvjxQ8EEPwznjgwTAEKnMjWxFDG4CI4b/CVaqrQ\n\tX+cw==","X-Gm-Message-State":"AOJu0YyStGF3jMwgYQ4I5q2AjwuW/7Hw5oJ+PDry35bcW7ftwJTvLMJO\n\tzQsSu3HqD3CzrbA5MtBawzmOgIX75Wppn8SodDlXuBwSr/ozpSgNWYUHpsbGAkyt0WaLydCIwtm\n\tgpjro2xE=","X-Gm-Gg":"ASbGncvvfkyzzXh8YoDvc4eDb1ACH54hnYBEwXMJjNFjDe6DqG/5KQrE/0ljdaLDicl\n\tWeP3b3Y0F1bmssaq7OFfVXvIaw/EoKTZ2GjjkQM6wRgWlmEKcoU7kBj0bFXltTPTD6PR4II3p1f\n\tUGgB0VWngFxMPdEdaw71ZNXcwpg1M+6Wgu8loCXdkDFRHklnc5TQdjFiwJnIBJNffNkDawQRobx\n\tfGdgmmhF1Uxqo29UIIcRThwgqbWFNs0/fNtwGRRhiduh7jrJoEuSy91R8oenb15IWR6DvzwSSjE\n\tr6Yj+ODHR+UVnDP8Jvsn+Z8j536VusxExP6/1ZWCoKkbDBtlZYhWWdsos6DfMZcVQ1hXophtwiV\n\tq2qFNq2o9TDV+hoKPfp+aEdiSUO1Nbf5pinHwWcMLuw==","X-Google-Smtp-Source":"AGHT+IHjk69XazhQiHZBnggSa2PkcljqojJYjG6+qhg8ENnPUiVkeN8WuTou7kLmgB5t6YyhFk63wQ==","X-Received":"by 2002:a05:6000:2307:b0:3a4:e480:b5df with SMTP id\n\tffacd0b85a97d-3a558a1aee6mr786163f8f.44.1749605606811; \n\tTue, 10 Jun 2025 18:33:26 -0700 (PDT)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"Bryan O'Donoghue ","Subject":"[PATCH 09/35] libcamera: software_isp: Move Bayer parans init from\n\tDebayerCpu to Debayer","Date":"Wed, 11 Jun 2025 02:32:19 +0100","Message-ID":"<20250611013245.133785-10-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250611013245.133785-1-bryan.odonoghue@linaro.org>","References":"<20250611013245.133785-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Move the initialisation of Bayer params and CCM to a new constructor in the\nDebayer class.\n\nEnsure we call the base class constructor from DebayerCpu's constructor in\nthe expected constructor order Debayer then DebayerCpu.\n\nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/debayer.cpp | 11 +++++++++++\n src/libcamera/software_isp/debayer.h | 1 +\n src/libcamera/software_isp/debayer_cpu.cpp | 10 +---------\n 3 files changed, 13 insertions(+), 9 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex e9e18c48..29fdcbbf 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -103,6 +103,17 @@ namespace libcamera {\n \n LOG_DEFINE_CATEGORY(Debayer)\n \n+Debayer::Debayer()\n+{\n+\t/* Initialize color lookup tables */\n+\tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n+\t\tred_[i] = green_[i] = blue_[i] = i;\n+\t\tredCcm_[i] = { static_cast(i), 0, 0 };\n+\t\tgreenCcm_[i] = { 0, static_cast(i), 0 };\n+\t\tblueCcm_[i] = { 0, 0, static_cast(i) };\n+\t}\n+}\n+\n Debayer::~Debayer()\n {\n }\ndiff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex 45da822a..01b6e916 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -32,6 +32,7 @@ LOG_DECLARE_CATEGORY(Debayer)\n class Debayer : public Object\n {\n public:\n+\tDebayer();\n \tvirtual ~Debayer() = 0;\n \n \tvirtual int configure(const StreamConfiguration &inputCfg,\ndiff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex 8d30bf4a..13db8a8c 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -40,7 +40,7 @@ namespace libcamera {\n * \\param[in] stats Pointer to the stats object to use\n */\n DebayerCpu::DebayerCpu(std::unique_ptr stats)\n-\t: stats_(std::move(stats))\n+\t: Debayer(), stats_(std::move(stats))\n {\n \t/*\n \t * Reading from uncached buffers may be very slow.\n@@ -51,14 +51,6 @@ DebayerCpu::DebayerCpu(std::unique_ptr stats)\n \t * future.\n \t */\n \tenableInputMemcpy_ = true;\n-\n-\t/* Initialize color lookup tables */\n-\tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n-\t\tred_[i] = green_[i] = blue_[i] = i;\n-\t\tredCcm_[i] = { static_cast(i), 0, 0 };\n-\t\tgreenCcm_[i] = { 0, static_cast(i), 0 };\n-\t\tblueCcm_[i] = { 0, 0, static_cast(i) };\n-\t}\n }\n \n DebayerCpu::~DebayerCpu() = default;\n","prefixes":["09/35"]}