[{"id":34478,"web_url":"https://patchwork.libcamera.org/comment/34478/","msgid":"<855xgvlhx9.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-06-16T17:23:14","subject":"Re: [PATCH 06/35] libcamera: MappedFrameBuffer: Latch a pointer to\n\tthe framebuffer","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> Take a pointer to the given framebuffer as a private member for further use\n> in later patches.\n>\n> Signed-off-by: Bryan O'Donoghue \n\nReviewed-by: Milan Zamazal \n\n> ---\n> include/libcamera/internal/mapped_framebuffer.h | 3 +++\n> src/libcamera/mapped_framebuffer.cpp | 2 ++\n> 2 files changed, 5 insertions(+)\n>\n> diff --git a/include/libcamera/internal/mapped_framebuffer.h b/include/libcamera/internal/mapped_framebuffer.h\n> index 6aaabf50..75ac2c8f 100644\n> --- a/include/libcamera/internal/mapped_framebuffer.h\n> +++ b/include/libcamera/internal/mapped_framebuffer.h\n> @@ -55,6 +55,9 @@ public:\n> \tusing MapFlags = Flags;\n> \n> \tMappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags);\n> +\n> +private:\n> +\tconst FrameBuffer *buffer_;\n> };\n> \n> LIBCAMERA_FLAGS_ENABLE_OPERATORS(MappedFrameBuffer::MapFlag)\n> diff --git a/src/libcamera/mapped_framebuffer.cpp b/src/libcamera/mapped_framebuffer.cpp\n> index f54bbf21..f5ee770c 100644\n> --- a/src/libcamera/mapped_framebuffer.cpp\n> +++ b/src/libcamera/mapped_framebuffer.cpp\n> @@ -238,6 +238,8 @@ MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags)\n> \n> \t\tplanes_.emplace_back(info.address + plane.offset, plane.length);\n> \t}\n> +\n> +\tbuffer_ = buffer;\n> }\n> \n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F5EBBDE6B\n\tfor ;\n\tMon, 16 Jun 2025 17:23:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 08A7268DCB;\n\tMon, 16 Jun 2025 19:23:21 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD63A68DC0\n\tfor ;\n\tMon, 16 Jun 2025 19:23:19 +0200 (CEST)","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n\t[209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-639-JYgxhzo6OluprdMh_N0bTw-1; Mon, 16 Jun 2025 13:23:17 -0400","by mail-wm1-f69.google.com with SMTP id\n\t5b1f17b1804b1-43eed325461so30635475e9.3\n\tfor ;\n\tMon, 16 Jun 2025 10:23:17 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4532e232e4asm148790965e9.11.2025.06.16.10.23.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 16 Jun 2025 10:23:15 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Wp1uX08S\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1750094598;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=98BtR3j2TM6/2GXJQetNpzjgvTIyrwVAQE6HQ7WorCA=;\n\tb=Wp1uX08SCw6JCguvgPDoLzy9JVL+mZHa3rLyMU4Mx5grXNcGbKAdSmC++wIg9Ua7RduMWl\n\t+HzJLBYMkyhbdSCUGMEEYr2TMROBsiNG2yAr1IggKEAOBPi6RNYWi5/9xfpVMDK2MFS1Zm\n\tedsyV/+wX6DVfX3X/SoUJTxzdC63Dds=","X-MC-Unique":"JYgxhzo6OluprdMh_N0bTw-1","X-Mimecast-MFC-AGG-ID":"JYgxhzo6OluprdMh_N0bTw_1750094596","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1750094596; x=1750699396;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=98BtR3j2TM6/2GXJQetNpzjgvTIyrwVAQE6HQ7WorCA=;\n\tb=H99e52tDmpgoWv2OVYcJXm2PbW2+Zi0xxclJqzbcducGrJPhQpqzWJyMj78Qy5LWQ9\n\tKAg3eOR4SJTbL5ldKUbTmiC6FvPMmLe2g3bc0vcUxV4qwBJcwYCgDs/lhOJWtN/jVFSD\n\t78HxSZYND5hF+QHStX2u1lfmNJJsu/9InuobaBTIo9C/PIFO5B64MPCN2nBNJBCnRyB1\n\t+ULPTdQDMNzTizWZfge0tHUXSGadV486xxmT2k5mm8Ms2LB6j4hke0gfhx5/Ck5iqpAo\n\tIJAD4EDP5/1tCYylxmIj0HWrVoDs/YuJx7cs7tyYkvvOH/Awhg6RzHNpH5zDnuwVi8n4\n\tl0MA==","X-Gm-Message-State":"AOJu0YxP5BT/q58wYlzCyLb+c0o7j7mWA037PpGAQBQq93AaxxKCx5KX\n\tidhEyvXjBAJ4prLECAHAqSbJJiGBjODHJZFpxt+GYisy5QKGXkqqc4nbxKOBw5ZtjVpjFrkjeQW\n\tC0pwKviDRrZhvvM4dLtl5rohbr1ukY3YwmMi+IF60h9kUUm333thrkLzRZPtPqOma8ALRzUFO5x\n\tWFMawAyHjDUXpaE+yIU2KAapRJi41QkObEkTynR91kqyg+o9wbJFQNCoxNLPk=","X-Gm-Gg":"ASbGncuC/BWXU/UCFXm84x3Ox8V6bOn/IZS+y/9LspYTMkpqekbPT29B18lDX2oQcMz\n\tHUD35i/6yAT1qrmPajY8jnTJyJn97M0izR/4TiaHkRcnKZ3qh9YI17LfSPXevFXDHKfV/UYHoYx\n\tSqImS9nAK5LkbC3WS2raseAljaFtsWn7ncQzSo9xVk0QorUbBApDEa6KZlaqOeu8Jcyj8OWSdsJ\n\tS/ac8NKoZh9VFV4uUkFybGEJuD0HxoAZRiN5XRFQVY9TzO828KPR0hNQUpnnI2vWR7WZitfJPJN\n\tlRoYdxF63KW1ONzaY1H9Jq+gkKc88jFhcL09SLch3khDgQt5rXEOpF5FNNZT50scvDDFMOKq0kY\n\t=","X-Received":["by 2002:a05:600c:a301:b0:450:d01e:78ee with SMTP id\n\t5b1f17b1804b1-4533cc0887bmr67147345e9.24.1750094596115; \n\tMon, 16 Jun 2025 10:23:16 -0700 (PDT)","by 2002:a05:600c:a301:b0:450:d01e:78ee with SMTP id\n\t5b1f17b1804b1-4533cc0887bmr67147245e9.24.1750094595684; \n\tMon, 16 Jun 2025 10:23:15 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IGcwRQhLXZs9JQeF3pRbtZg4jVXBrq8rUddyBZbS6geFiy3SnvoL1idAYaJUg332V3LMCLDDg==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 06/35] libcamera: MappedFrameBuffer: Latch a pointer to\n\tthe framebuffer","In-Reply-To":"<20250611013245.133785-7-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Wed, 11 Jun 2025 02:32:16 +0100\")","References":"<20250611013245.133785-1-bryan.odonoghue@linaro.org>\n\t<20250611013245.133785-7-bryan.odonoghue@linaro.org>","Date":"Mon, 16 Jun 2025 19:23:14 +0200","Message-ID":"<855xgvlhx9.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"5if3zEzD6io39i40xrEROUUyvq1n_gfhZ1GV1vJx3UU_1750094596","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]