{"id":23492,"url":"https://patchwork.libcamera.org/api/patches/23492/?format=json","web_url":"https://patchwork.libcamera.org/patch/23492/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250606164156.1442682-12-barnabas.pocze@ideasonboard.com>","date":"2025-06-06T16:41:44","name":"[RFC,v1,11/23] libcamera: request: Store `MetadataList`","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"fb1b39e4a365079b2498717bb09c37b3c0af555f","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23492/mbox/","series":[{"id":5210,"url":"https://patchwork.libcamera.org/api/series/5210/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5210","date":"2025-06-06T16:41:33","name":"libcamera: Add `MetadataList`","version":1,"mbox":"https://patchwork.libcamera.org/series/5210/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23492/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23492/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C5CECC3329\n\tfor ;\n\tFri, 6 Jun 2025 16:42:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3AD3E68DC9;\n\tFri, 6 Jun 2025 18:42:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D8A568DCA\n\tfor ;\n\tFri, 6 Jun 2025 18:42:18 +0200 (CEST)","from pb-laptop.local (185.182.215.79.nat.pool.zt.hu\n\t[185.182.215.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 735018DB\n\tfor ;\n\tFri, 6 Jun 2025 18:42:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BBZ/ndM8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749228133;\n\tbh=unLwYMysziuAD650a3MXzhC8IyXlSvsliMIvZqJ2L4w=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=BBZ/ndM8f9gdhUUKNyxW4J/QiUayRXMf0kd9RDFppnu3Rhasgb6VOTRiiv4e645pI\n\tuoL5NqEa7sBY0j+9xUoBC/KzxzqOdI0aaxwI11kUgRDKErikVFaToDpDDj8hEV/m30\n\t6HnrhOF3LXV06ndMmBgcL9GhrXH8QqUVK+mZ9C2s=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 11/23] libcamera: request: Store `MetadataList`","Date":"Fri, 6 Jun 2025 18:41:44 +0200","Message-ID":"<20250606164156.1442682-12-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250606164156.1442682-1-barnabas.pocze@ideasonboard.com>","References":"<20250606164156.1442682-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a `MetadataList` to the `Request` object to store the metadata items\nreturned by the camera. The metadata list is initialized using the camera's\n`MetadataListPlan` object, which is supposed to be filled by the pipeline\nhandlers.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/request.h | 5 +++++\n src/libcamera/request.cpp | 2 ++\n 2 files changed, 7 insertions(+)","diff":"diff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex e214a9d13..171a40903 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -18,6 +18,7 @@\n \n #include \n #include \n+#include \n \n namespace libcamera {\n \n@@ -51,6 +52,9 @@ public:\n \n \tControlList &controls() { return *controls_; }\n \tControlList &metadata() { return *metadata_; }\n+#ifndef __DOXYGEN__\n+\t[[nodiscard]] auto &metadata2() { return metadata2_; }\n+#endif\n \tconst BufferMap &buffers() const { return bufferMap_; }\n \tint addBuffer(const Stream *stream, FrameBuffer *buffer,\n \t\t std::unique_ptr fence = nullptr);\n@@ -69,6 +73,7 @@ private:\n \n \tControlList *controls_;\n \tControlList *metadata_;\n+\tMetadataList metadata2_;\n \tBufferMap bufferMap_;\n \n \tconst uint64_t cookie_;\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 7f1e11e8f..17ca67d08 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -354,6 +354,7 @@ void Request::Private::timeout()\n */\n Request::Request(Camera *camera, uint64_t cookie)\n \t: Extensible(std::make_unique(camera)),\n+\t metadata2_(camera->_d()->metadataPlan_),\n \t cookie_(cookie), status_(RequestPending)\n {\n \tcontrols_ = new ControlList(controls::controls,\n@@ -407,6 +408,7 @@ void Request::reuse(ReuseFlag flags)\n \n \tcontrols_->clear();\n \tmetadata_->clear();\n+\tmetadata2_.clear();\n }\n \n /**\n","prefixes":["RFC","v1","11/23"]}