[{"id":34560,"web_url":"https://patchwork.libcamera.org/comment/34560/","msgid":"<7iszdvp73x327h4i3qq6ojkbm4ihnn2xd3kigaav2bni5ugk4r@yojy6iquwgse>","date":"2025-06-19T11:04:12","subject":"Re: [RFC PATCH v1 10/23] libcamera: camera: Store `MetadataListPlan`\n\tin `Camera::Private`","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Fri, Jun 06, 2025 at 06:41:43PM +0200, Barnabás Pőcze wrote:\n> Just like `ControlInfoMap controlInfo_` is a public member of the private\n> camera data for pipeline handlers to populate, add a `MetadataListPlan` as\n> well for the pipeline handlers to fill. This will be used to initialize\n> the `MetadataList` of each request created by the camera.\n>\n> Signed-off-by: Barnabás Pőcze \n> ---\n> include/libcamera/internal/camera.h | 3 +++\n> src/libcamera/camera.cpp | 8 ++++++++\n> 2 files changed, 11 insertions(+)\n>\n> diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\n> index 18f5c32a1..d5d869887 100644\n> --- a/include/libcamera/internal/camera.h\n> +++ b/include/libcamera/internal/camera.h\n> @@ -17,6 +17,7 @@\n> #include \n>\n> #include \n> +#include \n>\n> namespace libcamera {\n>\n> @@ -41,6 +42,8 @@ public:\n>\n> \tuint32_t requestSequence_;\n>\n> +\tMetadataListPlan metadataPlan_;\n> +\n\nnit: I would move it up a few lines just after properties_\n\nReviewed-by: Jacopo Mondi \n\n> \tconst CameraControlValidator *validator() const { return validator_.get(); }\n>\n> private:\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index c180a5fdd..31f5ad94b 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -660,6 +660,14 @@ Camera::Private::~Private()\n> * over a single capture session.\n> */\n>\n> +/**\n> + * \\var Camera::Private::metadataPlan_\n> + * \\brief The set of metadata supported by the camera\n> + *\n> + * The metadata information shall be initialised by the pipeline handler when\n> + * creating the camera.\n> + */\n> +\n> static const char *const camera_state_names[] = {\n> \t\"Available\",\n> \t\"Acquired\",\n> --\n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4B039BDE6B\n\tfor ;\n\tThu, 19 Jun 2025 11:04:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 766C268DE3;\n\tThu, 19 Jun 2025 13:04:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D500468DDB\n\tfor ;\n\tThu, 19 Jun 2025 13:04:15 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E5E93346;\n\tThu, 19 Jun 2025 13:04:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tzPExMdh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1750331042;\n\tbh=Ja5ZSo4mEFI6eIZDeS5am2wnkNoZBrnbSnx/pQ/Pbkw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tzPExMdhOEJATtpBALzEFy7imCuS1mhaGrZ4DHnuFopikuMyU2pEMVG49O8qSHFS9\n\tlSgbp5TzXO8N830KghICqzXXSBg7DcdCtyy5PUZATxziLTotll8tcLtvACDcYFdWxj\n\tepGPaCLQdqjaj1U21mJ+MSGGkQW8F1uAYZEalkSQ=","Date":"Thu, 19 Jun 2025 13:04:12 +0200","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v1 10/23] libcamera: camera: Store `MetadataListPlan`\n\tin `Camera::Private`","Message-ID":"<7iszdvp73x327h4i3qq6ojkbm4ihnn2xd3kigaav2bni5ugk4r@yojy6iquwgse>","References":"<20250606164156.1442682-1-barnabas.pocze@ideasonboard.com>\n\t<20250606164156.1442682-11-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250606164156.1442682-11-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]