[{"id":34438,"web_url":"https://patchwork.libcamera.org/comment/34438/","msgid":"<5oygkdfzz6e3atpve2y3u2lmtjxf7oiwi7sbcysusti2m7kxp5@irewjkzzovnz>","date":"2025-06-10T15:22:17","subject":"Re: [RFC PATCH v1 01/23] libcamera: controls: Strings are arrays","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Fri, Jun 06, 2025 at 06:41:34PM +0200, Barnabás Pőcze wrote:\n> `ControlId::isArray()` and `ControlValue::isArray()` disagree\n> in the case of strings. Fix it by setting the static size of a\n> string to `libcamera::dynamic_extent` to denote a dynamically\n> sized array-like value.\n>\n> One unfortunate side effect of this change is that if there were\n> string controls (there are none at the moment), then `cam` would\n> display them with an extra `Size: n` annotation.\n>\n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=255\n> Signed-off-by: Barnabás Pőcze \n\nI've seen this patch multiple times already, I don't know if there was\nany controversy with it, but to me it's reasonable\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> include/libcamera/controls.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 2ae4ec3d4..b170e30cb 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -98,7 +98,7 @@ struct control_type {\n> template<>\n> struct control_type {\n> \tstatic constexpr ControlType value = ControlTypeString;\n> -\tstatic constexpr std::size_t size = 0;\n> +\tstatic constexpr std::size_t size = libcamera::dynamic_extent;\n> };\n>\n> template<>\n> --\n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0AC2AC3237\n\tfor ;\n\tTue, 10 Jun 2025 15:22:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F16EB68DB1;\n\tTue, 10 Jun 2025 17:22:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C55F861869\n\tfor ;\n\tTue, 10 Jun 2025 17:22:20 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2DD8B22B;\n\tTue, 10 Jun 2025 17:22:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OIxVg1dn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749568933;\n\tbh=p7n++EsNuScviKGrEhSSC1FhG6PSJSNSgCKtr9GsxLw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OIxVg1dnFA+VhMnKj0IPbPbPW8gjD2uYFU+zC/DfraeChovgyAyPcG6wTq1/WfcR/\n\tD49R16wto50yRckLEq3YEDbSDZw5KzqY4VeE4Xor+EkkwBwAbh7jTJXVnOScIIhjz+\n\tR7nxaAgbj3BsDj4L8pWqFByUNd5YnB6MKCDpnCt8=","Date":"Tue, 10 Jun 2025 17:22:17 +0200","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v1 01/23] libcamera: controls: Strings are arrays","Message-ID":"<5oygkdfzz6e3atpve2y3u2lmtjxf7oiwi7sbcysusti2m7kxp5@irewjkzzovnz>","References":"<20250606164156.1442682-1-barnabas.pocze@ideasonboard.com>\n\t<20250606164156.1442682-2-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250606164156.1442682-2-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]