{"id":23482,"url":"https://patchwork.libcamera.org/api/patches/23482/?format=json","web_url":"https://patchwork.libcamera.org/patch/23482/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250606164156.1442682-2-barnabas.pocze@ideasonboard.com>","date":"2025-06-06T16:41:34","name":"[RFC,v1,01/23] libcamera: controls: Strings are arrays","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1090c2f667cdb1e72bad16de48820df1b0ca5bf6","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23482/mbox/","series":[{"id":5210,"url":"https://patchwork.libcamera.org/api/series/5210/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5210","date":"2025-06-06T16:41:33","name":"libcamera: Add `MetadataList`","version":1,"mbox":"https://patchwork.libcamera.org/series/5210/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23482/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23482/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB028C31E9\n\tfor ;\n\tFri, 6 Jun 2025 16:42:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1FE6868DCB;\n\tFri, 6 Jun 2025 18:42:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B36868DB3\n\tfor ;\n\tFri, 6 Jun 2025 18:42:15 +0200 (CEST)","from pb-laptop.local (185.182.215.79.nat.pool.zt.hu\n\t[185.182.215.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D96F98DB\n\tfor ;\n\tFri, 6 Jun 2025 18:42:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sQmfM8WH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749228131;\n\tbh=9cwBxtvGzC19ypd9Rx9AYGA52GWM6KIvShU8pEJ4NG8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=sQmfM8WHaXBSAj1Txei4PIvMsFBzQqZPJuxgHH4nD3VNb3Jphq0yZR5hRLIvjTE6s\n\tg6IUIXH0W9mYCfz58NKjYTmLX6coMsyPKo77mmhhx7M3Vr/9lnXJAZEEhvGwKmp8eT\n\ta78O1hFN/S1HxnZ/oJcg3Oj0F0JbNiHCoy3WxKn8=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 01/23] libcamera: controls: Strings are arrays","Date":"Fri, 6 Jun 2025 18:41:34 +0200","Message-ID":"<20250606164156.1442682-2-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250606164156.1442682-1-barnabas.pocze@ideasonboard.com>","References":"<20250606164156.1442682-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"`ControlId::isArray()` and `ControlValue::isArray()` disagree\nin the case of strings. Fix it by setting the static size of a\nstring to `libcamera::dynamic_extent` to denote a dynamically\nsized array-like value.\n\nOne unfortunate side effect of this change is that if there were\nstring controls (there are none at the moment), then `cam` would\ndisplay them with an extra `Size: n` annotation.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=255\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/controls.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 2ae4ec3d4..b170e30cb 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -98,7 +98,7 @@ struct control_type {\n template<>\n struct control_type {\n \tstatic constexpr ControlType value = ControlTypeString;\n-\tstatic constexpr std::size_t size = 0;\n+\tstatic constexpr std::size_t size = libcamera::dynamic_extent;\n };\n \n template<>\n","prefixes":["RFC","v1","01/23"]}