[{"id":34499,"web_url":"https://patchwork.libcamera.org/comment/34499/","msgid":"<20250616214055.GA19208@pendragon.ideasonboard.com>","date":"2025-06-16T21:40:55","subject":"Re: [PATCH] pipeline: imx8-isi: Dynamically compute crossbar\n\tsubdevice's first source.","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Antoine,\n\nThank you for the patch.\n\nOn Fri, Jun 06, 2025 at 09:34:59AM +0200, Antoine Bouyer wrote:\n> So far, imx8-isi pipeline supports _symetrical_ crossbar, with same\n> amount of sink and source pads.\n> \n> But for some other imx SoCs, such as i.MX8QM or i.MX95, crossbar is not\n> symetric anymore.\n> \n> Since each crossbar source is already captured as a pipes_ vector entry,\n> we use pipes_ vector's size to compute 1st source index.\n> \n> \"1st source index\" = \"total number of crossbar pads\" - pipes_.count()\n> \n> Signed-off-by: Antoine Bouyer \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> index ecda426a6021..177097ae21d6 100644\n> --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> @@ -822,7 +822,7 @@ int PipelineHandlerISI::configure(Camera *camera, CameraConfiguration *c)\n> \t * routing table instead of resetting it.\n> \t */\n> \tV4L2Subdevice::Routing routing = {};\n> -\tunsigned int xbarFirstSource = crossbar_->entity()->pads().size() / 2 + 1;\n> +\tunsigned int xbarFirstSource = crossbar_->entity()->pads().size() - pipes_.size();\n> \n> \tfor (const auto &[idx, config] : utils::enumerate(*c)) {\n> \t\tuint32_t sourcePad = xbarFirstSource + idx;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C05CC3237\n\tfor ;\n\tMon, 16 Jun 2025 21:41:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 47D4868DCB;\n\tMon, 16 Jun 2025 23:41:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1057968DC0\n\tfor ;\n\tMon, 16 Jun 2025 23:41:12 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 01A78C64;\n\tMon, 16 Jun 2025 23:40:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tsE2byRt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1750110060;\n\tbh=/BSV/l8M/HfO1G4wYOvunv/9JcaqiN9UcEJkxZ2PD0M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tsE2byRtpui8fNbTJudLlugJMvbbHa5GWiuagJu1XpDJoTaSMIc/t5hRd4e2YPpTG\n\tW+RFzZmFeiQJqUO00lzf047Io05ds9xCW1q39WxGGprYVSkn1H7Wtz/gxmX4FKVPdi\n\tFkotAVKcpQMlq05pmdFeFfUszJ63K4CAimv4Snh0=","Date":"Tue, 17 Jun 2025 00:40:55 +0300","From":"Laurent Pinchart ","To":"Antoine Bouyer ","Cc":"libcamera-devel@lists.libcamera.org, julien.vuillaumier@nxp.com","Subject":"Re: [PATCH] pipeline: imx8-isi: Dynamically compute crossbar\n\tsubdevice's first source.","Message-ID":"<20250616214055.GA19208@pendragon.ideasonboard.com>","References":"<20250606073459.1869940-1-antoine.bouyer@nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250606073459.1869940-1-antoine.bouyer@nxp.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]