[{"id":34408,"web_url":"https://patchwork.libcamera.org/comment/34408/","msgid":"","date":"2025-06-04T13:17:57","subject":"Re: [PATCH 2/2] pipeline: imx8-isi: Fix match returned value in\n\terror case","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 06. 04. 15:14 keltezéssel, Antoine Bouyer írta:\n> Match callback returns boolean type, while it could return int in case\n> of error when opening the capture file.\n> Fixes: 0ec982d2108 (\"libcamera: pipeline: Add IMX8 ISI pipeline\")\n> \n> Signed-off-by: Antoine Bouyer \n\nReviewed-by: Barnabás Pőcze \n\n\nRegards,\nBarnabás Pőcze\n\n\n> ---\n> src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> index dc20ab2..1b7c661 100644\n> --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> @@ -1003,7 +1003,7 @@ bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)\n> \n> \t\tret = capture->open();\n> \t\tif (ret)\n> -\t\t\treturn ret;\n> +\t\t\treturn false;\n> \n> \t\tpipes_.push_back({ std::move(isi), std::move(capture) });\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BF1BDC31E9\n\tfor ;\n\tWed, 4 Jun 2025 13:18:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87D0968DC0;\n\tWed, 4 Jun 2025 15:18:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C294E68DB3\n\tfor ;\n\tWed, 4 Jun 2025 15:18:01 +0200 (CEST)","from [192.168.33.16] (185.182.214.22.nat.pool.zt.hu\n\t[185.182.214.22])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 89B6178C;\n\tWed, 4 Jun 2025 15:17:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sVuiWH9L\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749043078;\n\tbh=KrZsNyw1E6Vq3aRuKFkbjIwQ2upI6TMc/JFzQIb8S90=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=sVuiWH9LP9NoXW7R82nDKTuu+X7RwTcxiPnfhd/oWkQYiC6Q6mjsOuYxjoIMvPtck\n\tAYfiarqa97TwbFbComAZFHX+H9NPqaXA7M/tEXv/vXWyplnt4R4nDkls4Yj2QNAQqg\n\tQyqYXSZcHP78NV0HHeecWvPd8DpBqjbvPWrE9U+U=","Message-ID":"","Date":"Wed, 4 Jun 2025 15:17:57 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/2] pipeline: imx8-isi: Fix match returned value in\n\terror case","To":"Antoine Bouyer ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"julien.vuillaumier@nxp.com","References":"<20250604131403.1729356-1-antoine.bouyer@nxp.com>\n\t<20250604131403.1729356-2-antoine.bouyer@nxp.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250604131403.1729356-2-antoine.bouyer@nxp.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34410,"web_url":"https://patchwork.libcamera.org/comment/34410/","msgid":"<20250604132327.GD3755@pendragon.ideasonboard.com>","date":"2025-06-04T13:23:27","subject":"Re: [PATCH 2/2] pipeline: imx8-isi: Fix match returned value in\n\terror case","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Antoine,\n\nThank you for the patch.\n\nOn Wed, Jun 04, 2025 at 03:14:03PM +0200, Antoine Bouyer wrote:\n> Match callback returns boolean type, while it could return int in case\n\n\"The match() function returns a boolean type, ...\"\n\n> of error when opening the capture file.\n\nMissing blank line.\n\n> Fixes: 0ec982d2108 (\"libcamera: pipeline: Add IMX8 ISI pipeline\")\n> \n\nNo blank line here.\n\n> Signed-off-by: Antoine Bouyer \n\nNo need to resubmit this patch either.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> index dc20ab2..1b7c661 100644\n> --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> @@ -1003,7 +1003,7 @@ bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)\n> \n> \t\tret = capture->open();\n> \t\tif (ret)\n> -\t\t\treturn ret;\n> +\t\t\treturn false;\n> \n> \t\tpipes_.push_back({ std::move(isi), std::move(capture) });\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54463C3237\n\tfor ;\n\tWed, 4 Jun 2025 13:23:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ECB1868DA8;\n\tWed, 4 Jun 2025 15:23:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 90DF668DA8\n\tfor ;\n\tWed, 4 Jun 2025 15:23:37 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8BA9E78C;\n\tWed, 4 Jun 2025 15:23:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EX74DVYj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749043414;\n\tbh=1sBIDjz670oLCBRpo4Uiwb3yXto9IRGqYaQVuAj4qrY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EX74DVYjJHpS4Yb9zGWybjtmaOR0NKfd6RN6uaT0OXjpSIbDlDwyow1myvCBnSj1d\n\tuJc65crpZ2DfQD1FT8ZrPhpclFt5Zg1u1F2aZrKbAA7EU6XCayzoKnVvjt2c7Px9kC\n\t85uFjMq8d8qynE1ZaE/DhYybHkztgP4gnpywGNXg=","Date":"Wed, 4 Jun 2025 16:23:27 +0300","From":"Laurent Pinchart ","To":"Antoine Bouyer ","Cc":"libcamera-devel@lists.libcamera.org, julien.vuillaumier@nxp.com","Subject":"Re: [PATCH 2/2] pipeline: imx8-isi: Fix match returned value in\n\terror case","Message-ID":"<20250604132327.GD3755@pendragon.ideasonboard.com>","References":"<20250604131403.1729356-1-antoine.bouyer@nxp.com>\n\t<20250604131403.1729356-2-antoine.bouyer@nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250604131403.1729356-2-antoine.bouyer@nxp.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34413,"web_url":"https://patchwork.libcamera.org/comment/34413/","msgid":"<20250604134002.GE3755@pendragon.ideasonboard.com>","date":"2025-06-04T13:40:02","subject":"Re: [PATCH 2/2] pipeline: imx8-isi: Fix match returned value in\n\terror case","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jun 04, 2025 at 04:23:27PM +0300, Laurent Pinchart wrote:\n> Hi Antoine,\n> \n> Thank you for the patch.\n> \n> On Wed, Jun 04, 2025 at 03:14:03PM +0200, Antoine Bouyer wrote:\n> > Match callback returns boolean type, while it could return int in case\n> \n> \"The match() function returns a boolean type, ...\"\n> \n> > of error when opening the capture file.\n> \n> Missing blank line.\n> \n> > Fixes: 0ec982d2108 (\"libcamera: pipeline: Add IMX8 ISI pipeline\")\n\nAlso, this should be \n\nFixes: 0ec982d21086 (\"libcamera: pipeline: Add IMX8 ISI pipeline\")\n\nI have the following in my ~/.bashrc:\n\n--------\ngpf() {\n git show --pretty=fixes -s ${1:-HEAD} | wl-copy\n}\n--------\n\n(you can replace \"wl-copy\" with \"xclip -selection clipboard\" if you use\nX instead of Wayland)\n\nand the following in my ~/.gitconfig:\n\n--------\n[core]\n abbrev = 12\n\n[pretty]\n fixes = Fixes: %h (\\\"%s\\\")\n--------\n\nThat way I can run \"gpf 0ec982d210861cc6aaebb5d6e8f1a755a16c9792\" and\nthen press ctrl-shift-v (or whatever the paste shortcut is in your\neditor) and get\n\nFixes: 0ec982d21086 (\"libcamera: pipeline: Add IMX8 ISI pipeline\")\n\n> > \n> \n> No blank line here.\n> \n> > Signed-off-by: Antoine Bouyer \n> \n> No need to resubmit this patch either.\n> \n> Reviewed-by: Laurent Pinchart \n> \n> > ---\n> > src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> > index dc20ab2..1b7c661 100644\n> > --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> > +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> > @@ -1003,7 +1003,7 @@ bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)\n> > \n> > \t\tret = capture->open();\n> > \t\tif (ret)\n> > -\t\t\treturn ret;\n> > +\t\t\treturn false;\n> > \n> > \t\tpipes_.push_back({ std::move(isi), std::move(capture) });\n> > \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05A53C3237\n\tfor ;\n\tWed, 4 Jun 2025 13:40:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A28A668DBD;\n\tWed, 4 Jun 2025 15:40:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8FF8A68DA8\n\tfor ;\n\tWed, 4 Jun 2025 15:40:12 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6381F78C;\n\tWed, 4 Jun 2025 15:40:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IpzZbMG/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749044409;\n\tbh=E6c2TDHqmN3xaTBujF2SIPHhwwlBzlVstwqCS+rsido=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IpzZbMG/Bb9rpGbOTI27HRMlc+F7cc0KAf8MnRgzARgBVmxfm7Jzg20TXRGFD0lqN\n\ts3bcgk9BUJTiN4Vlvv8KAjJkuD26FZYHzugUndUe++iYkIFts/6czLJzsf1r3R4DLS\n\t/BeSbRYb+7k7hXYHKZPN5hpqt0ks3AO4PIlsVvMo=","Date":"Wed, 4 Jun 2025 16:40:02 +0300","From":"Laurent Pinchart ","To":"Antoine Bouyer ","Cc":"libcamera-devel@lists.libcamera.org, julien.vuillaumier@nxp.com","Subject":"Re: [PATCH 2/2] pipeline: imx8-isi: Fix match returned value in\n\terror case","Message-ID":"<20250604134002.GE3755@pendragon.ideasonboard.com>","References":"<20250604131403.1729356-1-antoine.bouyer@nxp.com>\n\t<20250604131403.1729356-2-antoine.bouyer@nxp.com>\n\t<20250604132327.GD3755@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250604132327.GD3755@pendragon.ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]