{"id":23470,"url":"https://patchwork.libcamera.org/api/patches/23470/?format=json","web_url":"https://patchwork.libcamera.org/patch/23470/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250604131403.1729356-2-antoine.bouyer@nxp.com>","date":"2025-06-04T13:14:03","name":"[2/2] pipeline: imx8-isi: Fix match returned value in error case","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"420eff66887cf071ceab5dee7368eab715be880e","submitter":{"id":218,"url":"https://patchwork.libcamera.org/api/people/218/?format=json","name":"Antoine Bouyer","email":"antoine.bouyer@nxp.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23470/mbox/","series":[{"id":5205,"url":"https://patchwork.libcamera.org/api/series/5205/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5205","date":"2025-06-04T13:14:02","name":"[1/2] pipeline: imx8-isi: Cosmetic changes","version":1,"mbox":"https://patchwork.libcamera.org/series/5205/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23470/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23470/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6A52FC3237\n\tfor ;\n\tWed, 4 Jun 2025 13:13:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1ECE068DC3;\n\tWed, 4 Jun 2025 15:13:36 +0200 (CEST)","from DB3PR0202CU003.outbound.protection.outlook.com\n\t(mail-northeuropeazlp170100001.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:c200::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C0EC168DBD\n\tfor ;\n\tWed, 4 Jun 2025 15:13:34 +0200 (CEST)","from DB9PR04MB9817.eurprd04.prod.outlook.com (2603:10a6:10:4f0::16)\n\tby PA1PR04MB11057.eurprd04.prod.outlook.com (2603:10a6:102:48f::22)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8813.19;\n\tWed, 4 Jun 2025 13:13:33 +0000","from DB9PR04MB9817.eurprd04.prod.outlook.com\n\t([fe80::144:cb06:336d:abb3]) by\n\tDB9PR04MB9817.eurprd04.prod.outlook.com\n\t([fe80::144:cb06:336d:abb3%4]) with mapi id 15.20.8769.033;\n\tWed, 4 Jun 2025 13:13:32 +0000"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"hPIwSROM\";\n\tdkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=NkCluYKQm7yWax/mO6IKC/vi3kTVgIiEaMJ/Yb6HVKRL6t7KPO/BmmhD+BDqnR3aFllQUHMmFs5bFN281MJ8lJ0wSEa5ilOOwnMoOJqFs0O99qW6wJTJJRUdLUY5wEFyl38k9ZEwlswcemhGrS0z2DLKYEvauAnealeW9wGjVj0PwdTrJX34v9olN+1WKiJ+AeVUHSze3HkbMPWuffeuEr1pswDbnP1ucO9NheAMLGP76ZYLanR8W3khl8gRBcQTKBoETjAHoVqtmSyAkXJntMcn+/LqejK+isI94S2DgSVSyIi/i1M5wKpO0T0W/iRYGr63shvfrLlPkbtFJN2V5g==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=4v3eY4QbRgNlE+oQbkrgwiQ+umj4LIYI+uzNyrbZuYU=;\n\tb=sdTKOr96GHyKuz2FYHokxFO0O1K/2fdgJo7vpwP0PNgADnDbvJFGvoq2XqI1MzR4aTX7pkMqGu+19D28fn+9dkkPRME51txCVWdW/Hm+C4ZXpc6buczP2Zx14Yy+4qXrOov7Rq1kAvw/RdpgUYziJHLBJnnl+kncZ7QFc7o743ztlwwCfpucr4PfySSYILRCtri09t/JjeD5FmMba1ieBo4vIxQbFabnQiotzEXJOlSQrEnzGEGCt+f820lype/ddRO4bZij1c2dT9nUVCPFuOoHy3mqfMkbUW8QXVEY4d7ZEKWoN4aWYftSYueuT8Hwc96azd7h7TDEkhX6p1QQFA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=4v3eY4QbRgNlE+oQbkrgwiQ+umj4LIYI+uzNyrbZuYU=;\n\tb=hPIwSROMLvGPipC0nSzRHv7kInZ3eKj/cM82ihJ3qFpb8au1M8dC5mPL/0VT1/UDvUqr4y8DqHNpmhvvxQFRGPuG76ooKqUfwGmm4Y/KTcHzp5m7ozyiIrJa+XATErl+mJ4COl/eWdyAUSRELFnCvV/4NDJ8cDMWyAhYaXUEpUhb/YxNzW7jlB3Ur9OQS3X6KAIzQXaw3g1KqO5MwO41UV0w1KkzHYz642aU8KASOl4DWQCXwLVvSsURKXt0Rhi1f4KJgC3mrbn2Bl9q0sf6Hb8qyhj488912fE86VXLlJ/HgtVDLDj1sfk3p7eYbgQ4A0wu6E3/Jt0PV7CQcdtoHA==","From":"Antoine Bouyer ","To":"libcamera-devel@lists.libcamera.org","Cc":"julien.vuillaumier@nxp.com,\n\tAntoine Bouyer ","Subject":"[PATCH 2/2] pipeline: imx8-isi: Fix match returned value in error\n\tcase","Date":"Wed, 4 Jun 2025 15:14:03 +0200","Message-Id":"<20250604131403.1729356-2-antoine.bouyer@nxp.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20250604131403.1729356-1-antoine.bouyer@nxp.com>","References":"<20250604131403.1729356-1-antoine.bouyer@nxp.com>","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-ClientProxiedBy":"BY5PR03CA0019.namprd03.prod.outlook.com\n\t(2603:10b6:a03:1e0::29) To DB9PR04MB9817.eurprd04.prod.outlook.com\n\t(2603:10a6:10:4f0::16)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DB9PR04MB9817:EE_|PA1PR04MB11057:EE_","X-MS-Office365-Filtering-Correlation-Id":"c524f712-dfe2-476e-14f4-08dda3699b0e","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n\tARA:13230040|1800799024|376014|52116014|366016|38350700014; ","X-Microsoft-Antispam-Message-Info":"47tQeYTA1DEe1DaMB6oH6E6KbISqjAEfm0e3MjaxSxFJOlsqNAwqkI/6nLdu3RtIHAau3JteLsPtelBg6q4Ny7aFNbFlQjLIg+TOiyztr54k4iIA8n8xbCgVhx8Jmwfh521AOzhmpH9nGfdbeU8HTPgtJ7afh9UldW033FefWGFRTXOyCALj4XRa2I+LmiLBWsPOlvqp8EVLnX8bMNvSGlH/X5hw905dMm/pnkYu28dAQRUHqzygrZ9pcW/sTwystyo3NegrprmN/cvxNfSHCETz3nJTHzen3pC0os20aRaGDfS6FFwEfrSo0WE1VqkSG1K+FTVDPgNFxC32+Vw43YvBTy2q2q5skIfmgKeExu9D4v8IjhgQ3ShQOwRCTQ2+uvhqFLmOC6nNkIaECJvmIoS1h/h+wteAzztBCS7SwV6Snd4730fGMEma+8QJ1pvfalDy8bPvxpm8RpAvf5VpqkM7mPFoalJXRetODNrofXwuVPoOQEGXnV9dpL7eMkpcL7AZpKAfUf9Gff8Wamo2Vki5Z8WShbxnT5ZwbWTv3nWvxIdqoZ4fcvh/iwsyel93KlEZw/sAedYTdU+bsw/KgvcPVFQphSDS7cMc+f4hEiJ+S/hZEows7wEwxszTrYrOgjNuW7So5PyV186tF2ZR77fIsZQzwJ4E+OoeAMUWp4yuMZddZJ8lY24odTxOGSkQ1+qgjDNVUmEiaUaw+xds3RIcvD08TEFchuoKRSfddNXESxofbkV1P0U1i0qYQOwQu5TN7Db4frZ99QOviVjHsp96Krf3oih7v6aiiv1PriC7VdG3r7ujiQYOpXJZGxe+8WCDo2vzBnVCt454vPhXPfRtj7qCHGzVOX+QlxxejKjDahJhgUwr7E1Gkay0sMKo4VqtezBjm1ylI4WK/iGxxYilgFco2anxL9InnvZ3x1OpRogrR4ptbWiKRI6ufWac2ywHidBpsI2HHz2JA8hBSG9GCdyQxy9yV3aZxhWws/FNfMDHfwkikVUMf+3Iaw3p2Ee78QOBbL9uyu3a4KjbNng7xUhcuAmOQMBb1gOGAvOujXaWa0GOTnH2KT/5NjZra6Y2CSlzKm3GzBTF+Xrlw4y5k2qQrcllU2yqvmuwvSORQ/0GVtNV1tkLZ+j3uVC5rCKD6Adoq+PwJm8+o47zelIFcjhK7xJQqouEtMOWPhc7OmFHcvLn2DPQe3UVeYKu8C3R1MwyEbP27jp4aonudxRpuJmsoJxTg50DlQXG6Z9pCYz14mkZjhcN1KDnhImC+ruJ9+JgOQCgLQTBvxr22ZUHPoKyltvy9NZlvrTlQdiWRre7lYGsa5e+SB+QSReFqrtFXHQn4aGQdv0ksKHuaexB1LnYXIHMU2SqJQ9dcjP3LCp4ZakkExFj5s2xb5wF0ZF+Y/5Aog4qj7ZYnWG/GY6Ofs9eLAdJOLCtcztMFVSg5nz4Y6rRhT5wWgIeeToMG/n5bTBs3eQ9q1NQ8Z/5ag==","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:DB9PR04MB9817.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);\n\tDIR:OUT; SFP:1101; ","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"JA85TrXkxvfs4rpWPFxQXzdEGjpCuCYKCt5Z9OI853Vm012vBj7vFBxlwkJykcSMKostJWiB37leXW2kUUz0oKqy1o5wa0WDILkk+7i3lq3HSqnDgapa+TY0aJrXtbjXMsU82APGH6YpsL8OFGGku8O7y03Y4byw8OPObuJ1/sSUPrGCU0iR7e7XUcJWpZPeSWHtAulFooSO66knaLc5lriSkcZMA/zSZafCzs0koakNQrqD2FrsGPZcG6Te51LZiFbMZHX7e0Vgv1Lb7oujco/iSmEzuFLC1npA9Usdp01sI+bF2cZ0kQX+6Sv8Js5RpYaHXEKTv3aHdCff4i4NWN4G6jmiY5Wghej+NMy8cUzOoK2y9OtAl1tSbXkX9LGYrjvSD1vQlg0dU4J/AArzLlXIcq1XMA6YTf7WgApmFRgbBFkdXCYxpMEvqNykneZHkMTobsnzb4L+7YOgqFCNLZlqcxbtJUG7tqSN+pFSnWE0yd9bqvmzfzYiWMSvjmxPV5SAyWL0TccXe1uDCgYEJ39NgS5DXz15jBXJur1keEdld/2eDu770p04OCV52ceRhope6R9oHyS/D49dEdhIXfXVhLmBYCnKNA1JeACX+3hcJkkPzUMYfYqr6sE/Lu148qx9WswCOBWQUrnj4IzzPKwX8xeucvXwHBXLHlup9j1FlGedifQp8F9zY7EaO1bDLD+UmQL0Fd8y1BmHA9fiP2bRZjN7TxzsXnXItPVxdLRZuyrTEipdSD7SDThJwgbGgZzZGgFvSRzYZj/snzOYBSi27FtC/z4IlUxlzyMivm0lxmN39TFZo/Kdi+3orcUBqZbcoyOIju2dwNeK0fuUMGUlX1XwBOcjTF0gSXW1F5nidR5cPed2toDmpaYm+EvyWiHp1oUM2erm3muyemD0pqORjBHbINXh75HM5riJmsnmyseihR2VUSoIXiZajAjgegO3jDKuN8zSDjEx9EqL3X8p9rvcpTcDXvkjG+B7sxq2fwCqOCKfm024/EfyWhvfbr3QbD+PMxny3hHZ8YpHnC7TRCDiXYXtgriXrhCu9/SOpmydRiVlD8g3gwoga8dW2p9XTqaHgaacoQKRVrs0FdcErGKmWFpxVdAz8jMUsntAm2HaqSHf3CkRX/oWZNs2Onfyc962XL12VExdgy72rIni80ZChEWPj9AxtQtYSI4jj6c8uNdNDpe/OTBOEwEneB30OGb/jajcDqDtyguV/yvCnFjL14AB+iCTmnz2ZSYxctV3lwItTwgvN6jKBHnz85Idvn8Fcozh/zdvXOJedDAzDju8+5znLVg84O+niXgmX43BgZhiOVilKa2u4Fldh7Uwtq2ZxQvElxphpoBrEwSj61lZ6z8OoU5WGZWdCYojhCnb27Djg8nHAY43UaeRaLL9X24Jabe1T/3MPyUTYZRCNDNXvICP2wIvPWnwGB71a74e7e4P77SoRmtKbG+Nj/yHM8Qj+aHoKqisQXWErlahlr0gR8wyVfKIUYAWffRCgg0vBS7lwVI8AqHWl6ekcxD5O7ZKQyevurjKcTxUypYOLUyNm3ML1AVZjsJSN9yCcASaGqEpHqjXKU9pZD/+H5N7mi8MpjZ4HoHCGAF0kw==","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"c524f712-dfe2-476e-14f4-08dda3699b0e","X-MS-Exchange-CrossTenant-AuthSource":"DB9PR04MB9817.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"04 Jun 2025 13:13:32.8036\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"4SP1F8Z5Bj1GLxrW+FwyGPA/n8SOJUqPnVZ7zFT3u8251uaqwvjR5lZ4vvYX/pI0OChSNreDun1LKM+cy/VEFA==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PA1PR04MB11057","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Match callback returns boolean type, while it could return int in case\nof error when opening the capture file.\nFixes: 0ec982d2108 (\"libcamera: pipeline: Add IMX8 ISI pipeline\")\n\nSigned-off-by: Antoine Bouyer \n---\n src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\nindex dc20ab2..1b7c661 100644\n--- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n+++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n@@ -1003,7 +1003,7 @@ bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)\n \n \t\tret = capture->open();\n \t\tif (ret)\n-\t\t\treturn ret;\n+\t\t\treturn false;\n \n \t\tpipes_.push_back({ std::move(isi), std::move(capture) });\n \t}\n","prefixes":["2/2"]}