[{"id":34409,"web_url":"https://patchwork.libcamera.org/comment/34409/","msgid":"<20250604132151.GC3755@pendragon.ideasonboard.com>","date":"2025-06-04T13:21:51","subject":"Re: [PATCH 1/2] pipeline: imx8-isi: Cosmetic changes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Antoine,\n\nThank you for the patch.\n\nOn Wed, Jun 04, 2025 at 03:14:02PM +0200, Antoine Bouyer wrote:\n> Change indentation to pass checkstyle script.\n\nThere should be a blank line here.\n\n> Fixes: 680cde600509 (\"libcamera: imx8-isi: Split Bayer/YUV config generation\")\n> \n\nAnd none here.\n\n> Signed-off-by: Antoine Bouyer \n> ---\n> src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 46 ++++++++++----------\n> 1 file changed, 22 insertions(+), 24 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> index ecda426..dc20ab2 100644\n> --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> @@ -761,30 +761,28 @@ PipelineHandlerISI::generateConfiguration(Camera *camera,\n> \t\t */\n> \t\tStreamConfiguration cfg;\n> \n> - switch (role) {\n> - case StreamRole::StillCapture:\n> - case StreamRole::Viewfinder:\n> - case StreamRole::VideoRecording: {\n> - Size size = role == StreamRole::StillCapture\n> - ? data->sensor_->resolution()\n> - : PipelineHandlerISI::kPreviewSize;\n> - cfg = generateYUVConfiguration(camera, size);\n> - if (cfg.pixelFormat.isValid())\n> - break;\n> -\n> -\n> - /*\n> - * Fallback to use a Bayer format if that's what the\n> - * sensor supports.\n> - */\n> - [[fallthrough]];\n> -\n> -\t\t }\n> -\n> - case StreamRole::Raw: {\n> - cfg = generateRawConfiguration(camera);\n> - break;\n> - }\n> +\t\tswitch (role) {\n> +\t\tcase StreamRole::StillCapture:\n> +\t\tcase StreamRole::Viewfinder:\n> +\t\tcase StreamRole::VideoRecording: {\n> +\t\t\tSize size = role == StreamRole::StillCapture\n> +\t\t\t\t\t ? data->sensor_->resolution()\n> +\t\t\t\t\t : PipelineHandlerISI::kPreviewSize;\n\nThis is one of clang-format false-positives :-/ It should be\n\n\t\t\tSize size = role == StreamRole::StillCapture\n\t\t\t\t ? data->sensor_->resolution()\n\t\t\t\t : PipelineHandlerISI::kPreviewSize;\n\nNo need to resubmit the patch, I'll make the adjustements locally.\n\nReviewed-by: Laurent Pinchart \n\n> +\t\t\tcfg = generateYUVConfiguration(camera, size);\n> +\t\t\tif (cfg.pixelFormat.isValid())\n> +\t\t\t\tbreak;\n> +\n> +\t\t\t/*\n> +\t\t\t * Fallback to use a Bayer format if that's what the\n> +\t\t\t * sensor supports.\n> +\t\t\t */\n> +\t\t\t[[fallthrough]];\n> +\t\t}\n> +\n> +\t\tcase StreamRole::Raw: {\n> +\t\t\tcfg = generateRawConfiguration(camera);\n> +\t\t\tbreak;\n> +\t\t}\n> \n> \t\tdefault:\n> \t\t\tLOG(ISI, Error) << \"Requested stream role not supported: \" << role;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 373F0C31E9\n\tfor ;\n\tWed, 4 Jun 2025 13:22:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B2B068DB3;\n\tWed, 4 Jun 2025 15:22:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E3B768DA8\n\tfor ;\n\tWed, 4 Jun 2025 15:22:01 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3D37978C;\n\tWed, 4 Jun 2025 15:21:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LRoP8v2/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749043318;\n\tbh=6b9nnZp+RjCKM0Un0e5dowwL6dyPnulMhmdA5wuTT4Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LRoP8v2/7t005HuCz9yjbNidcEsMUitH6OBopHm4smNK16mNdJLZzgE4jTDABNour\n\tYfw5UXMkTE7+e6qNzQWHPfWDzjAJuALsoEiZMXzEY9GsNoU0Jc4LUnoQu72eZv5cWe\n\tVfRkfD5zSbH3Py8FrV3wfBb2vF/Fy1sGOFMbcM2g=","Date":"Wed, 4 Jun 2025 16:21:51 +0300","From":"Laurent Pinchart ","To":"Antoine Bouyer ","Cc":"libcamera-devel@lists.libcamera.org, julien.vuillaumier@nxp.com","Subject":"Re: [PATCH 1/2] pipeline: imx8-isi: Cosmetic changes","Message-ID":"<20250604132151.GC3755@pendragon.ideasonboard.com>","References":"<20250604131403.1729356-1-antoine.bouyer@nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250604131403.1729356-1-antoine.bouyer@nxp.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]