{"id":23469,"url":"https://patchwork.libcamera.org/api/patches/23469/?format=json","web_url":"https://patchwork.libcamera.org/patch/23469/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250604131403.1729356-1-antoine.bouyer@nxp.com>","date":"2025-06-04T13:14:02","name":"[1/2] pipeline: imx8-isi: Cosmetic changes","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0023bdb27b9b0733c959cb39bd1df4046c4bdb34","submitter":{"id":218,"url":"https://patchwork.libcamera.org/api/people/218/?format=json","name":"Antoine Bouyer","email":"antoine.bouyer@nxp.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23469/mbox/","series":[{"id":5205,"url":"https://patchwork.libcamera.org/api/series/5205/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5205","date":"2025-06-04T13:14:02","name":"[1/2] pipeline: imx8-isi: Cosmetic changes","version":1,"mbox":"https://patchwork.libcamera.org/series/5205/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23469/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23469/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 46DD2C3237\n\tfor ;\n\tWed, 4 Jun 2025 13:13:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D64768DC0;\n\tWed, 4 Jun 2025 15:13:30 +0200 (CEST)","from AS8PR03CU001.outbound.protection.outlook.com\n\t(mail-westeuropeazlp170120005.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:c201::5])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0408168DB3\n\tfor ;\n\tWed, 4 Jun 2025 15:13:28 +0200 (CEST)","from DB9PR04MB9817.eurprd04.prod.outlook.com (2603:10a6:10:4f0::16)\n\tby PA1PR04MB11057.eurprd04.prod.outlook.com (2603:10a6:102:48f::22)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8813.19;\n\tWed, 4 Jun 2025 13:13:27 +0000","from DB9PR04MB9817.eurprd04.prod.outlook.com\n\t([fe80::144:cb06:336d:abb3]) by\n\tDB9PR04MB9817.eurprd04.prod.outlook.com\n\t([fe80::144:cb06:336d:abb3%4]) with mapi id 15.20.8769.033;\n\tWed, 4 Jun 2025 13:13:27 +0000"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"Qe5HbtFx\";\n\tdkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=NsdT++JcBnrHv5I6dQ6WOnokWB8ODGYA18h0tut4GR5BKrFyGDvSWC/1pFdGIT5Hy54snu+gkORPd54WwxL4FdSW4nZroZBExc67POFmJlf+6sNgfuM2MmlBSfC8u7YQE18rcxzqn911iUlhycGFi+OnPujRTECMWCqF3NHxThMW5BhPP08CSljMT2OyTg3h/zT3DhDzIZ8G3Xga2oBNPVMzJFKnH74SJVA8Mc53rO51ZX3lMuZnJIR5FKDTw9OEkxFT8pvsi7JC4D/nTNwtH28cupUlxY6BRB0u6KbpCizAHt7EDwBuPlN6uaUlk49jhRU6+R6HHYwbGS9HVfG57w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=VN6lxGHn9HoP4cXq8Z0jSd1IJ4C/UikCVuG43QqIH38=;\n\tb=P87hOtKzA1hAXulSakH4w4WQCNwTICPQjrnd+dMFp21DteemuCl+u9/qEj/xvIZgpjZLaQqxieNAglp51gBkCKXz1OOyaIc7MAiBv7vlmNNowJG7+bsR5xgGT87mWRZxMae6t9R4Xz2yHfYV52ufvcEsbVz+DGecRmJknFdFaO40zgBh32+O13YhF3kSv7CVSgXU4puRtZ7L3sFxFzBqRoX/TreCQxXhm3Lz02xnFHD9g4W50d0Z4Isf0wAc7C/8WSGLgPzSmCm9rlJKXQOXMGMTKdw0hj8MSwQnXCAWWhq1rhj054pAcU+y86wOEACbnE4YDD+noHE6pzW6U6HIBQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=VN6lxGHn9HoP4cXq8Z0jSd1IJ4C/UikCVuG43QqIH38=;\n\tb=Qe5HbtFxjKxiVVE8kgLjT0gYRTbiPeOkJMS9fck0qdoRAmCpc+UJ5rz6vIL0Z7wkyrP5/hBbxhGpQr7U8hLg9q16F1OdedX8iOGFeAzBByxl2mMzZVpWGKxzdIDBr4jeVOSNCu9Ua78QPBZlzpY93vh6dzS/L3PJQLdH6AZzB+qK3Z7TF1xVy1ro3q4Y1/7ItfJVlDd3KWJNLsbs/o+0KFccr76PkLCCElMrmMJIn8g0T0SmFhhCJwM0vgVP8vyL+Aa1aFLKlIyE4m/uXpSnCwYeFw8Iky2FVICiFWC1XBu+pmjr0DRoVGoCqMrUpRon/Sd/H7sP0H4TkUMfCiP9QQ==","From":"Antoine Bouyer ","To":"libcamera-devel@lists.libcamera.org","Cc":"julien.vuillaumier@nxp.com,\n\tAntoine Bouyer ","Subject":"[PATCH 1/2] pipeline: imx8-isi: Cosmetic changes","Date":"Wed, 4 Jun 2025 15:14:02 +0200","Message-Id":"<20250604131403.1729356-1-antoine.bouyer@nxp.com>","X-Mailer":"git-send-email 2.34.1","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-ClientProxiedBy":"BY5PR03CA0019.namprd03.prod.outlook.com\n\t(2603:10b6:a03:1e0::29) To DB9PR04MB9817.eurprd04.prod.outlook.com\n\t(2603:10a6:10:4f0::16)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DB9PR04MB9817:EE_|PA1PR04MB11057:EE_","X-MS-Office365-Filtering-Correlation-Id":"5724ef3b-9da3-4c5a-4e00-08dda36997a2","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n\tARA:13230040|1800799024|376014|52116014|366016|38350700014; ","X-Microsoft-Antispam-Message-Info":"eEJaTUyC+00XvsA228GE91fYyAeWXtwQ9LZ7ql7AOvgqgt0/oUwioa/tDbRRXW0GJwq/w1B7ihn6IRFI+2iC3srrMN1aSMTnCCdxbfpVlF7OQ6DastnHaE6TQd65kXKpnyNy0oc0rUEUQ5q2pHC05dEhlYcy909gtRjjVul+BQ2NIoGa66IbBckIHenNBX++2K2oRTxcKFWyQYoDISl7ffVwm/4qNy+siDDVFtMQJnkidA1dZyYFbg2MfnHj2n/LEGFLxX81ULYt6kxB//rOJQFLQC7v3Rk3/qk0XYk95WjLUAGm++ZV8Tv1Bac4Wee7zciOwT4OF+IOVTNjlxqzIsd/S5L9kbFj7kKbxxRoq6z8RI19VJgkoMkcT3mjX8t0i3+KbVNCzpMVPiwgOGffP3wj9oGKToBFZIAVKbqBvkWN23lF9alef42zhU3ldsKyGzljEvwX5hP0SzSxSRMKkhW1aGw4/n9hcZnEU9FdD+iRgo8MRkAK84OPclCYmSj+FiffM+kfipYgVabmwFsRpgInSifNnXtLttvNzdfYTYZ4CDumpBkkP8Vt7Yw9EMEHm0EAnHZZZFHJpE7WfR+dEnz7rnnXGXsYrRKAMc4Ewu2vtakf4I2YGg62h46ZFI66670IpwWKh/0DpANAH4QKXzvDGm+6bkFyE4wO39bH1RpQ7ASunGMdn4OO6pg5sRHvWx3FPaTjXrE9OU8+fcnvMR9k3YkGE1cN5IgErQos3JxewI2yq9pwnoyr4fu+wk+z4Z6Fub/l25U04RPkLuKWHNev01pkwy5ORhpGaN9p9xGOnceZ1QmioQ1eL7n5bCdtij8QS0605g8xQ9IO5jb5Gk7hCUEwSIPrOhxlgGlIgivi5/b1olX1tZN0Ucnz3im6Qh6cw6MFqKIWoN6UFEuYod2O/A48tDUfxbTMsWKvj7z2TSDOxh+6i8QgvGa8hBgeczc/tVtYQ2JBRVy/LcdJEg02M3E2I/oS1XEUkqDHFdFs5UTq1dFZxWmIV31nXnd3HBpR8mZs0IGOZV9zeUviVRiT9A6C8k+z/vlI92Mj75deYYQt5AImDbMriuXP3kCPh5f8Hv7qcjjXrovQvXnGjhjyFDuwEnAugQEj9PBxCWszgm7gdE+E9cBxgL1N/22Ouv6v0Xke8/ds/fcEbd2g+mVKeMYU1ZAgxmo5gXzXZZscjAyZ25CMUdL3Nu5MM2oX4M9rhFW5SVq24oVRT+g24DdyOtKQAKpXUu05Gfcdk4ZfT0GOnD1JncXQLaTRPpOdaUN0vEeq4P//E+02rTZB8wzb1MT+19dhDzagzXMAIwrmixbZYanI+jh+Q3m2nbL/gNGzUpA9Qjz8MCzwNWmx/c5MJ7VDPH/WuD+qebvlURLqyW+ZgwPB1k64ZBegEcnq7+St6SN6vxg41wTsrU5Y/KqI3bE8cRmY5yXXLPesidFkw4cWi05Mvs6PBu4C+WhnAVLMR81VS7G6rOtFVNJBnA==","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:DB9PR04MB9817.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);\n\tDIR:OUT; SFP:1101; ","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"G0InHjYy73oBRW4gntDfN7EnqQe/1kiVXN20G32ZWgkL7GqC0xsI2R8/UEfT3XxnlKABVW2iR436h8wZ6uoSQR3Wc3HYVyrox8iNcLVrIFZexmE3C8F+9EGVCBQVfgv1VYsfwNXZ63ZnnCYBgRtpaFfX0Iahqb+a410kFc5mYwz0CiDeNn+tGZUljAFoATuaHNRFVnqPIgEPu4UPr2fAywnuwBjT9Pelu5VOgSUdh0OuYy/fnblthDWnWOJTfDTRgckktpWro/tmb8OI+Z8dfFepNI5HRyoggKcATnUkicpDd7/ndTLZ8cuTfajQuRQV6iQVT6AL/nu/c/D/3ft6b5z6Q7zQGA99pAFd5jMJ0y7l8iF3mCDg7B7CLOYaT3+RzpscDaopy/bDHQZ4vx9Vk2ULV+Uze/BQCB/D7jlpM3lGuGbeF6w57faumz72OwHcfpJk5pbCaAEl/MHYtTPmv5virgku9mmCL2xHH58rOSNA6RNMxNebzzQ9XN5EDm9aqfgI974FXBbqra2r/Ho749CkgRJi/y1EYs6VcL9E40MaxaX2vv8FNBwTBZBO8AiYpSefGDvF8trpnZ6u+eYmx11iNsWVMf57uGWwE52SmmR+8riTcp05IocWra9TuAgJdAHFpn+UtE33Jx4L8bjEWxrzgQNb1peL++Dv1fLyXO/3gS4K9ycI5ckYmKuUtHy+T4aXtsdmrswuezGv6YZxhfECVUhS9Ju94YjS43nam/LTyozIPBQkvMBHT4JbhpV1ZeXiz5j4SFopN7SNIjuoXBYjQY0gIDQGmvr0kq3PfwyLBI26y2goNzTTt6Zhw1V/n7WBTS9+V1QO5D2H3FTDumoKOLpaGIc6FFKJ8Fksk6aUJTnm41KIy4BMvWPsVVzQh+23aZVaiJXAl43D+0j2aLkXJkyL4irECqALNKwBl62blEmM8ohDTRJv4KnItxogP3rezY+hGNAdU66dfHUbi3dJ3K6FObQe51VLJOugOT/shqYniPherStkY+2M5rIZENTYJXj0t0NH8Rzrc2YNN4UinhM++Y3u/MWdV2gy0rAvbH9/6IRhD+lpIC9HNQ4LFoHMNd0KHTqwdOWXqYzaYpri4adHMxcjezXpBojVhxxb5ldTC+6/2ubzTDdfDxGV3i4SPlLaBd0b6jrVTTKGolC8p3BFcnzPuXSf+bioV7YRvnHASLwF7cxI4bM0VYRn05KDHo4p4ag8R1UajotE711wCPYDfRJZiVyZnrJJ8F98yyAeVc1lgJY/iyRDfgtTBHXHyLr84qjkPOaVPQ+6SX1Nh0VvZb/4rMU6GGffVIBf45L+uXVt81dNRYllGEEbQf3Lf8BO3G5ortWCFlmNTN0CWpGpjMmPVzVc8Iz71af/uRq34VBQGTc81uA1EMdm/9GdYL73zUQOOge3qNoAhowpPJmqaELJJBxWCVv/f9MW3AcZky+ZMHagarE5yczZJzZa6Vs6WV06mq5DkSb4iKvWeRuKRxX/qHpIcXtBLTZ9VZLVjheycroBl38HwnXgRRCuqNjDd/+Ok9RaIWyw5CID0B3fslS4WdNTchi7piYlDf/pyu652c4UMTL5A2k3CZferT1Un/TATHZJAGOZPg==","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"5724ef3b-9da3-4c5a-4e00-08dda36997a2","X-MS-Exchange-CrossTenant-AuthSource":"DB9PR04MB9817.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"04 Jun 2025 13:13:27.1350\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"ctPOEvSS5yEAnI3l6dzHRGm0jo2QepcAv+WVSMwCYvtdsA7EykKVcP5Vmgj847WEcmQpu/wYAL38DbhvpXUq0w==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PA1PR04MB11057","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Change indentation to pass checkstyle script.\nFixes: 680cde600509 (\"libcamera: imx8-isi: Split Bayer/YUV config generation\")\n\nSigned-off-by: Antoine Bouyer \n---\n src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 46 ++++++++++----------\n 1 file changed, 22 insertions(+), 24 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\nindex ecda426..dc20ab2 100644\n--- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n+++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n@@ -761,30 +761,28 @@ PipelineHandlerISI::generateConfiguration(Camera *camera,\n \t\t */\n \t\tStreamConfiguration cfg;\n \n- switch (role) {\n- case StreamRole::StillCapture:\n- case StreamRole::Viewfinder:\n- case StreamRole::VideoRecording: {\n- Size size = role == StreamRole::StillCapture\n- ? data->sensor_->resolution()\n- : PipelineHandlerISI::kPreviewSize;\n- cfg = generateYUVConfiguration(camera, size);\n- if (cfg.pixelFormat.isValid())\n- break;\n-\n-\n- /*\n- * Fallback to use a Bayer format if that's what the\n- * sensor supports.\n- */\n- [[fallthrough]];\n-\n-\t\t }\n-\n- case StreamRole::Raw: {\n- cfg = generateRawConfiguration(camera);\n- break;\n- }\n+\t\tswitch (role) {\n+\t\tcase StreamRole::StillCapture:\n+\t\tcase StreamRole::Viewfinder:\n+\t\tcase StreamRole::VideoRecording: {\n+\t\t\tSize size = role == StreamRole::StillCapture\n+\t\t\t\t\t ? data->sensor_->resolution()\n+\t\t\t\t\t : PipelineHandlerISI::kPreviewSize;\n+\t\t\tcfg = generateYUVConfiguration(camera, size);\n+\t\t\tif (cfg.pixelFormat.isValid())\n+\t\t\t\tbreak;\n+\n+\t\t\t/*\n+\t\t\t * Fallback to use a Bayer format if that's what the\n+\t\t\t * sensor supports.\n+\t\t\t */\n+\t\t\t[[fallthrough]];\n+\t\t}\n+\n+\t\tcase StreamRole::Raw: {\n+\t\t\tcfg = generateRawConfiguration(camera);\n+\t\t\tbreak;\n+\t\t}\n \n \t\tdefault:\n \t\t\tLOG(ISI, Error) << \"Requested stream role not supported: \" << role;\n","prefixes":["1/2"]}