[{"id":34364,"web_url":"https://patchwork.libcamera.org/comment/34364/","msgid":"<174836183971.896144.1883053507602240852@ping.linuxembedded.co.uk>","date":"2025-05-27T16:03:59","subject":"Re: [PATCH v4 1/2] libcamera: process: Use _exit in child process","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Julien Vuillaumier (2025-05-27 16:56:14)\n> Use _exit() in child process in case of execv() error. That is to\n> avoid interfering with the parent process as exit() may call its\n> atexit() handlers and flush its io buffers.\n> \n> Signed-off-by: Julien Vuillaumier \n> ---\n> src/libcamera/process.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\n> index 68fad327..7f3a6518 100644\n> --- a/src/libcamera/process.cpp\n> +++ b/src/libcamera/process.cpp\n> @@ -274,7 +274,7 @@ int Process::start(const std::string &path,\n> \n> execv(path.c_str(), (char **)argv);\n> \n> - exit(EXIT_FAILURE);\n> + _exit(EXIT_FAILURE);\n\nReviewed-by: Kieran Bingham \n\n> }\n> }\n> \n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 182A3C31E9\n\tfor ;\n\tTue, 27 May 2025 16:04:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 32F0668D99;\n\tTue, 27 May 2025 18:04:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E5C568D94\n\tfor ;\n\tTue, 27 May 2025 18:04:02 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 47CCE725;\n\tTue, 27 May 2025 18:03:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r5dc4+Ly\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1748361816;\n\tbh=3DOLijkmyJGzDmOLbUYaE+eX3LvKG0xN6X2CjM3g5hA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=r5dc4+LyUqHj+Ep1LIXYMuCECe0x+5N1rKqM0f30ePC/IFjAK2HtGDoBa5EF/CQDI\n\t1H0t3c0F17HJHiUePDNcjzyYVbcSfRr7cnzLUYyHzC6PfpVwqfgg3CaFJ+iya0XLig\n\t3e2bA1pHtGQNSdPBpNzU5sGOQr57U46yQ2js2wu0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250527155615.560463-2-julien.vuillaumier@nxp.com>","References":"<20250527155615.560463-1-julien.vuillaumier@nxp.com>\n\t<20250527155615.560463-2-julien.vuillaumier@nxp.com>","Subject":"Re: [PATCH v4 1/2] libcamera: process: Use _exit in child process","From":"Kieran Bingham ","Cc":"Julien Vuillaumier ","To":"Julien Vuillaumier ,\n\tbarnabas.pocze@ideasonboard.com, libcamera-devel@lists.libcamera.org, \n\tpaul.elder@ideasonboard.com","Date":"Tue, 27 May 2025 17:03:59 +0100","Message-ID":"<174836183971.896144.1883053507602240852@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34377,"web_url":"https://patchwork.libcamera.org/comment/34377/","msgid":"<174851541576.1701332.16716182752836185248@neptunite.rasen.tech>","date":"2025-05-29T10:43:35","subject":"Re: [PATCH v4 1/2] libcamera: process: Use _exit in child process","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Julien Vuillaumier (2025-05-28 00:56:14)\n> Use _exit() in child process in case of execv() error. That is to\n> avoid interfering with the parent process as exit() may call its\n> atexit() handlers and flush its io buffers.\n> \n> Signed-off-by: Julien Vuillaumier \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/process.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\n> index 68fad327..7f3a6518 100644\n> --- a/src/libcamera/process.cpp\n> +++ b/src/libcamera/process.cpp\n> @@ -274,7 +274,7 @@ int Process::start(const std::string &path,\n> \n> execv(path.c_str(), (char **)argv);\n> \n> - exit(EXIT_FAILURE);\n> + _exit(EXIT_FAILURE);\n> }\n> }\n> \n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B353DC31E9\n\tfor ;\n\tThu, 29 May 2025 10:43:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7C90B68DA6;\n\tThu, 29 May 2025 12:43:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8AE0B614CE\n\tfor ;\n\tThu, 29 May 2025 12:43:42 +0200 (CEST)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:1f92:82d9:ed1e:dc8a])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id F36B86D5;\n\tThu, 29 May 2025 12:43:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M91ZqCT/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1748515395;\n\tbh=0SDajIUoXlzCJlPPM9QKlQqIp/SFZnmwJWxvfeDCIlw=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=M91ZqCT/NAKUag0BfvMHDxE0LSWULecuufba/BTYdsmWsVoFF24rGddnDpVqrMFdT\n\tH1BkkxeVqxuO75KNZGVUE8DFyKMWsDYVw2Spi8Fosj4rU5Iue9CzcVCNKISeiEejE/\n\tJkGj80I6mOECZH7+pQNkeKp1XfTgid82Amvid1Hk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250527155615.560463-2-julien.vuillaumier@nxp.com>","References":"<20250527155615.560463-1-julien.vuillaumier@nxp.com>\n\t<20250527155615.560463-2-julien.vuillaumier@nxp.com>","Subject":"Re: [PATCH v4 1/2] libcamera: process: Use _exit in child process","From":"Paul Elder ","Cc":"Julien Vuillaumier ","To":"Julien Vuillaumier ,\n\tbarnabas.pocze@ideasonboard.com, libcamera-devel@lists.libcamera.org","Date":"Thu, 29 May 2025 19:43:35 +0900","Message-ID":"<174851541576.1701332.16716182752836185248@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]