[{"id":3134,"web_url":"https://patchwork.libcamera.org/comment/3134/","msgid":"<20191123101612.m5uldcnfrfqmwuao@uno.localdomain>","date":"2019-11-23T10:16:12","subject":"Re: [libcamera-devel] [PATCH] cam: options: Fix unitialized\n\tvariable warning","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sat, Nov 23, 2019 at 10:36:51AM +0200, Laurent Pinchart wrote:\n> gcc 8 and 9 complain about the OptionValue::integer_ member being\n> possibly used initialized when compiled in release mode. I haven't been\n> able to find where this could be the case, and the compiler error\n> message isn't helpful:\n>\n> In file included from ../../src/cam/options.cpp:14:\n> ../../src/cam/options.h: In member function ‘bool OptionsBase::parseValue(const T&, const Option&, const char*) [with T = std::__cxx11::basic_string]’:\n> ../../src/cam/options.h:84:7: error: ‘.OptionValue::integer_’ may be used uninitialized in this function [-Werror=maybe-uninitialized]\n> class OptionValue\n> ^~~~~~~~~~~\n> ../../src/cam/options.h: In member function ‘bool OptionsBase::parseValue(const T&, const Option&, const char*) [with T = int]’:\n> ../../src/cam/options.h:84:7: error: ‘.OptionValue::integer_’ may be used uninitialized in this function [-Werror=maybe-uninitialized]\n> class OptionValue\n> ^~~~~~~~~~~\n>\n> Furthermore valgrind doesn't report any issue. This is likely a false\n> positive, but fix it nonetheless as the fix is cheap.\n\nPossibly, but let's silence it anyway. It won't hurt for sure.\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/cam/options.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/cam/options.cpp b/src/cam/options.cpp\n> index 7e2dfa636ccf..186e853c8294 100644\n> --- a/src/cam/options.cpp\n> +++ b/src/cam/options.cpp\n> @@ -260,17 +260,17 @@ OptionValue::OptionValue(int value)\n> }\n>\n> OptionValue::OptionValue(const char *value)\n> -\t: type_(ValueString), string_(value)\n> +\t: type_(ValueString), integer_(0), string_(value)\n> {\n> }\n>\n> OptionValue::OptionValue(const std::string &value)\n> -\t: type_(ValueString), string_(value)\n> +\t: type_(ValueString), integer_(0), string_(value)\n> {\n> }\n>\n> OptionValue::OptionValue(const KeyValueParser::Options &value)\n> -\t: type_(ValueKeyValue), keyValues_(value)\n> +\t: type_(ValueKeyValue), integer_(0), keyValues_(value)\n> {\n> }\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C04E66136B\n\tfor ;\n\tSat, 23 Nov 2019 11:14:12 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 3FE5B20002;\n\tSat, 23 Nov 2019 10:14:12 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Sat, 23 Nov 2019 11:16:12 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191123101612.m5uldcnfrfqmwuao@uno.localdomain>","References":"<20191123083651.6944-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"txoke73imeoaw5lr\"","Content-Disposition":"inline","In-Reply-To":"<20191123083651.6944-1-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH] cam: options: Fix unitialized\n\tvariable warning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 23 Nov 2019 10:14:12 -0000"}},{"id":3136,"web_url":"https://patchwork.libcamera.org/comment/3136/","msgid":"","date":"2019-11-25T11:14:09","subject":"Re: [libcamera-devel] [PATCH] cam: options: Fix unitialized\n\tvariable warning","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 23/11/2019 10:16, Jacopo Mondi wrote:\n> Hi Laurent,\n> \n> On Sat, Nov 23, 2019 at 10:36:51AM +0200, Laurent Pinchart wrote:\n>> gcc 8 and 9 complain about the OptionValue::integer_ member being\n>> possibly used initialized when compiled in release mode. I haven't been\n>> able to find where this could be the case, and the compiler error\n>> message isn't helpful:\n>>\n>> In file included from ../../src/cam/options.cpp:14:\n>> ../../src/cam/options.h: In member function ‘bool OptionsBase::parseValue(const T&, const Option&, const char*) [with T = std::__cxx11::basic_string]’:\n>> ../../src/cam/options.h:84:7: error: ‘.OptionValue::integer_’ may be used uninitialized in this function [-Werror=maybe-uninitialized]\n>> class OptionValue\n>> ^~~~~~~~~~~\n>> ../../src/cam/options.h: In member function ‘bool OptionsBase::parseValue(const T&, const Option&, const char*) [with T = int]’:\n>> ../../src/cam/options.h:84:7: error: ‘.OptionValue::integer_’ may be used uninitialized in this function [-Werror=maybe-uninitialized]\n>> class OptionValue\n>> ^~~~~~~~~~~\n>>\n>> Furthermore valgrind doesn't report any issue. This is likely a false\n>> positive, but fix it nonetheless as the fix is cheap.\n> \n> Possibly, but let's silence it anyway. It won't hurt for sure.\n> \n> Reviewed-by: Jacopo Mondi \n\nOptionValue is indeed leaving the integer_ uninitialised in it's non-int\nconstructors, though I can't see that it is being used without calling\nthrough the (int) constructor which /would/ initialise it.\n\nUnless perhaps it's because of one of the templated base class usages?\n\n> Template class OptionsBase;\n\n> class OptionsParser\n> {\n> public:\n> class Options : public OptionsBase\n> \n\nAnyway, initialising it seems the 'correct' thing to do, though I really\ncan't see that it could be used.\n\nBut it's likely hard for the compiler to 'prove' that.\n\nReviewed-by: Kieran Bingham \n\n\n> \n> Thanks\n> j\n> \n>>\n>> Signed-off-by: Laurent Pinchart \n>> ---\n>> src/cam/options.cpp | 6 +++---\n>> 1 file changed, 3 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/src/cam/options.cpp b/src/cam/options.cpp\n>> index 7e2dfa636ccf..186e853c8294 100644\n>> --- a/src/cam/options.cpp\n>> +++ b/src/cam/options.cpp\n\nShould this be initialised on the default constructor too for completeness?\n\nOptionValue::OptionValue()\n : type_(ValueNone)\n{\n}\n\n>> @@ -260,17 +260,17 @@ OptionValue::OptionValue(int value)\n>> }\n>>\n>> OptionValue::OptionValue(const char *value)\n>> -\t: type_(ValueString), string_(value)\n>> +\t: type_(ValueString), integer_(0), string_(value)\n>> {\n>> }\n>>\n>> OptionValue::OptionValue(const std::string &value)\n>> -\t: type_(ValueString), string_(value)\n>> +\t: type_(ValueString), integer_(0), string_(value)\n>> {\n>> }\n>>\n>> OptionValue::OptionValue(const KeyValueParser::Options &value)\n>> -\t: type_(ValueKeyValue), keyValues_(value)\n>> +\t: type_(ValueKeyValue), integer_(0), keyValues_(value)\n>> {\n>> }\n>>\n>> --\n>> Regards,\n>>\n>> Laurent Pinchart\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 64A3E60C21\n\tfor ;\n\tMon, 25 Nov 2019 12:14:12 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A2540729;\n\tMon, 25 Nov 2019 12:14:11 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1574680451;\n\tbh=Lxu9dUM4ZtMrYPCwLkVy4ked2FZ6rGjkJQQ92BJWIos=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=MqXuY1vdXeMFUvMOFhkXVyyxJ/KEqUOg+wwhqmrsdOmti1/uFapnegJucSKtDHbGk\n\txCb9N36LhHSKn9zTp4Mx3z+VsVgCBNBlF8spoB9we79TGjK18EhHCaJThat1Afeb1f\n\tdQB9YuXa4c/nKTkMOicAFj45gxGJNg+tW+O68xRY=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Jacopo Mondi ,\n\tLaurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20191123083651.6944-1-laurent.pinchart@ideasonboard.com>\n\t<20191123101612.m5uldcnfrfqmwuao@uno.localdomain>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 25 Nov 2019 11:14:09 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.0","MIME-Version":"1.0","In-Reply-To":"<20191123101612.m5uldcnfrfqmwuao@uno.localdomain>","Content-Type":"text/plain; charset=windows-1252","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] cam: options: Fix unitialized\n\tvariable warning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 25 Nov 2019 11:14:12 -0000"}}]