{"id":23442,"url":"https://patchwork.libcamera.org/api/patches/23442/?format=json","web_url":"https://patchwork.libcamera.org/patch/23442/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250526101536.29222-12-mzamazal@redhat.com>","date":"2025-05-26T10:15:31","name":"[v6,11/12] libcamera: simple: Require metadata only when software ISP is used","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"adf57768443f08befa8495a3913c97b599410b7f","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23442/mbox/","series":[{"id":5194,"url":"https://patchwork.libcamera.org/api/series/5194/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5194","date":"2025-05-26T10:15:20","name":"Enable raw streams with software ISP","version":6,"mbox":"https://patchwork.libcamera.org/series/5194/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23442/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23442/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3E6B5C31E9\n\tfor ;\n\tMon, 26 May 2025 10:16:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB4C768DB3;\n\tMon, 26 May 2025 12:16:26 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3116168DAD\n\tfor ;\n\tMon, 26 May 2025 12:16:21 +0200 (CEST)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-61-QTLp1sSpPx-_OaaY6O_WfA-1;\n\tMon, 26 May 2025 06:16:16 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id E297C1800258; Mon, 26 May 2025 10:16:14 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.226.78])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 70CCE1800DB9; Mon, 26 May 2025 10:16:12 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"MzAdcp30\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1748254579;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=g/Fgsi/1Vjgv6ktQbjZDpT87JK1eHNJ5x8rTeCKQeJU=;\n\tb=MzAdcp30G4vvOZmBvpDBchVeklUKk7HFqCmJRLU2nhFXooCWvJozw/1cW/EJAJlD92DiGb\n\tjtEv4HMZnPywC8O5t1VAp0YEk53qNZmfmD3/3A741wjSWHJUNaDhb9qJbfpORGUqX8oxcB\n\tw9Lk37co/w/XscOVH2ecA5Wq8+tppgM=","X-MC-Unique":"QTLp1sSpPx-_OaaY6O_WfA-1","X-Mimecast-MFC-AGG-ID":"QTLp1sSpPx-_OaaY6O_WfA_1748254575","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Laurent Pinchart\n\t, Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Paul Elder\n\t","Subject":"[PATCH v6 11/12] libcamera: simple: Require metadata only when\n\tsoftware ISP is used","Date":"Mon, 26 May 2025 12:15:31 +0200","Message-ID":"<20250526101536.29222-12-mzamazal@redhat.com>","In-Reply-To":"<20250526101536.29222-1-mzamazal@redhat.com>","References":"<20250526101536.29222-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"VcuDx56w9AZQF5wyNzIabBExDgVMNc7Md-bIIS9APQs_1748254575","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If software ISP is enabled then metadata is required in the simple\npipeline. But this doesn't apply if the software ISP is not actually\nused, for example when only a raw stream is produced. Then the pipeline\nwaits for metadata that never comes.\n\nThis patch fixes the problem by requiring metadata only when software\nISP is used.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/pipeline/simple/simple.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 92953cf1..c7b05f66 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1661,6 +1661,7 @@ int SimplePipelineHandler::queueRequestDevice(Camera *camera, Request *request)\n \tint ret;\n \n \tstd::map buffers;\n+\tbool metadataRequired = false;\n \n \tfor (auto &[stream, buffer] : request->buffers()) {\n \t\t/*\n@@ -1670,6 +1671,7 @@ int SimplePipelineHandler::queueRequestDevice(Camera *camera, Request *request)\n \t\t */\n \t\tif (data->useConversion_) {\n \t\t\tbuffers.emplace(stream, buffer);\n+\t\t\tmetadataRequired = !!data->swIsp_;\n \t\t} else {\n \t\t\tret = data->video_->queueBuffer(buffer);\n \t\t\tif (ret < 0)\n@@ -1677,7 +1679,7 @@ int SimplePipelineHandler::queueRequestDevice(Camera *camera, Request *request)\n \t\t}\n \t}\n \n-\tdata->frameInfo_.create(request, !!data->swIsp_);\n+\tdata->frameInfo_.create(request, metadataRequired);\n \tif (data->useConversion_) {\n \t\tdata->conversionQueue_.push({ request, std::move(buffers) });\n \t\tif (data->swIsp_)\n","prefixes":["v6","11/12"]}