{"id":23436,"url":"https://patchwork.libcamera.org/api/patches/23436/?format=json","web_url":"https://patchwork.libcamera.org/patch/23436/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250526101536.29222-6-mzamazal@redhat.com>","date":"2025-05-26T10:15:25","name":"[v6,05/12] libcamera: simple: Don't use raw output formats with conversions","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"783df6908290034ab573a8177980ff7a0b99c4ed","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23436/mbox/","series":[{"id":5194,"url":"https://patchwork.libcamera.org/api/series/5194/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5194","date":"2025-05-26T10:15:20","name":"Enable raw streams with software ISP","version":6,"mbox":"https://patchwork.libcamera.org/series/5194/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23436/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23436/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 44FAFC31E9\n\tfor ;\n\tMon, 26 May 2025 10:16:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A362368DAF;\n\tMon, 26 May 2025 12:16:08 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA1F568D93\n\tfor ;\n\tMon, 26 May 2025 12:16:02 +0200 (CEST)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-223-bseEtYm1NOKe86hOYQacbA-1;\n\tMon, 26 May 2025 06:15:58 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 3811B19560AA; Mon, 26 May 2025 10:15:57 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.226.78])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 266A91800DB9; Mon, 26 May 2025 10:15:54 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"ObSBX86X\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1748254561;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=d64K+K3+8Rva9LCM+PVwdvUH7J/vc6/ZROsw7RbwsY4=;\n\tb=ObSBX86XDeXLoW1hNBkDVh7/8/GWHsjNpqz8AbDzyIMvT7goYs39YGk5eQUFqhhshXanZe\n\tBNPs2jZR2S9W6lGWJzxd70ERoH/MXWH4HJPLYelTW2evW9v0/aLxF0x5wox7RhX4Zmkpyv\n\tAxKVwCs0CBpxPlabNByziAqc7QMj7Ck=","X-MC-Unique":"bseEtYm1NOKe86hOYQacbA-1","X-Mimecast-MFC-AGG-ID":"bseEtYm1NOKe86hOYQacbA_1748254557","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Laurent Pinchart\n\t, Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Paul Elder\n\t","Subject":"[PATCH v6 05/12] libcamera: simple: Don't use raw output formats\n\twith conversions","Date":"Mon, 26 May 2025 12:15:25 +0200","Message-ID":"<20250526101536.29222-6-mzamazal@redhat.com>","In-Reply-To":"<20250526101536.29222-1-mzamazal@redhat.com>","References":"<20250526101536.29222-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"gC19NIa32lzNBa8i-i4eX51JKLscv58ol6TPZT7qII4_1748254557","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In order to support raw streams, we need to add raw formats to software\nISP configurations. In this preparatory patch, the raw formats are\nexcluded from output configurations for conversions.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/pipeline/simple/simple.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex ab19149e..60b7e1b1 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -27,6 +27,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n \n@@ -1411,7 +1412,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \n \t\tcfg.setStream(&data->streams_[i]);\n \n-\t\tif (data->useConversion_)\n+\t\tif (data->useConversion_ && !isFormatRaw(cfg.pixelFormat))\n \t\t\toutputCfgs.push_back(cfg);\n \t}\n \n","prefixes":["v6","05/12"]}