[{"id":34345,"web_url":"https://patchwork.libcamera.org/comment/34345/","msgid":"<174799744324.43941.3262537426036242588@pyrite.rasen.tech>","date":"2025-05-23T10:50:43","subject":"Re: [PATCH] ipa: rpi: Prevent segfault if AGC algorithm is absent","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Benjamin Mugnier (2025-05-23 18:56:56)\n> Even without AGC definition in the tuning file, the application would\n> still dereference agc unconditionally, leading to a segmentation fault\n> if AGC is absent.\n> This is relevant for sensors already providing AGC/AEC by themselves.\n> Check if AGC is present prior to setting maximum exposure time.\n> \n> Signed-off-by: Benjamin Mugnier \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/rpi/common/ipa_base.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\n> index e0a93daa9db229bb2829803fffc6b2f6c8f11061..e0f8b7e782f4340a069a2d7b9cf9dee3141c72df 100644\n> --- a/src/ipa/rpi/common/ipa_base.cpp\n> +++ b/src/ipa/rpi/common/ipa_base.cpp\n> @@ -1563,7 +1563,8 @@ void IpaBase::applyFrameDurations(Duration minFrameDuration, Duration maxFrameDu\n> \n> RPiController::AgcAlgorithm *agc = dynamic_cast(\n> controller_.getAlgorithm(\"agc\"));\n> - agc->setMaxExposureTime(maxExposureTime);\n> + if (agc)\n> + agc->setMaxExposureTime(maxExposureTime);\n> }\n> \n> void IpaBase::applyAGC(const struct AgcStatus *agcStatus, ControlList &ctrls)\n> \n> ---\n> base-commit: ad5326c926831fe7a943d10fd800de43e596f171\n> change-id: 20250523-fix_segfault_agc-5f2735edec5f\n> \n> Best regards,\n> -- \n> Benjamin Mugnier \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F284C31E9\n\tfor ;\n\tFri, 23 May 2025 10:50:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1B3CC68D96;\n\tFri, 23 May 2025 12:50:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F5B068D76\n\tfor ;\n\tFri, 23 May 2025 12:50:50 +0200 (CEST)","from pyrite.rasen.tech (fp76f176b6.tkyc001.ap.nuro.jp\n\t[118.241.118.182])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 25D304A4;\n\tFri, 23 May 2025 12:50:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VkP55id9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747997427;\n\tbh=ao1pZeyH9BcX5Lw3u5lSTxVFpQ3vo9W29iHhkpZ/cGU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=VkP55id9fl7xSJqC42N8ZVU8QQIJY/ujQ4osasKpxxd14p8M2pS1Z0ayJ10WWCs4d\n\trgcDxHAezTqse6+Meo6Wv2zeZ5y8e7kkTzsYSgqSUrHSWVBnhVEDBUMEsIoOBw6Zea\n\tYrKGoGCGYORZZpH+L59PBaU7GByc3Y0k9r7FmzNI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250523-fix_segfault_agc-v1-1-aac60d87fd5c@foss.st.com>","References":"<20250523-fix_segfault_agc-v1-1-aac60d87fd5c@foss.st.com>","Subject":"Re: [PATCH] ipa: rpi: Prevent segfault if AGC algorithm is absent","From":"Paul Elder ","Cc":"Benjamin Mugnier ","To":"Benjamin Mugnier ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 23 May 2025 19:50:43 +0900","Message-ID":"<174799744324.43941.3262537426036242588@pyrite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34346,"web_url":"https://patchwork.libcamera.org/comment/34346/","msgid":"","date":"2025-05-23T11:10:22","subject":"Re: [PATCH] ipa: rpi: Prevent segfault if AGC algorithm is absent","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 05. 23. 11:56 keltezéssel, Benjamin Mugnier írta:\n> Even without AGC definition in the tuning file, the application would\n> still dereference agc unconditionally, leading to a segmentation fault\n> if AGC is absent.\n> This is relevant for sensors already providing AGC/AEC by themselves.\n> Check if AGC is present prior to setting maximum exposure time.\n> \n> Signed-off-by: Benjamin Mugnier \n\nTested-by: Barnabás Pőcze # RPi4 + imx708_wide\n\n../src/ipa/rpi/common/ipa_base.cpp:1591:25: runtime error: member access within null pointer of type 'struct AgcAlgorithm'\nAddressSanitizer:DEADLYSIGNAL\n=================================================================\n==415==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0xffff6dbf44a4 bp 0xffff706faed0 sp 0xffff706fad60 T1)\n==415==The signal is caused by a READ memory access.\n==415==Hint: address points to the zero page.\n #0 0xffff6dbf44a4 in libcamera::ipa::RPi::IpaBase::applyFrameDurations(libcamera::utils::Duration, libcamera::utils::Duration) ../src/ipa/rpi/common/ipa_base.cpp:1591\n ...\n\n\nRegards,\nBarnabás Pőcze\n\n\n> ---\n> src/ipa/rpi/common/ipa_base.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\n> index e0a93daa9db229bb2829803fffc6b2f6c8f11061..e0f8b7e782f4340a069a2d7b9cf9dee3141c72df 100644\n> --- a/src/ipa/rpi/common/ipa_base.cpp\n> +++ b/src/ipa/rpi/common/ipa_base.cpp\n> @@ -1563,7 +1563,8 @@ void IpaBase::applyFrameDurations(Duration minFrameDuration, Duration maxFrameDu\n> \n> \tRPiController::AgcAlgorithm *agc = dynamic_cast(\n> \t\tcontroller_.getAlgorithm(\"agc\"));\n> -\tagc->setMaxExposureTime(maxExposureTime);\n> +\tif (agc)\n> +\t\tagc->setMaxExposureTime(maxExposureTime);\n> }\n> \n> void IpaBase::applyAGC(const struct AgcStatus *agcStatus, ControlList &ctrls)\n> \n> ---\n> base-commit: ad5326c926831fe7a943d10fd800de43e596f171\n> change-id: 20250523-fix_segfault_agc-5f2735edec5f\n> \n> Best regards,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A0538BD78E\n\tfor ;\n\tFri, 23 May 2025 11:10:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A63C368D8A;\n\tFri, 23 May 2025 13:10:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C84E568D76\n\tfor ;\n\tFri, 23 May 2025 13:10:26 +0200 (CEST)","from [192.168.33.20] (185.221.141.78.nat.pool.zt.hu\n\t[185.221.141.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DB76A6B5;\n\tFri, 23 May 2025 13:10:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZZgA4Guv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747998604;\n\tbh=4VUaXUJBsrE97nC3GOyKyPTYjnJ1PBIWG/9ravJweE0=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=ZZgA4GuvVdN+4t/Ry/ErVzUelTE3n6zAn0FvZoK8oDMStYSBbQ/X0azF7UPVxMgFo\n\t+/w6BCASUfoEIUykUjGf1GpvtRbwcFJIpEkTF0ovMN7l4GIvl5NPg2R1t4B5XtwkWU\n\tsEgYYGQlhqZNSbGWTGsVg1fqgEk0CRmfBrG3aW84=","Message-ID":"","Date":"Fri, 23 May 2025 13:10:22 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] ipa: rpi: Prevent segfault if AGC algorithm is absent","To":"Benjamin Mugnier ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20250523-fix_segfault_agc-v1-1-aac60d87fd5c@foss.st.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250523-fix_segfault_agc-v1-1-aac60d87fd5c@foss.st.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34378,"web_url":"https://patchwork.libcamera.org/comment/34378/","msgid":"<174851573029.4056940.5860319392746453903@ping.linuxembedded.co.uk>","date":"2025-05-29T10:48:50","subject":"Re: [PATCH] ipa: rpi: Prevent segfault if AGC algorithm is absent","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nQuoting Benjamin Mugnier (2025-05-23 10:56:56)\n> Even without AGC definition in the tuning file, the application would\n> still dereference agc unconditionally, leading to a segmentation fault\n> if AGC is absent.\n> This is relevant for sensors already providing AGC/AEC by themselves.\n> Check if AGC is present prior to setting maximum exposure time.\n\nAny opinion on this ?\n\nI'm preparing/planning for the next libcamera release and I'm curious if\nthis should be in or not.\n\nRegards\n\nKieran\n\n> \n> Signed-off-by: Benjamin Mugnier \n> ---\n> src/ipa/rpi/common/ipa_base.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\n> index e0a93daa9db229bb2829803fffc6b2f6c8f11061..e0f8b7e782f4340a069a2d7b9cf9dee3141c72df 100644\n> --- a/src/ipa/rpi/common/ipa_base.cpp\n> +++ b/src/ipa/rpi/common/ipa_base.cpp\n> @@ -1563,7 +1563,8 @@ void IpaBase::applyFrameDurations(Duration minFrameDuration, Duration maxFrameDu\n> \n> RPiController::AgcAlgorithm *agc = dynamic_cast(\n> controller_.getAlgorithm(\"agc\"));\n> - agc->setMaxExposureTime(maxExposureTime);\n> + if (agc)\n> + agc->setMaxExposureTime(maxExposureTime);\n> }\n> \n> void IpaBase::applyAGC(const struct AgcStatus *agcStatus, ControlList &ctrls)\n> \n> ---\n> base-commit: ad5326c926831fe7a943d10fd800de43e596f171\n> change-id: 20250523-fix_segfault_agc-5f2735edec5f\n> \n> Best regards,\n> -- \n> Benjamin Mugnier \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 050B4C3237\n\tfor ;\n\tThu, 29 May 2025 10:48:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4CD768DA6;\n\tThu, 29 May 2025 12:48:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E33C614CE\n\tfor ;\n\tThu, 29 May 2025 12:48:53 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 103F76D5;\n\tThu, 29 May 2025 12:48:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"huhKgrZd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1748515706;\n\tbh=RGA02C6SRXoFLsNgpGJ52R2V3C60jIzaJgLyhhzPo/U=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=huhKgrZdXWzSEZiuTRyF0/SuJOrHzAkexJ3Q2f+XbmgFXjgBXA9Z4uzd/UCO7cK9r\n\t+JwNiwGoN43F41O8ha83WcWR5lEaJgHbPaN250x8rKTajN3TPhwZ9m+kiqmJQUDaQu\n\t1s+aUfcYcbQAlmLnniLhPtngecNVaJQ/UgY8X/y4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250523-fix_segfault_agc-v1-1-aac60d87fd5c@foss.st.com>","References":"<20250523-fix_segfault_agc-v1-1-aac60d87fd5c@foss.st.com>","Subject":"Re: [PATCH] ipa: rpi: Prevent segfault if AGC algorithm is absent","From":"Kieran Bingham ","Cc":"Benjamin Mugnier ","To":"Benjamin Mugnier ,\n\tlibcamera-devel@lists.libcamera.org,\n\tNaushir Patuck , ","Date":"Thu, 29 May 2025 11:48:50 +0100","Message-ID":"<174851573029.4056940.5860319392746453903@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34380,"web_url":"https://patchwork.libcamera.org/comment/34380/","msgid":"","date":"2025-05-29T11:14:54","subject":"Re: [PATCH] ipa: rpi: Prevent segfault if AGC algorithm is absent","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Benjamin,\n\nThank you for this fix!\n\nOn Fri, 23 May 2025 at 10:57, Benjamin Mugnier \nwrote:\n\n> Even without AGC definition in the tuning file, the application would\n> still dereference agc unconditionally, leading to a segmentation fault\n> if AGC is absent.\n> This is relevant for sensors already providing AGC/AEC by themselves.\n> Check if AGC is present prior to setting maximum exposure time.\n>\n> Signed-off-by: Benjamin Mugnier \n>\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> src/ipa/rpi/common/ipa_base.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/rpi/common/ipa_base.cpp\n> b/src/ipa/rpi/common/ipa_base.cpp\n> index\n> e0a93daa9db229bb2829803fffc6b2f6c8f11061..e0f8b7e782f4340a069a2d7b9cf9dee3141c72df\n> 100644\n> --- a/src/ipa/rpi/common/ipa_base.cpp\n> +++ b/src/ipa/rpi/common/ipa_base.cpp\n> @@ -1563,7 +1563,8 @@ void IpaBase::applyFrameDurations(Duration\n> minFrameDuration, Duration maxFrameDu\n>\n> RPiController::AgcAlgorithm *agc =\n> dynamic_cast(\n> controller_.getAlgorithm(\"agc\"));\n> - agc->setMaxExposureTime(maxExposureTime);\n> + if (agc)\n> + agc->setMaxExposureTime(maxExposureTime);\n> }\n>\n> void IpaBase::applyAGC(const struct AgcStatus *agcStatus, ControlList\n> &ctrls)\n>\n> ---\n> base-commit: ad5326c926831fe7a943d10fd800de43e596f171\n> change-id: 20250523-fix_segfault_agc-5f2735edec5f\n>\n> Best regards,\n> --\n> Benjamin Mugnier \n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0D3D6C3237\n\tfor ;\n\tThu, 29 May 2025 11:15:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CD67268DA6;\n\tThu, 29 May 2025 13:15:33 +0200 (CEST)","from mail-vk1-xa30.google.com (mail-vk1-xa30.google.com\n\t[IPv6:2607:f8b0:4864:20::a30])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D53F3614CE\n\tfor ;\n\tThu, 29 May 2025 13:15:31 +0200 (CEST)","by mail-vk1-xa30.google.com with SMTP id\n\t71dfb90a1353d-52f477d3374so28006e0c.3\n\tfor ;\n\tThu, 29 May 2025 04:15:31 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"j+Jpva3z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1748517330; x=1749122130;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=k9oeUqEEA7jKqP94V2wgl6OaSqMpz5eIlf/YhrRiino=;\n\tb=j+Jpva3zWk13hA9NCD1VdsJ/6iB94ycM46jCIZi6zAJuACEYHG0aeav4KOLIGoxFB5\n\tNvB1U0VCvilCjkNCUBMuUlfI4X7z+aRurIT0Zhy6aXuolFRg4OD3ppl79PqUQQdXMVps\n\tCYA95s0BKuTbC/BvhVC9zmD7CpHz1TELmkbSC4qkiAhBznFobpTAoQZcH6yZe44ECxzc\n\tF3ayIgXB3vPwMzNJWbcwbqQPvfG7OoqgBr9d6QVykDl9vNUVwG0dku/5WDtFQE/B8b9g\n\tHnHXfDViurdD3wvdI1nKNg0VvT5socTtS3z+dAKHkOFjjDxTy7ebtc5UTh7TQ5IiDOt0\n\t6qpQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1748517330; x=1749122130;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=k9oeUqEEA7jKqP94V2wgl6OaSqMpz5eIlf/YhrRiino=;\n\tb=SkyKs6bYTd7uqKmdSDdHK/69H5zIqMy/8cGsWgFy2JYRA29IMQ8N0AVudmYD5WxARI\n\ta1+aUPiapylI3YRtVVLEmq48PDU/L79ujWHP8SzEdcwgfy5KnPsVzXuNZBrB0sI5iUv7\n\tx2MOjN6SXdW0LZNX21N+dTISaPFvCW3W4CVHWfmdntRj+vod44a+v8yd0qln6IDRfejE\n\tbWKhcJmkEIH1YsiXo7FfRP4O1dHpAcz3TAGMGItEXMR2E6L670vB+cI1Y44xJo9Peta6\n\tBKNG4wiCvTb8APx6esvJcF/RWiKlSJf77rABtQLyeAWVmNrqi0AqSbmRtfp/ZtA/Si8f\n\tJmcQ==","X-Gm-Message-State":"AOJu0YyFMxOgvp3L9v6l90b3fuGrDRnSLxBKVDhgh+bsguhNjbzLrWgK\n\thTgsyV2Ch15okTCiWq9+N3zEHnxfcPmt2KM3uf/Gzor1TZOxiTHEwc1qPVRLwavZUin1THMk+LG\n\txHKRESumfcbgOKnYafBtqFapIop8MNYap88YWBxzofJZvInqkqGHl","X-Gm-Gg":"ASbGnctcB9NyS1IrgGB/p0Ohb4El3hUJK0jISol+NsRFNNp+EfN9Dzexj3eheuYBUHG\n\te12hIqSYqUFXo0c15mudbNYfv63SggySfFukj9KR/Z2WEBbCMkzSxOWU8r7aUMLTNmn35cfow8+\n\tFm0+QhynEbqlh7DMCBRrOlIIptjYSzYcAp","X-Google-Smtp-Source":"AGHT+IHgtPtvdnjbBm9m5cNZQKg9/fUXMDtryPwxLcTkhqZQkq0APEUhvJQoOc4t+pbIC7fChylwU6Wo8mGf5FcT7zk=","X-Received":"by 2002:a05:6122:366f:b0:530:5764:8f4a with SMTP id\n\t71dfb90a1353d-530576491ebmr2153721e0c.0.1748517330656;\n\tThu, 29 May 2025 04:15:30 -0700 (PDT)","MIME-Version":"1.0","References":"<20250523-fix_segfault_agc-v1-1-aac60d87fd5c@foss.st.com>","In-Reply-To":"<20250523-fix_segfault_agc-v1-1-aac60d87fd5c@foss.st.com>","From":"Naushir Patuck ","Date":"Thu, 29 May 2025 12:14:54 +0100","X-Gm-Features":"AX0GCFss9QDzW2FaQFUzC4kpfGCRFRPfB_W6RTtyjcPBGywWle8gOk1qj9s5Nsc","Message-ID":"","Subject":"Re: [PATCH] ipa: rpi: Prevent segfault if AGC algorithm is absent","To":"Benjamin Mugnier ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"00000000000060ba650636446a49\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]