[{"id":34340,"web_url":"https://patchwork.libcamera.org/comment/34340/","msgid":"<25df50b62ad8627c621d93f2d2e855bf94bf3ad8.camel@collabora.com>","date":"2025-05-22T17:35:39","subject":"Re: [PATCH 3/4] gstreamer: Fix leak of GstQuery in error path","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"Hi,\n\nLe jeudi 22 mai 2025 à 14:55 +0200, Laurent Pinchart a écrit :\n> The gst_libcamera_create_video_pool() function leaks a GstQuery instance\n> in an error path. Fix it with g_autoptr().\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Nicolas Dufresne \n\nnice catch,\nNicolas\n\n> ---\n>  src/gstreamer/gstlibcamerasrc.cpp | 3 +--\n>  1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 71f5700d9de7..380f8368af8b 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -526,7 +526,7 @@ gst_libcamera_create_video_pool(GstLibcameraSrc *self,\n>  \t\t\t\tGstVideoInfo *info, GstPad *srcpad,\n>  \t\t\t\tGstCaps *caps)\n>  {\n> -\tGstQuery *query = NULL;\n> +\tg_autoptr(GstQuery) query = NULL;\n>  \tconst gboolean need_pool = true;\n>  \tgboolean has_video_meta = false;\n>  \tGstBufferPool *video_pool = NULL;\n> @@ -571,7 +571,6 @@ gst_libcamera_create_video_pool(GstLibcameraSrc *self,\n>  \t\t}\n>  \t}\n>  \n> -\tgst_query_unref(query);\n>  \treturn { video_pool, 0 };\n>  }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67405BD78E\n\tfor ;\n\tThu, 22 May 2025 17:35:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1B98968D97;\n\tThu, 22 May 2025 19:35:42 +0200 (CEST)","from bali.collaboradmins.com (bali.collaboradmins.com\n\t[IPv6:2a01:4f8:201:9162::2])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1778768D8B\n\tfor ;\n\tThu, 22 May 2025 19:35:41 +0200 (CEST)","from [IPv6:2606:6d00:17:b2fc::5ac] (unknown\n\t[IPv6:2606:6d00:17:b2fc::5ac])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bali.collaboradmins.com (Postfix) with ESMTPSA id 3C6FF17E0FB8;\n\tThu, 22 May 2025 19:35:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=collabora.com header.i=@collabora.com\n\theader.b=\"jx4zGYjT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;\n\ts=mail; t=1747935340;\n\tbh=Ya3fsOUKsARLQtW6bcn5uFlwojnlkSVm6NL59rBMmQI=;\n\th=Subject:From:To:Cc:Date:In-Reply-To:References:From;\n\tb=jx4zGYjTxG9DUteD5tKEskTYPb5p803Rol5GPJmd6n+ySu+Zi+o+JXlILZ88N6G9c\n\thECqqjw431d31zbImqg44M8mZfx4Vcy8TAZVkpV6H53YZHcS/4Kn8B4sN9F0QOL5Vy\n\t8SVlHZtYa76XxmrvuMmUbJgdxVL0vPlCUnGTW8cqq+gCdv2cm15kTMacICA8Zdv+z2\n\tW6NU45T/QDKPYADmT8ADtHiaWPq6Kn17JH/nIFSNt7KltY8nx7oZManRXmfAm1IU0j\n\tbMJ5d/vbq3U7tiq5T4HmRHPG03L+ug/Ml5UW3ZD2ETDmwGnAZkboveEG4C7pccKoxt\n\tqRyZ0bNBmaGLA==","Message-ID":"<25df50b62ad8627c621d93f2d2e855bf94bf3ad8.camel@collabora.com>","Subject":"Re: [PATCH 3/4] gstreamer: Fix leak of GstQuery in error path","From":"Nicolas Dufresne ","To":"Laurent Pinchart , \n\tlibcamera-devel@lists.libcamera.org","Cc":"Hou Qi ","Date":"Thu, 22 May 2025 13:35:39 -0400","In-Reply-To":"<20250522125521.6465-4-laurent.pinchart@ideasonboard.com>","References":"<20250522125521.6465-1-laurent.pinchart@ideasonboard.com>\n\t<20250522125521.6465-4-laurent.pinchart@ideasonboard.com>","Organization":"Collabora Canada","Content-Type":"text/plain; charset=\"UTF-8\"","User-Agent":"Evolution 3.56.1 (3.56.1-1.fc42) ","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]