[{"id":34305,"web_url":"https://patchwork.libcamera.org/comment/34305/","msgid":"<20250521161612.GF12421@pendragon.ideasonboard.com>","date":"2025-05-21T16:16:12","subject":"Re: [PATCH 1/2] libcamera/mali-c55: Remove tpgCodes_","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, May 21, 2025 at 02:21:01PM +0100, Daniel Scally wrote:\n> MaliC55CameraData stores a vector of the TPG's mbus codes (if the\n> camera in question is a TPG). This is never used - remove it.\n> \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 4 ----\n> 1 file changed, 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> index a05e11fccf8dfde1a0eeda994afe2d78d884c530..35372ee1ed6f694166c395088c65509d32b9d1f2 100644\n> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> @@ -131,7 +131,6 @@ private:\n> \tvoid setSensorControls(const ControlList &sensorControls);\n> \n> \tstd::string id_;\n> -\tstd::vector tpgCodes_;\n> \tstd::vector tpgSizes_;\n> \tSize tpgResolution_;\n> };\n> @@ -180,9 +179,6 @@ void MaliC55CameraData::initTPGData()\n> \tif (formats.empty())\n> \t\treturn;\n> \n> -\ttpgCodes_ = utils::map_keys(formats);\n> -\tstd::sort(tpgCodes_.begin(), tpgCodes_.end());\n> -\n> \tfor (const auto &format : formats) {\n> \t\tconst std::vector &ranges = format.second;\n> \t\tstd::transform(ranges.begin(), ranges.end(), std::back_inserter(tpgSizes_),","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E43A5C31E9\n\tfor ;\n\tWed, 21 May 2025 16:16:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2552268D92;\n\tWed, 21 May 2025 18:16:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B54C068C91\n\tfor ;\n\tWed, 21 May 2025 18:16:18 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(179.218-130-109.adsl-dyn.isp.belgacom.be [109.130.218.179])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3644F6B5;\n\tWed, 21 May 2025 18:15:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Hi9Wg/ru\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747844157;\n\tbh=VjhJyFgAhBhAok6ahylU4Dgxx2sm2ajBLtZfYsEv2ig=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Hi9Wg/ruxaaCOeTjkc1cA4+DfNvl2bbAdMYCf5QwcG24RC7hHXwJvMIhVIUfUy2H1\n\tT031LTpxxBuMloRUEBnAAhIhOAKBmiBaMSvmbl5qHQvnYPZGhYMJh8uneYqgEspxWE\n\tuZt9O9dJB0MFjqFbjMl78ejRpZr9QsiwRxaZ8js8=","Date":"Wed, 21 May 2025 18:16:12 +0200","From":"Laurent Pinchart ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/2] libcamera/mali-c55: Remove tpgCodes_","Message-ID":"<20250521161612.GF12421@pendragon.ideasonboard.com>","References":"<20250521-djrscally-c55-cleanup-v1-0-aa171b2aed38@ideasonboard.com>\n\t<20250521-djrscally-c55-cleanup-v1-1-aa171b2aed38@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250521-djrscally-c55-cleanup-v1-1-aa171b2aed38@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34307,"web_url":"https://patchwork.libcamera.org/comment/34307/","msgid":"<174784470650.2114591.10321143299046336578@ping.linuxembedded.co.uk>","date":"2025-05-21T16:25:06","subject":"Re: [PATCH 1/2] libcamera/mali-c55: Remove tpgCodes_","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-05-21 17:16:12)\n> On Wed, May 21, 2025 at 02:21:01PM +0100, Daniel Scally wrote:\n> > MaliC55CameraData stores a vector of the TPG's mbus codes (if the\n> > camera in question is a TPG). This is never used - remove it.\n> > \n> > Signed-off-by: Daniel Scally \n> \n> Reviewed-by: Laurent Pinchart \n> \n\nReviewed-by: Kieran Bingham \n\n> > ---\n> > src/libcamera/pipeline/mali-c55/mali-c55.cpp | 4 ----\n> > 1 file changed, 4 deletions(-)\n> > \n> > diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> > index a05e11fccf8dfde1a0eeda994afe2d78d884c530..35372ee1ed6f694166c395088c65509d32b9d1f2 100644\n> > --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> > +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> > @@ -131,7 +131,6 @@ private:\n> > void setSensorControls(const ControlList &sensorControls);\n> > \n> > std::string id_;\n> > - std::vector tpgCodes_;\n> > std::vector tpgSizes_;\n> > Size tpgResolution_;\n> > };\n> > @@ -180,9 +179,6 @@ void MaliC55CameraData::initTPGData()\n> > if (formats.empty())\n> > return;\n> > \n> > - tpgCodes_ = utils::map_keys(formats);\n> > - std::sort(tpgCodes_.begin(), tpgCodes_.end());\n> > -\n> > for (const auto &format : formats) {\n> > const std::vector &ranges = format.second;\n> > std::transform(ranges.begin(), ranges.end(), std::back_inserter(tpgSizes_),\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0AC78C31E9\n\tfor ;\n\tWed, 21 May 2025 16:25:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D4DA568D93;\n\tWed, 21 May 2025 18:25:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 89A3E68C91\n\tfor ;\n\tWed, 21 May 2025 18:25:09 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E14766B5;\n\tWed, 21 May 2025 18:24:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZPH8N2c7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747844688;\n\tbh=pu8qtJMIRwIKX60jkf3Ded75pR3TBGHUgp/vP+vfirI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ZPH8N2c7EAlU8t8JxjUVUsev2SSTCLVSNo0HapnFpUz0yXYQDw8+jLq4Q/zsVVrXW\n\tZPfRNLuU7obdOsSEzR8Mt+kkgaiAet0Np6fHWoygJ0tvnImX/Nw6PASSy8ojxN0T6s\n\t7zI5qe/jZQU5NHxaCgjr+Nm/MFc/KWAPsUGsRdtU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250521161612.GF12421@pendragon.ideasonboard.com>","References":"<20250521-djrscally-c55-cleanup-v1-0-aa171b2aed38@ideasonboard.com>\n\t<20250521-djrscally-c55-cleanup-v1-1-aa171b2aed38@ideasonboard.com>\n\t<20250521161612.GF12421@pendragon.ideasonboard.com>","Subject":"Re: [PATCH 1/2] libcamera/mali-c55: Remove tpgCodes_","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Daniel Scally ,\n\tLaurent Pinchart ","Date":"Wed, 21 May 2025 17:25:06 +0100","Message-ID":"<174784470650.2114591.10321143299046336578@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]