[{"id":34318,"web_url":"https://patchwork.libcamera.org/comment/34318/","msgid":"<174790765600.244022.11930999296241955346@localhost>","date":"2025-05-22T09:54:16","subject":"Re: [PATCH v1 2/2] libcameara: sensor: Fix the gain delay for IMX283","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch. \n\nQuoting Naushir Patuck (2025-05-21 12:19:52)\n> The IMX283 uses a gain delay of 1 instead of the current value of 2 as\n> defined in the sensor properties. Fix it.\n\nI had that fix locally due to my PFC measurements and wasn't yet sure if\nI introduced an error on my side somewhere. Glad you confirmed my\nmeasurements now.\n\nReviewed-by: Stefan Klug \n\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/sensor/camera_sensor_properties.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index e2f518f9ea62..c9e9e148a1f0 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -194,7 +194,7 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> .testPatternModes = {},\n> .sensorDelays = {\n> .exposureDelay = 2,\n> - .gainDelay = 2,\n> + .gainDelay = 1,\n> .vblankDelay = 2,\n> .hblankDelay = 2\n> },\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1867EC31E9\n\tfor ;\n\tThu, 22 May 2025 09:54:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6593868D92;\n\tThu, 22 May 2025 11:54:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D234468D7A\n\tfor ;\n\tThu, 22 May 2025 11:54:18 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:30c3:8bbb:632f:b0c9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C6EAB56D;\n\tThu, 22 May 2025 11:53:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"F6EfZ7lJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747907636;\n\tbh=bSch3EwQBPsKbXNYToo/Lx7wSOgaRwxD4qBWOGiZd38=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=F6EfZ7lJJEpU8HK2ZgeXVDQNpHCdCREsi8O9plqOvCsqb0sB4xXJ5IUcArhK7aoeN\n\tWRCOGtbfL3bwJARSA82WbeXxPAIWDBxTAOQQOtlDXJhzZxONvlssY9Y32rjx2qaCvg\n\t4T9U82UX4CUqWj97dqKO6NcS07ivL97DQK1YQTRQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250521102208.989701-3-naush@raspberrypi.com>","References":"<20250521102208.989701-1-naush@raspberrypi.com>\n\t<20250521102208.989701-3-naush@raspberrypi.com>","Subject":"Re: [PATCH v1 2/2] libcameara: sensor: Fix the gain delay for IMX283","From":"Stefan Klug ","Cc":"Naushir Patuck ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 22 May 2025 11:54:16 +0200","Message-ID":"<174790765600.244022.11930999296241955346@localhost>","User-Agent":"alot/0.12.dev16+g501a9541e2e6.d20250519","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34319,"web_url":"https://patchwork.libcamera.org/comment/34319/","msgid":"<174790991238.247467.7974343134181709341@ping.linuxembedded.co.uk>","date":"2025-05-22T10:31:52","subject":"Re: [PATCH v1 2/2] libcameara: sensor: Fix the gain delay for IMX283","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2025-05-21 11:19:52)\n> The IMX283 uses a gain delay of 1 instead of the current value of 2 as\n> defined in the sensor properties. Fix it.\n> \n> Signed-off-by: Naushir Patuck \n\nGreat, I hadn't noticed any oscillations here - but I didn't check as\nclosely as Stefan had.\n\n\nReviewed-by: Kieran Bingham \n\nAnd pulling in Pauls ack for Patchwork state:\n\nAcked-by: Paul Elder \n\n> ---\n> src/libcamera/sensor/camera_sensor_properties.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index e2f518f9ea62..c9e9e148a1f0 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -194,7 +194,7 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> .testPatternModes = {},\n> .sensorDelays = {\n> .exposureDelay = 2,\n> - .gainDelay = 2,\n> + .gainDelay = 1,\n> .vblankDelay = 2,\n> .hblankDelay = 2\n> },\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F7A3BD78E\n\tfor ;\n\tThu, 22 May 2025 10:31:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 34B4268D8E;\n\tThu, 22 May 2025 12:31:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8BBE768D8B\n\tfor ;\n\tThu, 22 May 2025 12:31:55 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C070C59;\n\tThu, 22 May 2025 12:31:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IdtWUT4l\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747909893;\n\tbh=JtgN40u4y4rF0EEIDQ9v/nezdJBYgqW8nitB4vwY8hs=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=IdtWUT4lUlvczoQNFypJ0aYrG9GP159YQlVClAH5K87/x5IiUHWVEreGFidFBysCo\n\twvzGOWKxlcZ3Fc1T+h1JZQMc4VnPdbCyc20F/o3/RyC5P2MxldLxF+02MhraScFEIx\n\tUcK1RcTDxO53X0DfnPYuE0ivnM4w4J6SgHHEoIsA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250521102208.989701-3-naush@raspberrypi.com>","References":"<20250521102208.989701-1-naush@raspberrypi.com>\n\t<20250521102208.989701-3-naush@raspberrypi.com>","Subject":"Re: [PATCH v1 2/2] libcameara: sensor: Fix the gain delay for IMX283","From":"Kieran Bingham ","Cc":"Naushir Patuck ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 22 May 2025 11:31:52 +0100","Message-ID":"<174790991238.247467.7974343134181709341@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]